|author||Julie Hockett <firstname.lastname@example.org>||Wed May 29 14:09:36 2019 -0700|
|committer||Commit Bot <email@example.com>||Thu May 30 00:15:11 2019 +0000|
Minor fixes to tracing The chrome://tracing expects the timestamp to be in microseconds, but it had been stored in the TraceItem in nanoseconds, so this fixes it. Also adds quotes around the thread_id, since on Mac it is written in hex format and so the JSON parser doesn't recognize it. Finally, adds toolchain information to the import traces. Change-Id: If5960074d4fc8301cbcc4a3524cb17ab6a95010a Reviewed-on: https://gn-review.googlesource.com/c/gn/+/5140 Commit-Queue: Julie Hockett <firstname.lastname@example.org> Reviewed-by: Scott Graham <email@example.com>
Alternatively, you can build GN from source:
git clone https://gn.googlesource.com/gn cd gn python build/gen.py ninja -C out # To run tests: out/gn_unittests
On Windows, it is expected that
lib.exe can be found in
PATH, so you'll want to run from a Visual Studio command prompt, or similar.
On Linux and Mac, the default compiler is
clang++, a recent version is expected to be found in
PATH. This can be overridden by setting
If you find a bug, you can see if it is known or report it in the bug database.
GN uses Gerrit for code review. The short version of how to patch is:
Register at https://gn-review.googlesource.com. ... edit code ... ninja -C out && out/gn_unittests
Then, to upload a change for review:
git commit git cl upload --gerrit
When revising a change, use:
git commit --amend git cl upload --gerrit
which will add the new changes to the existing code review, rather than creating a new one.
We ask that all contributors sign Google's Contributor License Agreement (either individual or corporate as appropriate, select ‘any other Google project’).
You may ask questions and follow along w/ GN‘s development on Chromium’s gn-dev@ Google Group.