| commit | 8c7f49102234f4f4b9349dcb258554675475e596 | [log] [tgz] |
|---|---|---|
| author | Tomasz Śniatowski <tsniatowski@vewd.com> | Mon Jun 10 08:39:14 2019 +0200 |
| committer | Commit Bot <commit-bot@chromium.org> | Mon Jun 10 16:41:33 2019 +0000 |
| tree | 4028165f7212fd181dba247d67cbdc960d56ed4f | |
| parent | 8f8178c5cd01fd06ad6b7b527c255cf75e8e2ece [diff] |
rust: fix build on older clang A rustic stock Ubuntu 16.04 clang refused to build the map.insert call in rust_target_generator.cc. Fix by avoiding an explicit std::pair constructor call, and a suspicious std::move on another map's key. Call map.emplace instead, with an explicit StringPiece-to-std::string conversion. Change-Id: Icb3ce534fa509dc7aba6cb5cef93912eb94cbca7 Reviewed-on: https://gn-review.googlesource.com/c/gn/+/5180 Reviewed-by: Julie Hockett <juliehockett@google.com> Reviewed-by: Brett Wilson <brettw@google.com> Commit-Queue: Brett Wilson <brettw@google.com>
GN is a meta-build system that generates build files for Ninja. There is documentation in docs/ and a presentation on it.
You can download the latest version of GN binary for Linux, macOS and Windows.
Alternatively, you can build GN from source:
git clone https://gn.googlesource.com/gn cd gn python build/gen.py ninja -C out # To run tests: out/gn_unittests
On Windows, it is expected that cl.exe, link.exe, and lib.exe can be found in PATH, so you'll want to run from a Visual Studio command prompt, or similar.
On Linux and Mac, the default compiler is clang++, a recent version is expected to be found in PATH. This can be overridden by setting CC, CXX, and AR.
If you find a bug, you can see if it is known or report it in the bug database.
GN uses Gerrit for code review. The short version of how to patch is:
Register at https://gn-review.googlesource.com. ... edit code ... ninja -C out && out/gn_unittests
Then, to upload a change for review:
git commit git cl upload --gerrit
When revising a change, use:
git commit --amend git cl upload --gerrit
which will add the new changes to the existing code review, rather than creating a new one.
We ask that all contributors sign Google's Contributor License Agreement (either individual or corporate as appropriate, select ‘any other Google project’).
You may ask questions and follow along w/ GN‘s development on Chromium’s gn-dev@ Google Group.