)]}'
{
  "commit": "93550dc1701d16c4c1c6c78408e61f09485f3dd0",
  "tree": "c7f0478ac87f18ba245a196a9c6768edb4bbe473",
  "parents": [
    "449f3e4dfb45f6489321746f79f47f3e0d50211d"
  ],
  "author": {
    "name": "Takuto Ikuta",
    "email": "tikuta@google.com",
    "time": "Tue Aug 13 16:24:56 2024 +0900"
  },
  "committer": {
    "name": "GN LUCI",
    "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Tue Aug 13 07:38:16 2024 +0000"
  },
  "message": "generated_file: add output to input deps of stamp\n\nBy having outputs from generated file to input of stamp, dependency to\noutput of generated_file target is properly handled by siso.\n\nCurrently, we have siso config to collect inputs via transitive\ndependency like\nhttps://source.chromium.org/chromium/chromium/src/+/main:build/config/siso/mojo.star;l\u003d45-53;drc\u003d6041333279beac2504de56eb014ef888b79850a6\n\nBut we also need to have missing inputs list for some target like\nhttps://source.chromium.org/chromium/chromium/src/+/main:build/config/siso/mojo.star;l\u003d59;drc\u003d6041333279beac2504de56eb014ef888b79850a6\ndue to group target of parser_target_name doesn\u0027t have deps to\nbuild_metadata_filename in\nhttps://source.chromium.org/chromium/chromium/src/+/main:mojo/public/tools/bindings/mojom.gni;l\u003d728;drc\u003d1b561e6dca846e2b0ebf2c613b1bd94f76efdd5b\n\nTo fix this, I changed to use generated_file instead of write_file in\nhttps://crrev.com/c/5772141. But to make siso recognize collect inputs\nfor mojom_parser action, generated_file target needs to have deps to\nactual generated_file output in ninja file.\n\nBug: b/288523418\nChange-Id: If6dd5b3b5f6fffdab4fdeab93c76f7cd50d9ca4c\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/17500\nReviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "6c157e48932a8f0332d162ee61d2c791bd8ce302",
      "old_mode": 33188,
      "old_path": "src/gn/ninja_generated_file_target_writer.cc",
      "new_id": "f09872eac135d791697b6c45a2ebbe68b6a37dae",
      "new_mode": 33188,
      "new_path": "src/gn/ninja_generated_file_target_writer.cc"
    },
    {
      "type": "modify",
      "old_id": "676ba01a17dd78584f9fff64472671e99721d558",
      "old_mode": 33188,
      "old_path": "src/gn/ninja_generated_file_target_writer_unittest.cc",
      "new_id": "f883102068f01bd51107d461411d99d3dd833100",
      "new_mode": 33188,
      "new_path": "src/gn/ninja_generated_file_target_writer_unittest.cc"
    }
  ]
}
