commit 93a9620b59ab9395a1dcbca8a119517ea1a0022f
author brettw <brettw@chromium.org> Mon Nov 30 15:53:59 2015 -0800
committer Commit bot <commit-bot@chromium.org> Mon Nov 30 23:54:36 2015 +0000
tree a708017d7370fca68ed49302d4ae31050c527736
parent c08670e47d8a8d13778e88e0c4e14fb5263d763d

Improve GN asmflags help.

Hooks up asmflags to the "gn help" overview (the INSERT_VARIABLE line was missing). Reference asmflags from the cflag help, and include flag ordering information on the asmflags help.

Review URL: https://codereview.chromium.org/1489683002

Cr-Original-Commit-Position: refs/heads/master@{#362279}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fde26f231be483ca7b25d89503e0c76ff70cda97

tools/gn/variables.cc

diff --git a/tools/gn/variables.cc b/tools/gn/variables.cc
index 7898273..3b1f7b1 100644
--- a/tools/gn/variables.cc
+++ b/tools/gn/variables.cc
@@ -404,23 +404,24 @@
     "\n"
     "  To target one of these variants individually, use \"cflags_c\",\n"
     "  \"cflags_cc\", \"cflags_objc\", and \"cflags_objcc\",\n"
-    "  respectively.\n"
+    "  respectively. These variant-specific versions of cflags* will be\n"
+    "  appended on the compiler command line after \"cflags\".\n"
     "\n"
-    "  These variant-specific versions of cflags* will be appended to the\n"
-    "  \"cflags\".\n"
+    "  See also \"asmflags\" for flags for assembly-language files.\n"
     COMMON_ORDERING_HELP;
 const char* kCflags_Help = kCommonCflagsHelp;
 
 const char kAsmflags[] = "asmflags";
 const char kAsmflags_HelpShort[] =
-    "asmflags: [string list] Flags passed to any assembly compiler.";
+    "asmflags: [string list] Flags passed to the assembler.";
 const char* kAsmflags_Help =
-    "asmflags: Flags passed to any assembly compiler.\n"
+    "asmflags: Flags passed to the assembler.\n"
     "\n"
     "  A list of strings.\n"
     "\n"
     "  \"asmflags\" are passed to any invocation of a tool that takes an\n"
-    "  .asm or .S file as input.\n";
+    "  .asm or .S file as input.\n"
+    COMMON_ORDERING_HELP;
 
 const char kCflagsC[] = "cflags_c";
 const char kCflagsC_HelpShort[] =
@@ -1390,6 +1391,7 @@
     INSERT_VARIABLE(AllDependentConfigs)
     INSERT_VARIABLE(AllowCircularIncludesFrom)
     INSERT_VARIABLE(Args)
+    INSERT_VARIABLE(Asmflags)
     INSERT_VARIABLE(Cflags)
     INSERT_VARIABLE(CflagsC)
     INSERT_VARIABLE(CflagsCC)