Make gen.py compatible with python3

Convert subprocess output from bytes to string using decode(). This
allows a string-based regex to be used.

Open last-commit-position.h using text mode instead of binary. This
causes f.read() to return a string, and allows f.write() to accept a
string.

Use dict.items() instead of dict.iteritems(). This makes the code
slightly slower under python2, but gen.py is rarely invoked anyway.

Change-Id: I0eb9aec758433b0cd26fdb4647bd56337ca89f4b
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/4400
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
1 file changed
tree: 52b836525311bea29d8911f7af5248bd6a9b9d0a
  1. base/
  2. build/
  3. docs/
  4. infra/
  5. tools/
  6. util/
  7. .clang-format
  8. .editorconfig
  9. .gitignore
  10. .style.yapf
  11. AUTHORS
  12. LICENSE
  13. OWNERS
  14. README.md
README.md

GN

GN is a meta-build system that generates build files for Ninja. There is documentation in docs/ and a presentation on it.

Getting started

You can download the latest version of GN binary for Linux, macOS and Windows.

Alternatively, you can build GN from source:

git clone https://gn.googlesource.com/gn
cd gn
python build/gen.py
ninja -C out
# To run tests:
out/gn_unittests

On Windows, it is expected that cl.exe, link.exe, and lib.exe can be found in PATH, so you'll want to run from a Visual Studio command prompt, or similar.

On Linux and Mac, the default compiler is clang++, a recent version is expected to be found in PATH. This can be overridden by setting CC, CXX, and AR.

Reporting bugs

If you find a bug, you can see if it is known or report it in the bug database.

Sending patches

GN uses Gerrit for code review. The short version of how to patch is:

Register at https://gn-review.googlesource.com.

... edit code ...
ninja -C out && out/gn_unittests

Then, to upload a change for review:

git commit
git cl upload --gerrit

When revising a change, use:

git commit --amend
git cl upload --gerrit

which will add the new changes to the existing code review, rather than creating a new one.

We ask that all contributors sign Google's Contributor License Agreement (either individual or corporate as appropriate, select ‘any other Google project’).

Community

You may ask questions and follow along w/ GN‘s development on Chromium’s gn-dev@ Google Group.