commit 955b511c4fe7aa515292f38b209743ae5bbfa8d5
author sdefresne <sdefresne@chromium.org> Tue Apr 05 16:38:22 2016 -0700
committer Commit bot <commit-bot@chromium.org> Tue Apr 05 23:39:31 2016 +0000
tree 81ddc77da964c88ee2cdc1859e4b3f01e51b70be
parent fc4ca3415537cdc61a376888557dfbe5e0a8612d

[GN] Fix create_bundle to respect "data_deps" dependencies.

Add "data_deps" output dependency files as order only dependencies of
"create_bundle" target to fix the issue that "data_deps" are not build.

BUG=599203

Review URL: https://codereview.chromium.org/1855523003

Cr-Original-Commit-Position: refs/heads/master@{#385325}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f8bb64b067eb0e61773b87c86fdda45f53e47498

tools/gn/ninja_create_bundle_target_writer.cc

diff --git a/tools/gn/ninja_create_bundle_target_writer.cc b/tools/gn/ninja_create_bundle_target_writer.cc
index b92001d..d85f240 100644
--- a/tools/gn/ninja_create_bundle_target_writer.cc
+++ b/tools/gn/ninja_create_bundle_target_writer.cc
@@ -111,5 +111,9 @@
   }
 
   out_ << std::endl;
-  WriteStampForTarget(output_files, std::vector<OutputFile>());
+
+  std::vector<OutputFile> order_only_deps;
+  for (const auto& pair : target_->data_deps())
+    order_only_deps.push_back(pair.ptr->dependency_output_file());
+  WriteStampForTarget(output_files, order_only_deps);
 }