)]}' { "commit": "972ed755f8e6d31cae9ba15fcd08136ae1a7886f", "tree": "abfeee47a2944a0ec9bd5219bb4345261e711ce8", "parents": [ "a3e0807fdd7a1fde37d73add8c1581136f58c104" ], "author": { "name": "Brett Wilson", "email": "brettw@chromium.org", "time": "Wed May 22 10:32:29 2019 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Jun 17 17:47:57 2019 +0000" }, "message": "Update to more uses of C++11.\n\nAdds move constructors to some fundamental types such as SourceFile,\nSourceDir, and Label.\n\nRemoves most uses of swap and custom swap definitions in favor of move\nsemantics.\n\nConverts most default class member initialization to declare default\nvalues in the definition.\n\nMoves more to using implicit and defaulted-in-the-header constructors\nand destructors. The previous style was inherited from Chrome which had\nthose rules out of concern for code size. But for this small project the\nheader-based ones are a little easier to follow.\n\nChange-Id: I7d5c3bd4ac9863c34b1072fdefef81e59e555a7f\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/5080\nCommit-Queue: Brett Wilson \u003cbrettw@google.com\u003e\nReviewed-by: Scott Graham \u003cscottmg@chromium.org\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "312c22aab016bc4d80916093b8034a8fd5c0f359", "old_mode": 33188, "old_path": "tools/gn/analyzer.cc", "new_id": "c58cf8cf6a45ef0ef6450ddf63bbdc26b273bb1c", "new_mode": 33188, "new_path": "tools/gn/analyzer.cc" }, { "type": "modify", "old_id": "3cc211bb5151510d1737b91b393c136a8d8c544e", "old_mode": 33188, "old_path": "tools/gn/build_settings.cc", "new_id": "711c6b8c852a30afeb97212528fb4b51ed416a18", "new_mode": 33188, "new_path": "tools/gn/build_settings.cc" }, { "type": "modify", "old_id": "51a7d6b4bb3cfdfdb0c4abbbf5ff6b9f25485bdf", "old_mode": 33188, "old_path": "tools/gn/build_settings.h", "new_id": "646472f72d70765c86e07781686eb4ec4f8091e8", "new_mode": 33188, "new_path": "tools/gn/build_settings.h" }, { "type": "modify", "old_id": "36fd465c484c921fd783b4d0c142fb86c85b49f7", "old_mode": 33188, "old_path": "tools/gn/builder_record.cc", "new_id": "14e87b6709f2caa17a5c427f8907b026e9f70f83", "new_mode": 33188, "new_path": "tools/gn/builder_record.cc" }, { "type": "modify", "old_id": "dc96f7f56d420cc366c622740ce5303fd9ca01ca", "old_mode": 33188, "old_path": "tools/gn/builder_record.h", "new_id": "9dcc3664f63e4d6d214415705713899c419944f8", "new_mode": 33188, "new_path": "tools/gn/builder_record.h" }, { "type": "modify", "old_id": "3af92d2517f067c990a0abf7b7b930d4481d1670", "old_mode": 33188, "old_path": "tools/gn/bundle_data.cc", "new_id": "4251c8fd641887d9ebf21be414f743d9570c76e5", "new_mode": 33188, "new_path": "tools/gn/bundle_data.cc" }, { "type": "modify", "old_id": "2b9881c56067849a1a47c3c955c38eca3d2f8aea", "old_mode": 33188, "old_path": "tools/gn/bundle_file_rule.cc", "new_id": "2b81cdfb008e067fc18b9fb441ee80cf06a7fe1c", "new_mode": 33188, "new_path": "tools/gn/bundle_file_rule.cc" }, { "type": "modify", "old_id": "0c5476daaf741ad2e8b64199ee1ac01a04998fb8", "old_mode": 33188, "old_path": "tools/gn/c_include_iterator.cc", "new_id": "540d11892173f6185c1607113622ad7e9c61c186", "new_mode": 33188, "new_path": "tools/gn/c_include_iterator.cc" }, { "type": "modify", "old_id": "e81a60c9383ffa70f3c2d75835dfa9add2c5b8cb", "old_mode": 33188, "old_path": "tools/gn/c_include_iterator.h", "new_id": "86a0954a43cf1c1c98a42750dc1c17f7d0afc1c6", "new_mode": 33188, "new_path": "tools/gn/c_include_iterator.h" }, { "type": "modify", "old_id": "b7cd87131d8f9e46ccb92062226e1ecaec1dfc3d", "old_mode": 33188, "old_path": "tools/gn/commands.cc", "new_id": "cf387258dd791d2ba7affe9be5717011b04e078d", "new_mode": 33188, "new_path": "tools/gn/commands.cc" }, { "type": "modify", "old_id": "e021fe40b9dbeb1f77c9c9e82cfd052b0e5f0240", "old_mode": 33188, "old_path": "tools/gn/config.cc", "new_id": "e28fd30ed6812fe9cddf5e5ef4ce5d907c431185", "new_mode": 33188, "new_path": "tools/gn/config.cc" }, { "type": "modify", "old_id": "ad049737330a29fa18144b8ad34de551325243e7", "old_mode": 33188, "old_path": "tools/gn/config.h", "new_id": "040d54efd7dabe3680ccbc1760128e60d9077ec1", "new_mode": 33188, "new_path": "tools/gn/config.h" }, { "type": "modify", "old_id": "5bb42296b1e84b4cf017e2be2c70382ab3613031", "old_mode": 33188, "old_path": "tools/gn/config_values_extractors.h", "new_id": "cbcbed5d728d1c614975443b69a7f96e324a49b1", "new_mode": 33188, "new_path": "tools/gn/config_values_extractors.h" }, { "type": "modify", "old_id": "3556b5d86c83413cff43e22ce1b25fe01fbf4672", "old_mode": 33188, "old_path": "tools/gn/create_bundle_target_generator.cc", "new_id": "a54d17104aa2edfcbf9cf7447c79e830d4dd0e57", "new_mode": 33188, "new_path": "tools/gn/create_bundle_target_generator.cc" }, { "type": "modify", "old_id": "888d1b337b8acc2f8c27f226e1dd225840a63f49", "old_mode": 33188, "old_path": "tools/gn/escape.h", "new_id": "af5f8b8febb460bebb66ef469d0ecc8e5c905084", "new_mode": 33188, "new_path": "tools/gn/escape.h" }, { "type": "modify", "old_id": "2fc4b24af7db2d7fc7700f16822f01d9074c63d1", "old_mode": 33188, "old_path": "tools/gn/filesystem_utils.cc", "new_id": "cc121b3455aa9f51bb49d32f10f339df20a7e2b4", "new_mode": 33188, "new_path": "tools/gn/filesystem_utils.cc" }, { "type": "modify", "old_id": "1854d5bfb3b400d33cb7e79ab6be59518d24d117", "old_mode": 33188, "old_path": "tools/gn/generated_file_target_generator.cc", "new_id": "29712216cf522f5b7aea122bb621548f16855e1e", "new_mode": 33188, "new_path": "tools/gn/generated_file_target_generator.cc" }, { "type": "modify", "old_id": "fb2523d4b07fe49b7ca83bd5cfd9900e5c3544a4", "old_mode": 33188, "old_path": "tools/gn/generated_file_target_generator.h", "new_id": "206555f9f8d1e4b59809c6db6537dae0fd0c0a84", "new_mode": 33188, "new_path": "tools/gn/generated_file_target_generator.h" }, { "type": "modify", "old_id": "438ab388d3426470038064470c0b4e41e3bfc723", "old_mode": 33188, "old_path": "tools/gn/input_file.cc", "new_id": "dc5ca37fe404faa93d86b593d9cb4461bceb1248", "new_mode": 33188, "new_path": "tools/gn/input_file.cc" }, { "type": "modify", "old_id": "49e5f855741b028fa304f2baf93866b2008ab7d2", "old_mode": 33188, "old_path": "tools/gn/input_file.h", "new_id": "7a64c658065c68afdf6184e2a9f48c7534a0ef63", "new_mode": 33188, "new_path": "tools/gn/input_file.h" }, { "type": "modify", "old_id": "2290dc7044712cbfe155affcc259c88a9aa3f116", "old_mode": 33188, "old_path": "tools/gn/input_file_manager.cc", "new_id": "aad8cc822947a69f9b375d227c82295fc8e75f61", "new_mode": 33188, "new_path": "tools/gn/input_file_manager.cc" }, { "type": "modify", "old_id": "20874d1d9d2d92f26690dffcbe1bfde2aa7bdd8e", "old_mode": 33188, "old_path": "tools/gn/input_file_manager.h", "new_id": "c4f19e97ac290c691e50957f70648e9a488f0073", "new_mode": 33188, "new_path": "tools/gn/input_file_manager.h" }, { "type": "modify", "old_id": "e8494bee82eb7929ea463c59212be7b8d04c3306", "old_mode": 33188, "old_path": "tools/gn/label.cc", "new_id": "22b6f810a990ed5c551c6cc449a40a106450177b", "new_mode": 33188, "new_path": "tools/gn/label.cc" }, { "type": "modify", "old_id": "3c3d85a4802d42ba6e8c0297650c0576a4f73962", "old_mode": 33188, "old_path": "tools/gn/label.h", "new_id": "6606a6b5ad6426c7ecd0c09ab0a25f6de52caee0", "new_mode": 33188, "new_path": "tools/gn/label.h" }, { "type": "modify", "old_id": "9c55aaa8747bac0c4fb8437f6dd8bce18aec8afe", "old_mode": 33188, "old_path": "tools/gn/lib_file.cc", "new_id": "81e54fbf9a698e2c990539bfe5199478ce1fb27a", "new_mode": 33188, "new_path": "tools/gn/lib_file.cc" }, { "type": "modify", "old_id": "f1f073ffc71f8b5e3d533e1fdd671faf1d1694eb", "old_mode": 33188, "old_path": "tools/gn/lib_file.h", "new_id": "58621ebedf20da6e249913af8b6f23e84b34bb21", "new_mode": 33188, "new_path": "tools/gn/lib_file.h" }, { "type": "modify", "old_id": "a069fb83d2bf93f87156577b5a1fdbed85f3f975", "old_mode": 33188, "old_path": "tools/gn/loader.cc", "new_id": "b0f81bc02b7561ad14d9610a037b552e85475962", "new_mode": 33188, "new_path": "tools/gn/loader.cc" }, { "type": "modify", "old_id": "b9e4c221f0df8769fb8aea083ef15467701bebbf", "old_mode": 33188, "old_path": "tools/gn/location.cc", "new_id": "2e7b27b3d2e4bfd8518028fde53ef5aeb403c83d", "new_mode": 33188, "new_path": "tools/gn/location.cc" }, { "type": "modify", "old_id": "de9b2fdbe6b5e00833185a96e71bfc2293b0ff74", "old_mode": 33188, "old_path": "tools/gn/location.h", "new_id": "471391b374a920fa9a2627e2f425bbb2281a71d7", "new_mode": 33188, "new_path": "tools/gn/location.h" }, { "type": "modify", "old_id": "3c16d278181619d6d7ebe4409c0d1ca1ab17df08", "old_mode": 33188, "old_path": "tools/gn/metadata.h", "new_id": "06bd4956c62669a2613c5d8957bac11a01924443", "new_mode": 33188, "new_path": "tools/gn/metadata.h" }, { "type": "modify", "old_id": "32ae58e06e9f637fefa65a7fd062fc5982a62483", "old_mode": 33188, "old_path": "tools/gn/ninja_create_bundle_target_writer.cc", "new_id": "dab4485cbf5ff2c9f3bac141bc11a6294930f691", "new_mode": 33188, "new_path": "tools/gn/ninja_create_bundle_target_writer.cc" }, { "type": "modify", "old_id": "5081112884bd7a4a4e95c80dd1e26a4adf305dd5", "old_mode": 33188, "old_path": "tools/gn/ordered_set.h", "new_id": "fda4e121f5c43c32efc5838ad12987d78e87db1c", "new_mode": 33188, "new_path": "tools/gn/ordered_set.h" }, { "type": "modify", "old_id": "f92e0976b439710023f8640c2b109dbec002a25c", "old_mode": 33188, "old_path": "tools/gn/output_file.cc", "new_id": "e0c82fc23ecf712b9100bc93081441b38bb7aef8", "new_mode": 33188, "new_path": "tools/gn/output_file.cc" }, { "type": "modify", "old_id": "a3a64e0d5d6a016c080701ac0e5aa734e43745cf", "old_mode": 33188, "old_path": "tools/gn/output_file.h", "new_id": "cd3ee33f79871cd229f5212b89a24968509926f8", "new_mode": 33188, "new_path": "tools/gn/output_file.h" }, { "type": "modify", "old_id": "3e4eee98114f4c0f076473c7f638f87f032997da", "old_mode": 33188, "old_path": "tools/gn/scheduler.cc", "new_id": "f4960b9bf638aba1a7178438195aa03230e30dbe", "new_mode": 33188, "new_path": "tools/gn/scheduler.cc" }, { "type": "modify", "old_id": "0e2203c3b6ef9b1774207aacfe9408a63e4d5a8c", "old_mode": 33188, "old_path": "tools/gn/scheduler.h", "new_id": "d005df559c821a80074b935dc0dd2655047a44e7", "new_mode": 33188, "new_path": "tools/gn/scheduler.h" }, { "type": "modify", "old_id": "585f1513a87123985fc7fc7b1658f552f0f4542f", "old_mode": 33188, "old_path": "tools/gn/scope.h", "new_id": "6c26cdbece2301ce892a1b5354f11d1cbcafab6a", "new_mode": 33188, "new_path": "tools/gn/scope.h" }, { "type": "modify", "old_id": "737e72a57d5687bff4089a047630a552b82f43a6", "old_mode": 33188, "old_path": "tools/gn/settings.cc", "new_id": "c630fa72e0e47cfcc3c78ef46bfc253a5f76dbd1", "new_mode": 33188, "new_path": "tools/gn/settings.cc" }, { "type": "modify", "old_id": "f0a6691548942c0f3d0c608660653f0a7da60293", "old_mode": 33188, "old_path": "tools/gn/settings.h", "new_id": "eb9952f68f6dbe764e798fab57a1461245ca73ef", "new_mode": 33188, "new_path": "tools/gn/settings.h" }, { "type": "modify", "old_id": "e461e26bafc0bfe2af924f1e32d757d1757bbb0e", "old_mode": 33188, "old_path": "tools/gn/setup.cc", "new_id": "f3db3621b693599e83e9ba2cbc3859f0c3f45b5a", "new_mode": 33188, "new_path": "tools/gn/setup.cc" }, { "type": "modify", "old_id": "cf0136a21c7108b75da4bda6c7653bbae9a8528e", "old_mode": 33188, "old_path": "tools/gn/setup.h", "new_id": "9aef0735ce12ccb49fcfe62b87f63d5513504871", "new_mode": 33188, "new_path": "tools/gn/setup.h" }, { "type": "modify", "old_id": "50b45175634687bcd48919fd28feae7b1fa47c9e", "old_mode": 33188, "old_path": "tools/gn/source_dir.cc", "new_id": "7def4b2ba0c752ec7c433a73a52807c65534de4f", "new_mode": 33188, "new_path": "tools/gn/source_dir.cc" }, { "type": "modify", "old_id": "bfc260d514fd48e9a4bcf4af60ddcb9f4c0a47b7", "old_mode": 33188, "old_path": "tools/gn/source_dir.h", "new_id": "8b6dcc9e454c848f21dbf1921fc82b50bc3c97fc", "new_mode": 33188, "new_path": "tools/gn/source_dir.h" }, { "type": "modify", "old_id": "f925546f0df10f299631633dac43b681c9665d0d", "old_mode": 33188, "old_path": "tools/gn/source_file.cc", "new_id": "ce24207e63ef7af8be2c6ed86b898a9a988824bf", "new_mode": 33188, "new_path": "tools/gn/source_file.cc" }, { "type": "modify", "old_id": "ed814c8104b236f1953bd739e6af24f854342f57", "old_mode": 33188, "old_path": "tools/gn/source_file.h", "new_id": "081cda61db6b600607b08c147e8005839c91647a", "new_mode": 33188, "new_path": "tools/gn/source_file.h" }, { "type": "modify", "old_id": "110707adea359ed7a8a43e1c8934f352abd43f1b", "old_mode": 33188, "old_path": "tools/gn/source_file_unittest.cc", "new_id": "d26b35934fb892e5abbdccbad3673b9253240c29", "new_mode": 33188, "new_path": "tools/gn/source_file_unittest.cc" }, { "type": "modify", "old_id": "8ca261e4fb61eb33df5d0a098f2648969c77c5e4", "old_mode": 33188, "old_path": "tools/gn/substitution_writer.cc", "new_id": "8ce11055f06eb6ac2eaa2b06a63f704d8c3c9905", "new_mode": 33188, "new_path": "tools/gn/substitution_writer.cc" }, { "type": "modify", "old_id": "60de12040d65ce23e229b17d3085b0a735cc10b2", "old_mode": 33188, "old_path": "tools/gn/target.cc", "new_id": "7c9cd6d23b4cff30ec35841099e343e5657b4f5d", "new_mode": 33188, "new_path": "tools/gn/target.cc" }, { "type": "modify", "old_id": "60014d77b7d0fe8ee3680c626250825b19bddcf9", "old_mode": 33188, "old_path": "tools/gn/target.h", "new_id": "549b3545eb17d3bb2229041709cb8c488cda287e", "new_mode": 33188, "new_path": "tools/gn/target.h" }, { "type": "modify", "old_id": "cfcc4e39550b1b015bb3084ec4453c467c2ad228", "old_mode": 33188, "old_path": "tools/gn/target_generator.cc", "new_id": "09de19dec781ba123b18effc0fb9f6abc05035eb", "new_mode": 33188, "new_path": "tools/gn/target_generator.cc" }, { "type": "modify", "old_id": "9625203dcd4ee4128370b155af70b84b5909a247", "old_mode": 33188, "old_path": "tools/gn/tokenizer.cc", "new_id": "09f0b4b7d14d2b5b846387303707dea52db5395c", "new_mode": 33188, "new_path": "tools/gn/tokenizer.cc" }, { "type": "modify", "old_id": "67590df55ef9314c2a0e4f892bb90b107af6e71e", "old_mode": 33188, "old_path": "tools/gn/tokenizer.h", "new_id": "7b66ac0dab47887607df352ad6c11eb50fdbd039", "new_mode": 33188, "new_path": "tools/gn/tokenizer.h" }, { "type": "modify", "old_id": "8e06d11b7e681b1228490819a5a39b1804f2e0fa", "old_mode": 33188, "old_path": "tools/gn/tool.cc", "new_id": "d67933ee39e7a42d5da484fcf0636adfac074ce2", "new_mode": 33188, "new_path": "tools/gn/tool.cc" }, { "type": "modify", "old_id": "2f853ef9ca353146dff69a82116154214241c830", "old_mode": 33188, "old_path": "tools/gn/tool.h", "new_id": "b963ebf69cd646daa61061fbee499ef9a3f02e50", "new_mode": 33188, "new_path": "tools/gn/tool.h" }, { "type": "modify", "old_id": "732b66344d6bb1b2aba31dc457059e9c43369622", "old_mode": 33188, "old_path": "tools/gn/unique_vector.h", "new_id": "ec8bb275b41633e6a9ba5c2e18c9a22de46db1a5", "new_mode": 33188, "new_path": "tools/gn/unique_vector.h" }, { "type": "modify", "old_id": "afea1e24a00f073c6b1a7a1de86340ace1372489", "old_mode": 33188, "old_path": "tools/gn/unique_vector_unittest.cc", "new_id": "008d28466327f652e75eeecc7316d4bfd8381fcf", "new_mode": 33188, "new_path": "tools/gn/unique_vector_unittest.cc" }, { "type": "modify", "old_id": "9dbd4b35ffc7b56bbe2f8c1fb0b8a9c9f85d114f", "old_mode": 33188, "old_path": "tools/gn/visual_studio_writer.cc", "new_id": "5f4380cdab5e45451bc6ddb5b1db9116172049b6", "new_mode": 33188, "new_path": "tools/gn/visual_studio_writer.cc" } ] }