tree 91a6e727af27ce5a56c7f645d1c04c86b3b8fab6
parent 0e7d98e041b01eb5fed29a9a80482ed8ca9efe5b
author Takuto Ikuta <tikuta@google.com> 1790911235 +0900
committer gn-scoped@luci-project-accounts.iam.gserviceaccount.com <gn-scoped@luci-project-accounts.iam.gserviceaccount.com> 1790922770 -0700

Stop forwarding private hard_deps on check_includes_strict targets

Previously, ResolvedTargetData::ComputeHardDeps() and
NinjaTargetWriter::WriteHardDepsStampOrPhony() forwarded hard_deps from
both public_deps and private deps of a target T (unless T was a binary
target with public = []), because standard 'gn check' allows T's
public headers to #include headers from T's private deps.

However, when T sets check_includes_strict = true, 'gn check' enforces
that T's public headers cannot #include headers from T's private deps.
Therefore, targets depending on T cannot transitively reach generated
headers from T's private dependencies.

This change restricts ComputeHardDeps() and WriteHardDepsStampOrPhony()
to only traverse public_deps when check_includes_strict = true (for
non-hard targets), while still including hard_deps of private_deps in
T's own input dependencies in WriteInputDepsStampOrPhonyAndGetDep().

Suggested in:
https://chromium-review.googlesource.com/c/chromium/src/+/8497030/comment/9c2d1aca_83609b40/

Bug: 563098656
Change-Id: If9d5ef1e18475f0bcae1a65553256ff84543d871
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/27100
Reviewed-by: Matt Stark <msta@google.com>
Reviewed-by: David Turner <digit@google.com>
Commit-Queue: Takuto Ikuta <tikuta@google.com>