commit a1405464c9a7f9ee68ede6085894fa7313900c11
author Dirk Pranke <dpranke@chromium.org> Thu Jun 08 18:47:33 2017 -0700
committer Commit Bot <commit-bot@chromium.org> Fri Jun 09 20:08:39 2017 +0000
tree f93f8858f5efbcf17936933723e9354583463588
parent dd00131f375c9d557d262e2f1cdeb9b122b91d28

Fix a bug in `gn analyze` for host-only file mods.

If you modified a file that only affected targets defined in a
non-default toolchain (e.g., like the host toolchain), `gn analyze`
would skip over it and hence not do the right thing. For example,
if you modified //testing/iossim/iossim.mm, analyze would think
that no compile was needed, when really you'd want to recompile
the simulator and re-run every test.

Unfortunately, I don't remember why I wrote the code the way I did,
but looking at it now I can't think of a reason not to just look in
every toolchain.

BUG=667989

Change-Id: I8e1935d7dc23bf49fa87e191c1a136a5492d3678
Reviewed-on: https://chromium-review.googlesource.com/528527
Reviewed-by: smut <smut@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#478388}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 21886543a0cbedeb869fb68944e13ef613cedceb

tools/gn/analyzer.cc

diff --git a/tools/gn/analyzer.cc b/tools/gn/analyzer.cc
index d1f2d52..aa0eca4 100644
--- a/tools/gn/analyzer.cc
+++ b/tools/gn/analyzer.cc
@@ -395,9 +395,7 @@
 void Analyzer::AddTargetsDirectlyReferringToFileTo(const SourceFile* file,
                                                    TargetSet* matches) const {
   for (auto* target : all_targets_) {
-    // Only handles targets in the default toolchain.
-    if ((target->label().GetToolchainLabel() == default_toolchain_) &&
-        TargetRefersToFile(target, file))
+    if (TargetRefersToFile(target, file))
       matches->insert(target);
   }
 }