tree da55a98b1ae16c954bd8c3f07c91859bd0f6f1bc
parent eb1f75e4232cac32454482b1c4460c468c4828d9
author Jim Ray <jimray@google.com> 1647897470 -0700
committer Commit Bot <commit-bot@chromium.org> 1648680660 +0000

Fix error when script_executable is not in PATH

This change fixes an unclear error message that can arise on Windows
when the exe pointed to by script_executable in the .gn dotfile
doesn't exist in the user's PATH.

If this occurs, the following error is printed:
"""
ERROR at //starboard/build/config/BUILDCONFIG.gn:15:15: Could not execute interpreter.

<exec_script that was attempted>

I was trying to execute "".
"""

This occurs because the function that searches for the
script_executable in the PATH on a Windows machine returns an empty
base::FilePath if the exe isn't found. As such, check if this happens
and return an Err that reports the problem.

Change-Id: I963b01619f68cef2a951fafc4c66f274176e66e0
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/13260
Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>