tree 9300620061cb83d76f27d246d6deb62f336a8573
parent 7498ca2e5e24b509ce679604ff46768f12098d48
author Neri Marschik <nerima@google.com> 1770175842 +0900
committer GN LUCI <gn-scoped@luci-project-accounts.iam.gserviceaccount.com> 1770279721 -0800

Fix target being written twice under certain circumstances

The Fuchsia build triggered a situation where a target was written twice
when it changed from ShouldGenerate false to true.

A target can start out with `ShouldGenerate = false` if it is not using
the default toolchain or there are root patterns that don't match.
`RecursiveSetShouldGenerate` triggers writes for this target if another
target is discovered that has `ShouldGenerate = true` and depends on it.

The logic in `RecursiveShouldGenerateWithValidations` did not include
the new `CanWrite` check introduced with validations.

This CL colocates the logic into CheckAndTriggerWrite so the logic lives
in one place.

Bug: 478798763
Change-Id: I82413b8292f05fe38a7454446f01a42e7165f7ed
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/20980
Reviewed-by: Takuto Ikuta <tikuta@google.com>
Commit-Queue: Neri Marschik <nerima@google.com>