commit af4d58fbb8050bba3a8cbc887b86c9c165290157
author tmoniuszko <tmoniuszko@opera.com> Thu Mar 24 01:53:59 2016 -0700
committer Commit bot <commit-bot@chromium.org> Thu Mar 24 08:55:10 2016 +0000
tree 726f4f69104a074ffff07a6c6d746dc306e67594
parent 0536dc508f9c242eed3958ed63639630e6918ba9

Convert GN group targets to Visual Studio projects

BUG=596895

Review URL: https://codereview.chromium.org/1819353002

Cr-Original-Commit-Position: refs/heads/master@{#383042}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 130612c0259b1200a8edf41973b058d5164470ef

tools/gn/visual_studio_writer.cc

diff --git a/tools/gn/visual_studio_writer.cc b/tools/gn/visual_studio_writer.cc
index 801ea77..4c88f35 100644
--- a/tools/gn/visual_studio_writer.cc
+++ b/tools/gn/visual_studio_writer.cc
@@ -125,6 +125,8 @@
     case Target::STATIC_LIBRARY:
     case Target::SOURCE_SET:
       return "StaticLibrary";
+    case Target::GROUP:
+      return "Utility";
 
     default:
       *err = Err(Location(),
@@ -259,9 +261,8 @@
   writer.folders_.reserve(targets.size());
 
   for (const Target* target : targets) {
-    // Skip actions, groups and bundle targets.
-    if (target->output_type() == Target::GROUP ||
-        target->output_type() == Target::COPY_FILES ||
+    // Skip actions and bundle targets.
+    if (target->output_type() == Target::COPY_FILES ||
         target->output_type() == Target::ACTION ||
         target->output_type() == Target::ACTION_FOREACH ||
         target->output_type() == Target::BUNDLE_DATA) {
@@ -424,11 +425,13 @@
       scoped_ptr<XmlElementWriter> out_dir = properties->SubElement("OutDir");
       path_output.WriteDir(out_dir->StartContent(false),
                            build_settings_->build_dir(),
-                           PathOutput::DIR_INCLUDE_LAST_SLASH);
+                           PathOutput::DIR_NO_LAST_SLASH);
     }
     properties->SubElement("TargetName")->Text("$(ProjectName)");
-    properties->SubElement("TargetPath")
-        ->Text("$(OutDir)\\$(ProjectName)$(TargetExt)");
+    if (target->output_type() != Target::GROUP) {
+      properties->SubElement("TargetPath")
+          ->Text("$(OutDir)\\$(ProjectName)$(TargetExt)");
+    }
   }
 
   {