)]}'
{
  "commit": "b3c06004cdf09089f2ad2b592ff141e6d17b6e4e",
  "tree": "b18e4e594a78e05942a609aa72973653b6f7ceba",
  "parents": [
    "34c73aa90da80675de15eb8a3103a6df4949cf77"
  ],
  "author": {
    "name": "Takuto Ikuta",
    "email": "tikuta@chromium.org",
    "time": "Tue May 22 09:23:29 2018 +0000"
  },
  "committer": {
    "name": "Commit Bot",
    "email": "commit-bot@chromium.org",
    "time": "Tue May 22 09:23:29 2018 +0000"
  },
  "message": "Reland \"GN: do not make indirect dependency to direct dependency\"\n\nThis is a reland of e8a3ce9119189ad6ba5ecaa62bb0b53b07c895f4\n\nFix for breakage crbug.com/843351 is below.\nhttps://chromium-review.googlesource.com/c/chromium/src/+/1065591\n\n\nOriginal change\u0027s description:\n\u003e GN: do not make indirect dependency to direct dependency\n\u003e\n\u003e If a target is hard dep, there is no need to have the action targets\u0027s\n\u003e recursive deps as direct dependency, because such dependency is\n\u003e transitive.\n\u003e\n\u003e This is found by pcc in gn-dev\n\u003e https://groups.google.com/a/chromium.org/forum/#!topic/gn-dev/BcrSfPQE84E\n\u003e\n\u003e With this change, generated android\u0027s toolchain.ninja size is reduced\n\u003e from 262MB to 31MB. And ninja\u0027s startup time reduced from 4.9~5.1s to\n\u003e 2.6s.\n\u003e I used args.gn same with android_n5x_swarming_rel bot.\n\u003e\n\u003e Also this patch reduced the time of `gn gen` from 9.5~10.3s to 6.8~7.2s\n\u003e on my machine.\n\u003e\n\u003e Change-Id: I0f0214d3abe74143516b263da839e98b3987fb64\n\u003e Reviewed-on: https://chromium-review.googlesource.com/1041506\n\u003e Reviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n\u003e Reviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\n\u003e Commit-Queue: Takuto Ikuta \u003ctikuta@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/master@{#557365}\n\nBug: 843470\nChange-Id: I4d3662613b21a1e520517d152865529aa05e813f\nReviewed-on: https://chromium-review.googlesource.com/1065690\nCommit-Queue: Takuto Ikuta \u003ctikuta@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#560520}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 3ae94eab7c33428af8e5dcccf85a90975368fa54",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "1b2ddc807b590cb01aeb05d46009ac7f28784a8a",
      "old_mode": 33188,
      "old_path": "tools/gn/ninja_action_target_writer_unittest.cc",
      "new_id": "445a31a33379ce828e41f67d832d2b1459e0989d",
      "new_mode": 33188,
      "new_path": "tools/gn/ninja_action_target_writer_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "ff6feaf9230a4843e6ddf99d655674fdb896ce0c",
      "old_mode": 33188,
      "old_path": "tools/gn/ninja_create_bundle_target_writer_unittest.cc",
      "new_id": "c745939c1960de2ac9a4408096531e33be14fa14",
      "new_mode": 33188,
      "new_path": "tools/gn/ninja_create_bundle_target_writer_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "68a59c81941172f54854c14ed27823664c322236",
      "old_mode": 33188,
      "old_path": "tools/gn/ninja_target_writer_unittest.cc",
      "new_id": "38dd8de56a3192281092014cd6588ba6a6db339b",
      "new_mode": 33188,
      "new_path": "tools/gn/ninja_target_writer_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "15df27f52bcaedb4254a74f8033f18d44fbf9f5a",
      "old_mode": 33188,
      "old_path": "tools/gn/target.cc",
      "new_id": "d0714a8cbbc50e5d1a2bc4fd0ba6025cfc2d9d8a",
      "new_mode": 33188,
      "new_path": "tools/gn/target.cc"
    },
    {
      "type": "modify",
      "old_id": "568bea54d57f0a68ac63c13f122b784866e03d81",
      "old_mode": 33188,
      "old_path": "tools/gn/target.h",
      "new_id": "ed8abd5145c9d202e394197216718b19b7ba6d72",
      "new_mode": 33188,
      "new_path": "tools/gn/target.h"
    }
  ]
}