)]}'
{
  "commit": "b79031308cc878488202beb99883ec1f2efd9a6d",
  "tree": "3890e502540d3171ef1e277de3cd2d2327db9679",
  "parents": [
    "de679ebabebe2e448dd4e9f288cad29cfe7b1a4b"
  ],
  "author": {
    "name": "David \u0027Digit\u0027 Turner",
    "email": "digit@google.com",
    "time": "Wed Nov 24 19:12:30 2021 +0100"
  },
  "committer": {
    "name": "Commit Bot",
    "email": "commit-bot@chromium.org",
    "time": "Wed Nov 24 20:46:36 2021 +0000"
  },
  "message": "Fix metadata collection bug.\n\nA recent CL [1] introduced a subtle bug in metadata collection,\nwhich is only triggered when collecting through a target that\ndoesn\u0027t have its own metadata (but whose dependencies do).\n\nThis CL fixes the issue, and adds a new unit-test to detect\na similar issue in the future.\n\nThe issue was that the `has_metadata()` check should not have\nbeen introduced, because when this condition is false, it\nprevented a call to WalkStep() which actually modifies\n`next_walk_keys`. The effect was that metadata walk was cut\ntoo soon.\n\n[1] https://gn-review.googlesource.com/c/gn/+/12401\n\nBug: chromium/1273069\n\nChange-Id: Iae1eee1e30b6130e93294204d282474233014525\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/12560\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "62f17cd5822c60d7c3b04d7ad3b4feabb223e6af",
      "old_mode": 33188,
      "old_path": "src/gn/target.cc",
      "new_id": "0d225b68931ca7cd59826e1e5db727d2c90b1b60",
      "new_mode": 33188,
      "new_path": "src/gn/target.cc"
    },
    {
      "type": "modify",
      "old_id": "add6d8231cb99689a0252902cc99d5faa2c981b0",
      "old_mode": 33188,
      "old_path": "src/gn/target_unittest.cc",
      "new_id": "0dcff0c9d8cd1610b9cb0f4beb7683326df85139",
      "new_mode": 33188,
      "new_path": "src/gn/target_unittest.cc"
    }
  ]
}