tree 3890e502540d3171ef1e277de3cd2d2327db9679
parent de679ebabebe2e448dd4e9f288cad29cfe7b1a4b
author David 'Digit' Turner <digit@google.com> 1637777550 +0100
committer Commit Bot <commit-bot@chromium.org> 1637786796 +0000

Fix metadata collection bug.

A recent CL [1] introduced a subtle bug in metadata collection,
which is only triggered when collecting through a target that
doesn't have its own metadata (but whose dependencies do).

This CL fixes the issue, and adds a new unit-test to detect
a similar issue in the future.

The issue was that the `has_metadata()` check should not have
been introduced, because when this condition is false, it
prevented a call to WalkStep() which actually modifies
`next_walk_keys`. The effect was that metadata walk was cut
too soon.

[1] https://gn-review.googlesource.com/c/gn/+/12401

Bug: chromium/1273069

Change-Id: Iae1eee1e30b6130e93294204d282474233014525
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/12560
Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: David Turner <digit@google.com>