| commit | b7d9342efabc67bd37cc3cae311ebe2b64f48f18 | [log] [tgz] |
|---|---|---|
| author | dpranke <dpranke@chromium.org> | Mon Jul 27 16:10:31 2015 -0700 |
| committer | Commit bot <commit-bot@chromium.org> | Mon Jul 27 23:11:14 2015 +0000 |
| tree | baf4f02e23d8428091bbc35c8bf2c567bd3ca4cc | |
| parent | d72fe3a9f5c56892a9b9af8c99edc10b66eaf838 [diff] |
Revert of Add output reference to gen written files. (patchset #3 id:40001 of https://codereview.chromium.org/1220223002/) Reason for revert: Looks like this doesn't quite work on Windows: http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/21206/steps/compile%20%28with%20patch%29/logs/stdio Original issue's description: > Add output reference to gen written files. > > By adding the outputs written at gn gen time to the build.ninja representation the build tool (ninja) can know how to recreate them if and when necessary. > > For example, if one or more of the <blah>.tmp files is removed, even as part of an entire hierarchy/subtree currently the build fails because ninja does not know how to re-make it. > > BUG=469621 > TEST=Build time only. See https://code.google.com/p/chromium/issues/detail?id=469621#c3 > > Committed: https://crrev.com/517ac52f86903beb206b19e6ddeedbc709b253a1 > Cr-Commit-Position: refs/heads/master@{#338929} TBR=brettw@chromium.org,petermayo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=469621 Review URL: https://codereview.chromium.org/1255113004 Cr-Original-Commit-Position: refs/heads/master@{#340596} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 61fb6826c8e7b9a31c260cb3698258e4fad5b33b