| commit | b85963d5e1086e0192485f7dd1fe8d5f65fb7294 | [log] [tgz] |
|---|---|---|
| author | Julie Hockett <juliehockett@google.com> | Tue Oct 02 13:41:55 2018 -0700 |
| committer | Commit Bot <commit-bot@chromium.org> | Wed Oct 03 00:03:20 2018 +0000 |
| tree | d37d3ff09b6f10019bd930602dc33f721cf05d2d | |
| parent | 091169beda92aff21ded3e9dfb392ea12b10c0e0 [diff] |
[functions][not_needed] Copy scope so it isn't overridden An edge case found an ASAN use-after-free error where a scope value was getting overridden by the evaluated result. This copies the scope in the case where it would have been overridden. Bug: crbug.com/gn/12 Change-Id: I08322fc73e6e459fbe4c5f35e7f5154ded74746c Reviewed-on: https://gn-review.googlesource.com/c/2920 Reviewed-by: Scott Graham <scottmg@google.com> Commit-Queue: Julie Hockett <juliehockett@google.com>
GN is a meta-build system that generates build files for Ninja. There is documentation in docs/.
git clone https://gn.googlesource.com/gn cd gn python build/gen.py ninja -C out # To run tests: out/gn_unittests
On Windows, it is expected that cl.exe, link.exe, and lib.exe can be found in PATH, so you'll want to run from a Visual Studio command prompt, or similar.
On Linux and Mac, the default compiler is clang++, a recent version is expected to be found in PATH. This can be overridden by setting CC, CXX, and AR.
GN uses Gerrit for code review. The short version of how to patch is:
Register at https://gn-review.googlesource.com. ... edit code ... ninja -C out && out/gn_unittests
Then, to upload a change for review:
git commit git cl upload --gerrit
When revising a change, use:
git commit --amend git cl upload --gerrit
which will add the new changes to the existing code review, rather than creating a new one.
We ask that all contributors sign Google's Contributor License Agreement (either individual or corporate as appropriate, select ‘any other Google project’).
You may ask questions and follow along w/ GN‘s development on Chromium’s gn-dev@ Google Group.