gn /
gn /
f0bd81496e6b44733dad6658697403bdd18d5578 Validate GN substitutions in args and rsp files.
Previously GN did not validate the substitution types used in the args or
response_file_contents for action_foreach targets. If a caller used an
incorrect one (as was happening in the nocompile test template), GN would
assert in debug mode and skip the substitution in release mode.
This didn't seem to cause a problem for the nocompile test because the output
file is not used.
This adds the necessary validation for these types so GN will give a proper
error message on misuse, and adds some additional unit tests for other aspects
of action_foreach parameter validation.
Review-Url: https://codereview.chromium.org/2627703002
Cr-Original-Commit-Position: refs/heads/master@{#444507}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bb57bea1642b294af0578ab0e50d1c63bb5491b2
6 files changed
tree: 82f279c107e23a49ba2aa7c4487c5336d0c981d5
- tools/
