tree 1e95b1b7101a6955c6eee794af2b4be6d626e518
parent 868533076321adfebe4a73668847f659a8a9fab2
author msta <msta@google.com> 1783564765 +1000
committer gn-scoped@luci-project-accounts.iam.gserviceaccount.com <gn-scoped@luci-project-accounts.iam.gserviceaccount.com> 1783943340 -0700

Refactor filesystem utils to clean up the code and avoid OutputFile mutation

The purpose of this is to allow OutputFile to store a StringAtom, which
requires it to be immutable. Doing so would allow us to cheaply copy
OutputFile objects.

* Rename Get*AsSourceDir to overloaded GetSourceDir.
* Split GetBuildDirAsOutputFile, GetSubBuildDirAsOutputFile, and GetBuildDirForTargetAsOutputFile into:
  * GetBuildDir overloads returning std::string.
  * GetOutputFile overloads that create an outputfile by joining arguments together, avoiding mutation of created OutputFiles
* Convert Target and Scope parameters in GetSourceDir/GetBuildDir/GetOutputFile from pointers to references to ensure null-safety.
* Update all call sites across target writers and helper functions to use the new reference-based and overloaded APIs.

Bug: 491925153
Change-Id: I36e7f46e0f0bbef961d9ea444832ee866a6a6964
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/23922
Reviewed-by: Takuto Ikuta <tikuta@google.com>
Commit-Queue: Matt Stark <msta@google.com>