commit c37fe98bcaac3044e603a689b56b9a396c85d3c6
author ngg <ngg@ngg.hu> Wed Feb 24 02:18:47 2016 -0800
committer Commit bot <commit-bot@chromium.org> Wed Feb 24 10:20:34 2016 +0000
tree 43604b75e4a9aa597078ddf4dd475514ab75241b
parent 261f7eb31926b07d028dea1daf686b72556dc34e

GN: fix a DCHECK() when generating Visual Studio solution files

VisualStudioWriter::WriteSolutionFileContents() used RebasePath()
with |source_root| = "/" which is forbidden. It always uses system
absolute paths, thus we can use |source_root| = "".

R=brettw@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1723613003

Cr-Original-Commit-Position: refs/heads/master@{#377258}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bbe9c04f0889293cea85b6806145e26e1670a223

tools/gn/visual_studio_writer.cc

diff --git a/tools/gn/visual_studio_writer.cc b/tools/gn/visual_studio_writer.cc
index 7748fbe..4b64f1e 100644
--- a/tools/gn/visual_studio_writer.cc
+++ b/tools/gn/visual_studio_writer.cc
@@ -606,14 +606,14 @@
   SourceDir solution_dir(FilePathToUTF8(solution_dir_path));
   for (const SolutionEntry* folder : folders_) {
     out << "Project(\"" << kGuidTypeFolder << "\") = \"(" << folder->name
-        << ")\", \"" << RebasePath(folder->path, solution_dir, "/") << "\", \""
+        << ")\", \"" << RebasePath(folder->path, solution_dir) << "\", \""
         << folder->guid << "\"" << std::endl;
     out << "EndProject" << std::endl;
   }
 
   for (const SolutionEntry* project : projects_) {
     out << "Project(\"" << kGuidTypeProject << "\") = \"" << project->name
-        << "\", \"" << RebasePath(project->path, solution_dir, "/") << "\", \""
+        << "\", \"" << RebasePath(project->path, solution_dir) << "\", \""
         << project->guid << "\"" << std::endl;
     out << "EndProject" << std::endl;
   }