Fix use of 'is' operator for comparison

The 'is' operator is not meant to be used for comparisons. It currently working is an implementation detail of CPython.
CPython 3.8 has added a SyntaxWarning for this.

Bug: chromium:958874
Change-Id: Iea43a1e48a8b6f1abd4ed1652f724f455c3d0f59
Commit-Queue: Petr Hosek <>
Reviewed-by: Petr Hosek <>
1 file changed
tree: ba3a48900b8da6ba46e24a1757d108429a901ac0
  1. base/
  2. build/
  3. docs/
  4. infra/
  5. tools/
  6. util/
  7. .clang-format
  8. .editorconfig
  9. .gitignore
  10. .style.yapf
  13. OWNERS


GN is a meta-build system that generates build files for Ninja. There is documentation in docs/ and a presentation on it.

Getting started

You can download the latest version of GN binary for Linux, macOS and Windows.

Alternatively, you can build GN from source:

git clone
cd gn
python build/
ninja -C out
# To run tests:

On Windows, it is expected that cl.exe, link.exe, and lib.exe can be found in PATH, so you'll want to run from a Visual Studio command prompt, or similar.

On Linux and Mac, the default compiler is clang++, a recent version is expected to be found in PATH. This can be overridden by setting CC, CXX, and AR.

Reporting bugs

If you find a bug, you can see if it is known or report it in the bug database.

Sending patches

GN uses Gerrit for code review. The short version of how to patch is:

Register at

... edit code ...
ninja -C out && out/gn_unittests

Then, to upload a change for review:

git commit
git cl upload --gerrit

When revising a change, use:

git commit --amend
git cl upload --gerrit

which will add the new changes to the existing code review, rather than creating a new one.

We ask that all contributors sign Google's Contributor License Agreement (either individual or corporate as appropriate, select ‘any other Google project’).


You may ask questions and follow along w/ GN‘s development on Chromium’s gn-dev@ Google Group.