|author||Raul Tambre <firstname.lastname@example.org>||Thu May 02 16:53:29 2019 +0300|
|committer||Commit Bot <email@example.com>||Fri May 03 00:22:52 2019 +0000|
Fix use of 'is' operator for comparison The 'is' operator is not meant to be used for comparisons. It currently working is an implementation detail of CPython. CPython 3.8 has added a SyntaxWarning for this. Bug: chromium:958874 Change-Id: Iea43a1e48a8b6f1abd4ed1652f724f455c3d0f59 Reviewed-on: https://gn-review.googlesource.com/c/gn/+/4780 Commit-Queue: Petr Hosek <firstname.lastname@example.org> Reviewed-by: Petr Hosek <email@example.com>
Alternatively, you can build GN from source:
git clone https://gn.googlesource.com/gn cd gn python build/gen.py ninja -C out # To run tests: out/gn_unittests
On Windows, it is expected that
lib.exe can be found in
PATH, so you'll want to run from a Visual Studio command prompt, or similar.
On Linux and Mac, the default compiler is
clang++, a recent version is expected to be found in
PATH. This can be overridden by setting
If you find a bug, you can see if it is known or report it in the bug database.
GN uses Gerrit for code review. The short version of how to patch is:
Register at https://gn-review.googlesource.com. ... edit code ... ninja -C out && out/gn_unittests
Then, to upload a change for review:
git commit git cl upload --gerrit
When revising a change, use:
git commit --amend git cl upload --gerrit
which will add the new changes to the existing code review, rather than creating a new one.
We ask that all contributors sign Google's Contributor License Agreement (either individual or corporate as appropriate, select ‘any other Google project’).
You may ask questions and follow along w/ GN‘s development on Chromium’s gn-dev@ Google Group.