commit | c6841d3124c89a4d75f04ce04ad819a615324aa8 | [log] [tgz] |
---|---|---|
author | Nico Weber <thakis@chromium.org> | Sat Jan 05 00:01:29 2019 -0500 |
committer | Commit Bot <commit-bot@chromium.org> | Sat Jan 05 05:31:40 2019 +0000 |
tree | 07a354068bfee3787413ebb2e853cfff17281e83 | |
parent | 54be6f11b8a4f9e4f491fcd84f3a5880c4623098 [diff] |
Fix a crash on invalid on `not_needed(scope)` without a 2nd argument. While here, also fix an accepts-invalid where GN would accept and silently ignore a third argument if the first argument was a string or a list. Bug: gn:38 Change-Id: I552585a9467284095ea583ee0fce01e4dad09c0c Reviewed-on: https://gn-review.googlesource.com/c/3600 Reviewed-by: Petr Hosek <phosek@google.com> Commit-Queue: Petr Hosek <phosek@google.com>
GN is a meta-build system that generates build files for Ninja. There is documentation in docs/ and a presentation on it.
You can download the latest version of GN binary for Linux, macOS and Windows.
Alternatively, you can build GN from source:
git clone https://gn.googlesource.com/gn cd gn python build/gen.py ninja -C out # To run tests: out/gn_unittests
On Windows, it is expected that cl.exe
, link.exe
, and lib.exe
can be found in PATH
, so you'll want to run from a Visual Studio command prompt, or similar.
On Linux and Mac, the default compiler is clang++
, a recent version is expected to be found in PATH
. This can be overridden by setting CC
, CXX
, and AR
.
If you find a bug, you can see if it is known or report it in the bug database.
GN uses Gerrit for code review. The short version of how to patch is:
Register at https://gn-review.googlesource.com. ... edit code ... ninja -C out && out/gn_unittests
Then, to upload a change for review:
git commit git cl upload --gerrit
When revising a change, use:
git commit --amend git cl upload --gerrit
which will add the new changes to the existing code review, rather than creating a new one.
We ask that all contributors sign Google's Contributor License Agreement (either individual or corporate as appropriate, select ‘any other Google project’).
You may ask questions and follow along w/ GN‘s development on Chromium’s gn-dev@ Google Group.