)]}'
{
  "commit": "c78469087cd38cac1e89075c46917485ba509062",
  "tree": "4ef8dd1dfcc1d4f74485d4e9a1b9c69c54bee56e",
  "parents": [
    "9641c502e7b394754033dc2ad873a4b3f3a68a6c"
  ],
  "author": {
    "name": "Matt Stark",
    "email": "msta@google.com",
    "time": "Thu Apr 23 13:40:48 2026 +1000"
  },
  "committer": {
    "name": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Wed Apr 22 21:46:00 2026 -0700"
  },
  "message": "Simplify success expectations in GN.\n\nIt is extremely common to do `EXPECT_FALSE(err.has_error())` to check\nfor success, but users rarely log the error that actually occurred.\n\nThis introduces EXPECT_SUCCESS|ASSERT_SUCCESS(err), which automatically\nlogs the error message if an error occurred.\n\nChange-Id: Id987943fc10274f537d90a1314a97f6c6a6a6964\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/22040\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\nCommit-Queue: Matt Stark \u003cmsta@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "08ff8af3d81d88874e31fc0a89cb648c2f3a8490",
      "old_mode": 33188,
      "old_path": "src/gn/action_target_generator_unittest.cc",
      "new_id": "dd91fe544bb46b7ca61992dccedbe93bc5da4991",
      "new_mode": 33188,
      "new_path": "src/gn/action_target_generator_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "ba1ae5ac2f32b7ccfd388b5831758fc980ae2a8d",
      "old_mode": 33188,
      "old_path": "src/gn/binary_target_generator_unittest.cc",
      "new_id": "66add7ab561d09d08cef20bc28c294771bc28b61",
      "new_mode": 33188,
      "new_path": "src/gn/binary_target_generator_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "990cb3533b371fff380b644998b3e6eff72e79ba",
      "old_mode": 33188,
      "old_path": "src/gn/builder_unittest.cc",
      "new_id": "8e08fab08f0908607e10a91dbd7518c9267b6397",
      "new_mode": 33188,
      "new_path": "src/gn/builder_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "6d861cdff41b26156ff84f7c80026c12abfff185",
      "old_mode": 33188,
      "old_path": "src/gn/commands_unittest.cc",
      "new_id": "44c91b75be16d69006d75798722ad663f32cd120",
      "new_mode": 33188,
      "new_path": "src/gn/commands_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "f6de442ade79c17489adbf35861e441b53b6919d",
      "old_mode": 33188,
      "old_path": "src/gn/compile_commands_writer_unittest.cc",
      "new_id": "b4aa2b5dea2e65b2a7df28950f247295e8f78e39",
      "new_mode": 33188,
      "new_path": "src/gn/compile_commands_writer_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "24efa4c8e1c64f9ef2ef5894cc64d0cffb682d36",
      "old_mode": 33188,
      "old_path": "src/gn/config_values_extractors_unittest.cc",
      "new_id": "3b0907698677563360a2917a850954987b221dc3",
      "new_mode": 33188,
      "new_path": "src/gn/config_values_extractors_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "c1a0ae8ed6fc9f71541cb53f7fb65ea8ff58c08a",
      "old_mode": 33188,
      "old_path": "src/gn/filesystem_utils_unittest.cc",
      "new_id": "7b69a639361e566ffff52d72bfb81609c0711d34",
      "new_mode": 33188,
      "new_path": "src/gn/filesystem_utils_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "ecd467c612c9ecc56cfd0bd624cd629e3f29e45a",
      "old_mode": 33188,
      "old_path": "src/gn/function_expand_directory_unittest.cc",
      "new_id": "eadcb3e6c856bdb3efab0affd26c185fd036ece3",
      "new_mode": 33188,
      "new_path": "src/gn/function_expand_directory_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "4a0ebf3612b3b5ede36875c725460095185571f5",
      "old_mode": 33188,
      "old_path": "src/gn/function_filter_labels_unittest.cc",
      "new_id": "956bf39a5f631359b3475d077fa1342123758aed",
      "new_mode": 33188,
      "new_path": "src/gn/function_filter_labels_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "4269f18e3b48ab2a92e83e8ace7847c236ffa0ed",
      "old_mode": 33188,
      "old_path": "src/gn/function_filter_unittest.cc",
      "new_id": "1cd5d7e0d2ec736f6cecd53ee88992ece925b5ca",
      "new_mode": 33188,
      "new_path": "src/gn/function_filter_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "2093d4582b178449bca041ab6aa4413f522487b3",
      "old_mode": 33188,
      "old_path": "src/gn/function_foreach_unittest.cc",
      "new_id": "50536494ed3e0473a0b4b21cf7b53b1a719fd3bb",
      "new_mode": 33188,
      "new_path": "src/gn/function_foreach_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "2f60f82da1c0980e6fa24f2350fb3ba7ca781740",
      "old_mode": 33188,
      "old_path": "src/gn/function_forward_variables_from_unittest.cc",
      "new_id": "d6a595a3f31863e256a2afe244e2630206afdde1",
      "new_mode": 33188,
      "new_path": "src/gn/function_forward_variables_from_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "4cbd8f9272c2449ee93a4dfcacc9aa7aded86686",
      "old_mode": 33188,
      "old_path": "src/gn/function_get_target_outputs_unittest.cc",
      "new_id": "6a2e86fd04d599cb966ef608af4dee5a06f1c3f9",
      "new_mode": 33188,
      "new_path": "src/gn/function_get_target_outputs_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "f7bda694f5b19bcb367428ad8fe330e43d1241b5",
      "old_mode": 33188,
      "old_path": "src/gn/function_label_matches_unittest.cc",
      "new_id": "4fa5956c44a96edaf1b86fcfca296d19be8e32c4",
      "new_mode": 33188,
      "new_path": "src/gn/function_label_matches_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "47e36315fc4bdd1d71fd5955f3afc40a4579f048",
      "old_mode": 33188,
      "old_path": "src/gn/function_len_unittest.cc",
      "new_id": "16cd16085d64c0307ebece9ceaba8ed7a5d64ee1",
      "new_mode": 33188,
      "new_path": "src/gn/function_len_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "402f5dd10803fa913b622d958e18ec9279382f39",
      "old_mode": 33188,
      "old_path": "src/gn/function_path_exists_unittest.cc",
      "new_id": "fe22857fdece5cb8cc554feb95a8ac0dcf34547a",
      "new_mode": 33188,
      "new_path": "src/gn/function_path_exists_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "d9c99192ebf33b86ab3268a11b03d62c29d3367f",
      "old_mode": 33188,
      "old_path": "src/gn/function_process_file_template_unittest.cc",
      "new_id": "296635860695515de0ff1e81b5fa6dee34452ed3",
      "new_mode": 33188,
      "new_path": "src/gn/function_process_file_template_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "a4c403f106930f949a3b8cd46dbde3893b205944",
      "old_mode": 33188,
      "old_path": "src/gn/function_rebase_path_unittest.cc",
      "new_id": "d587ba91be8224e338e672a64e4836e51b539d62",
      "new_mode": 33188,
      "new_path": "src/gn/function_rebase_path_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "2ea9e8b484a09c530220160b5659467f853a233d",
      "old_mode": 33188,
      "old_path": "src/gn/function_template_unittest.cc",
      "new_id": "1d87299ea7c24fef0aae829bf8c5b369db8b51e3",
      "new_mode": 33188,
      "new_path": "src/gn/function_template_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "838eb3e30b1ccdd9500de807d076392a576850fd",
      "old_mode": 33188,
      "old_path": "src/gn/function_toolchain_unittest.cc",
      "new_id": "cea95cb9db3bf6d6931a92450b7f9da09f531571",
      "new_mode": 33188,
      "new_path": "src/gn/function_toolchain_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "a8239aa6bac0fa7cba7ea3b268ec693d82387ed4",
      "old_mode": 33188,
      "old_path": "src/gn/functions_target_rust_unittest.cc",
      "new_id": "fcf406089368f93fc47c620f46057d9babaf9ef1",
      "new_mode": 33188,
      "new_path": "src/gn/functions_target_rust_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "04b2a4bc6d6e41ecced6a31e0c997967732fb4a4",
      "old_mode": 33188,
      "old_path": "src/gn/functions_target_unittest.cc",
      "new_id": "4a397c91b0604980c08449aaca79e783fd5b21de",
      "new_mode": 33188,
      "new_path": "src/gn/functions_target_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "61a3b35336e7f1510a0873c0ea1130508c45409a",
      "old_mode": 33188,
      "old_path": "src/gn/functions_unittest.cc",
      "new_id": "6fc0e2fbf624972d1912876d5c21bdca91844e51",
      "new_mode": 33188,
      "new_path": "src/gn/functions_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "ec5a397c37565185f5470cd643f8586601794bdf",
      "old_mode": 33188,
      "old_path": "src/gn/header_checker_unittest.cc",
      "new_id": "99a36065d02cbd6772b8e826374ee5a4ff9d9296",
      "new_mode": 33188,
      "new_path": "src/gn/header_checker_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "054b3377609c93b79a68599e3bd22276f1d52e48",
      "old_mode": 33188,
      "old_path": "src/gn/input_conversion_unittest.cc",
      "new_id": "f70a95423cfc0114847174daecaf7f153b98642a",
      "new_mode": 33188,
      "new_path": "src/gn/input_conversion_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "7ae9f153f5719fddbd2d70ce9db6c02d81e252dc",
      "old_mode": 33188,
      "old_path": "src/gn/label_pattern_unittest.cc",
      "new_id": "a33b49f1954db502869d06ad2aa42586f64eb4b5",
      "new_mode": 33188,
      "new_path": "src/gn/label_pattern_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "5f3bb491d786bc7dd99674773267705003772e5d",
      "old_mode": 33188,
      "old_path": "src/gn/label_unittest.cc",
      "new_id": "1b545ae4ee95373fd5bea9595a6925a222baebf4",
      "new_mode": 33188,
      "new_path": "src/gn/label_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "dcc5e61b7df4eb54f2421d40fde178a6bd7ebc97",
      "old_mode": 33188,
      "old_path": "src/gn/loader_unittest.cc",
      "new_id": "4189315ab55739ab1e73cac35cbd9740a2e9f4c2",
      "new_mode": 33188,
      "new_path": "src/gn/loader_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "df57cd511ccbf429081d889e991099109e34e442",
      "old_mode": 33188,
      "old_path": "src/gn/metadata_unittest.cc",
      "new_id": "ab14ba644d62a37fdc1ef570742f7a8aa6a03f7f",
      "new_mode": 33188,
      "new_path": "src/gn/metadata_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "9f83fa37ee03a44f250467e760a47564c3d1a103",
      "old_mode": 33188,
      "old_path": "src/gn/metadata_walk_unittest.cc",
      "new_id": "518fdf26ebac1241d6e13d44109ebbe502ab61b3",
      "new_mode": 33188,
      "new_path": "src/gn/metadata_walk_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "8d2a84a48e225950d3eaf5139d0da05116dc5e8b",
      "old_mode": 33188,
      "old_path": "src/gn/ninja_c_binary_target_writer.cc",
      "new_id": "14f95ed2e79ee1147ef18daceb68dba6b76dacf8",
      "new_mode": 33188,
      "new_path": "src/gn/ninja_c_binary_target_writer.cc"
    },
    {
      "type": "modify",
      "old_id": "6420aad5cb04d55da3b4d96c03f3a1e3942c3d77",
      "old_mode": 33188,
      "old_path": "src/gn/operators_unittest.cc",
      "new_id": "b812aa92321d42c6663fa235f9ea13bf552a62ce",
      "new_mode": 33188,
      "new_path": "src/gn/operators_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "3e1b9579e3410645df33ee3159d37de7d5229821",
      "old_mode": 33188,
      "old_path": "src/gn/output_conversion_unittest.cc",
      "new_id": "21b9aa0cda76c6c9d007e1ee15cbd3d610cbadfd",
      "new_mode": 33188,
      "new_path": "src/gn/output_conversion_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "c5bfa827cad9e41244bdcee084a3c64d805a876f",
      "old_mode": 33188,
      "old_path": "src/gn/parse_tree_unittest.cc",
      "new_id": "49a3fd1ed72cf0d81a2280092019e93fb126187c",
      "new_mode": 33188,
      "new_path": "src/gn/parse_tree_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "c4b966f2fa703601a7daae905b2f01a0ac831805",
      "old_mode": 33188,
      "old_path": "src/gn/scope_unittest.cc",
      "new_id": "4aec54c398cbec52b8c1e736d763d21912d7f13d",
      "new_mode": 33188,
      "new_path": "src/gn/scope_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "148ab92f325cf94e59aa8a1bfb2db531734745ee",
      "old_mode": 33188,
      "old_path": "src/gn/source_dir_unittest.cc",
      "new_id": "3623e29c859284dd02f2acecda31e4697b068a86",
      "new_mode": 33188,
      "new_path": "src/gn/source_dir_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "76e4dec7129f90c3a644a3f071dc18299e650c8a",
      "old_mode": 33188,
      "old_path": "src/gn/substitution_pattern_unittest.cc",
      "new_id": "71ecfbb8742bea70d4ce9c6d13954317ecdf80c5",
      "new_mode": 33188,
      "new_path": "src/gn/substitution_pattern_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "eaa521ab9c335cfbf50d79a6c5e08415109803b5",
      "old_mode": 33188,
      "old_path": "src/gn/substitution_writer_unittest.cc",
      "new_id": "5ea595e112becda1492b5774c4c6950e00785289",
      "new_mode": 33188,
      "new_path": "src/gn/substitution_writer_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "b920c26ed95b3cc99a1ccab62022b57860a7ad93",
      "old_mode": 33188,
      "old_path": "src/gn/target_unittest.cc",
      "new_id": "81c93efa531bdf174c25500c34a98ad20ab13f31",
      "new_mode": 33188,
      "new_path": "src/gn/target_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "a8c88dc845fd377b656511525bbd5a4c85afa289",
      "old_mode": 33188,
      "old_path": "src/gn/template_unittest.cc",
      "new_id": "58dbf664db2ed24ebb7c1a7a0cbaee8164e19524",
      "new_mode": 33188,
      "new_path": "src/gn/template_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "14881a8bcd3caeaf95c983842c5a9bf7d6fd8f6a",
      "old_mode": 33188,
      "old_path": "src/gn/test_with_scope.h",
      "new_id": "38f7ec07e4a138e50bbf58ba493fd9a17985bcae",
      "new_mode": 33188,
      "new_path": "src/gn/test_with_scope.h"
    },
    {
      "type": "modify",
      "old_id": "dfec895bb6631e0d94d3cd97cdcc2fd9e8541c8b",
      "old_mode": 33188,
      "old_path": "src/gn/tokenizer_unittest.cc",
      "new_id": "6f6f0e04079ebfe56eb2a3c38ade1ecd1c14215f",
      "new_mode": 33188,
      "new_path": "src/gn/tokenizer_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "24199637bd21aa878828aa7e3ac2418523aa31a2",
      "old_mode": 33188,
      "old_path": "src/util/test/test.h",
      "new_id": "94d71295f0424f46b47ed397dd0ef2a298519d28",
      "new_mode": 33188,
      "new_path": "src/util/test/test.h"
    }
  ]
}