tree 4ef8dd1dfcc1d4f74485d4e9a1b9c69c54bee56e
parent 9641c502e7b394754033dc2ad873a4b3f3a68a6c
author Matt Stark <msta@google.com> 1776915648 +1000
committer gn-scoped@luci-project-accounts.iam.gserviceaccount.com <gn-scoped@luci-project-accounts.iam.gserviceaccount.com> 1776919560 -0700

Simplify success expectations in GN.

It is extremely common to do `EXPECT_FALSE(err.has_error())` to check
for success, but users rarely log the error that actually occurred.

This introduces EXPECT_SUCCESS|ASSERT_SUCCESS(err), which automatically
logs the error message if an error occurred.

Change-Id: Id987943fc10274f537d90a1314a97f6c6a6a6964
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/22040
Reviewed-by: Takuto Ikuta <tikuta@google.com>
Commit-Queue: Matt Stark <msta@google.com>