tree 1e4e727a3772bf9d6e3ffab4e98a649e6fb68d5a
parent 7296b601ea80252ccf8cce300c4bebcabf235f20
author Greg Thompson <grt@chromium.org> 1734437191 +0100
committer GN LUCI <gn-scoped@luci-project-accounts.iam.gserviceaccount.com> 1734464278 -0800

Retry ReplaceFile in case of failure

The Win32 ReplaceFile function performs several IO operations under the
covers. Among these is creating a temporary file to which the original
file will be moved. Aggressive filesystem scanners, such as A/V software
or git fsmontor--daemon, may inspect this temporary file. When such
software wins the race with the actual movement of the file, ReplaceFile
will fail with ERROR_UNABLE_TO_REMOVE_REPLACED. This is unfortunate.

This CL makes base::ReplaceFile a bit more robust against these scanners
by retrying a call to ReplaceFile that fails in this way for up to half
a second. In local experimentation, the second or third attempt tends to
succeed when the first fails.

This is a band-aid over failures of the "ERROR Failed to write
build.ninja." variety.

Bug: 384523565
Change-Id: Ia77e596687fd91daa888bcc6c07604b845093295
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/18020
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: David Turner <digit@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>