)]}'
{
  "commit": "cf3236d32b53df18d2b2da8c57814b8d2713c03c",
  "tree": "ca03e7c7c5c508cee9679f24efbc8d76636ed73b",
  "parents": [
    "770307d637340c01859f4dc206a8fe35cefe0668"
  ],
  "author": {
    "name": "Andrew Grieve",
    "email": "agrieve@google.com",
    "time": "Tue Nov 17 14:39:44 2026 -0500"
  },
  "committer": {
    "name": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Tue Nov 17 12:04:04 2026 -0800"
  },
  "message": "Add dep_keys to generated_file()\n\nCollecting the outputs of build steps into a generated_file() currently\nrequires the generated_file() to depend on everything that it walks, so\nthat the collected files exist before its consumers run. With walk_deps,\nthe walked targets are no longer dependencies at all, and nothing orders\nthe build steps that produce the collected files before the consumers.\n\nThis adds a dep_keys variable to generated_file(): metadata keys whose\nvalues are labels of the walked target itself or of its direct deps\n(resolved like walk_keys). The resulting targets become dependencies of\nthe generated_file()\u0027s Ninja build statement, in addition to its deps\nand data_deps. This allows depending on only the subset of walked\ntargets that produce the collected data.\n\nAny dependency cycles created via dep_keys (when combined with\nwalk_deps or validations) are detected by Ninja rather than during\n\"gn gen\". No visibility, testonly, or assert_no_deps checks are done\nfor collected targets, since they are found through targets that\nalready depend on them.\n\nThe motivating use case is Chromium\u0027s JNI Zero, whose final\nregistration step re-parses every .java file because it cannot depend\non the .jni.pickle outputs of per-library steps without depending on\nall native libraries and on the APK that depends on it.\n\nBug: 579603584\nChange-Id: I51dd90c8d1b7e382dd7d4266f39fa80c849dcd68\nAgent-Generated: true\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/28722\nReviewed-by: David Turner \u003cdigit@google.com\u003e\nCommit-Queue: Andrew Grieve \u003cagrieve@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "2043388730336c48fb430aed766e5dab9bd21c7d",
      "old_mode": 33188,
      "old_path": "docs/reference.md",
      "new_id": "e55a46ca5d414d241229b5438cc84c5e3fc3a6a7",
      "new_mode": 33188,
      "new_path": "docs/reference.md"
    },
    {
      "type": "modify",
      "old_id": "af2a60b8e912c61e30420daa4baab5b1367fc8dc",
      "old_mode": 33188,
      "old_path": "src/gn/command_desc.cc",
      "new_id": "d8533633725cf504d3af1746c68022e695748472",
      "new_mode": 33188,
      "new_path": "src/gn/command_desc.cc"
    },
    {
      "type": "modify",
      "old_id": "3a3b8646cb0af4b5e1439cf2c6e5d753569b56c5",
      "old_mode": 33188,
      "old_path": "src/gn/desc_builder.cc",
      "new_id": "d21bfc6756af1569475e19c8351c37780af29ed7",
      "new_mode": 33188,
      "new_path": "src/gn/desc_builder.cc"
    },
    {
      "type": "modify",
      "old_id": "e05a36f15fb28008362b7c5c8c1890488cfdb3cf",
      "old_mode": 33188,
      "old_path": "src/gn/functions_target.cc",
      "new_id": "ffa6d21b568f97d4c470a36899549aead2223469",
      "new_mode": 33188,
      "new_path": "src/gn/functions_target.cc"
    },
    {
      "type": "modify",
      "old_id": "760006eb121cb0ca1aadbd0bebb88ed7ee3e77da",
      "old_mode": 33188,
      "old_path": "src/gn/functions_target_unittest.cc",
      "new_id": "83af8f876d6cb2df5252387a451f4de53ae5c88c",
      "new_mode": 33188,
      "new_path": "src/gn/functions_target_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "dea6a1001aaf2eaf07320358961910cc9662f2ea",
      "old_mode": 33188,
      "old_path": "src/gn/generated_file_target_generator.cc",
      "new_id": "e227e4eac4bc5bf6989eab04fdb47e069a62ee88",
      "new_mode": 33188,
      "new_path": "src/gn/generated_file_target_generator.cc"
    },
    {
      "type": "modify",
      "old_id": "ab8e9aace5aa4c96f5fb79b10cfe12238afec6a5",
      "old_mode": 33188,
      "old_path": "src/gn/generated_file_writer.cc",
      "new_id": "c86875c341a8de45876d15da614df75125cadc8f",
      "new_mode": 33188,
      "new_path": "src/gn/generated_file_writer.cc"
    },
    {
      "type": "modify",
      "old_id": "833ed970dadea3289277950990c00d37cca594e5",
      "old_mode": 33188,
      "old_path": "src/gn/generated_file_writer.h",
      "new_id": "b4421abe24ae432c7324daa13cf87d306bdd626d",
      "new_mode": 33188,
      "new_path": "src/gn/generated_file_writer.h"
    },
    {
      "type": "modify",
      "old_id": "a981a610dbf5aa1258bcf4a870b5b7d9426c118d",
      "old_mode": 33188,
      "old_path": "src/gn/metadata.cc",
      "new_id": "3cf7ff1f322629671ab2974919ed23151fd60061",
      "new_mode": 33188,
      "new_path": "src/gn/metadata.cc"
    },
    {
      "type": "modify",
      "old_id": "7314e722d644e4b4d3f59085bc626f7962ad500f",
      "old_mode": 33188,
      "old_path": "src/gn/ninja_generated_file_target_writer.cc",
      "new_id": "a36977f4772b2825b0753c20cc156a6c22dd2701",
      "new_mode": 33188,
      "new_path": "src/gn/ninja_generated_file_target_writer.cc"
    },
    {
      "type": "modify",
      "old_id": "e8bde008655f1153c6f998db599901b923d9a8d1",
      "old_mode": 33188,
      "old_path": "src/gn/setup_unittest.cc",
      "new_id": "3df05a07dcc46c833212d1a9e4225c8efd2acce6",
      "new_mode": 33188,
      "new_path": "src/gn/setup_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "2bf4f278148af1bc62afbef87f01aad102ae277b",
      "old_mode": 33188,
      "old_path": "src/gn/target.cc",
      "new_id": "d03a092b34e930fc909e0c36a18b4fe8f5e44a49",
      "new_mode": 33188,
      "new_path": "src/gn/target.cc"
    },
    {
      "type": "modify",
      "old_id": "3c5ae32bedb53d9f5fa7fc262c75b555a544977f",
      "old_mode": 33188,
      "old_path": "src/gn/target.h",
      "new_id": "908f3a60fb21277a2a48b70facec859436c88901",
      "new_mode": 33188,
      "new_path": "src/gn/target.h"
    },
    {
      "type": "modify",
      "old_id": "6521776a7659a5416dfc7e4f45dbe9382d3cc1a4",
      "old_mode": 33188,
      "old_path": "src/gn/target_unittest.cc",
      "new_id": "5987cf604bfae4cba889c4e2b1e8bf8759e9c840",
      "new_mode": 33188,
      "new_path": "src/gn/target_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "e4c9a5ed40894ce554ea7668b4785e8e895f37c4",
      "old_mode": 33188,
      "old_path": "src/gn/variables.cc",
      "new_id": "28ab5cbc270aa93a76c10ccab63e2d46676de827",
      "new_mode": 33188,
      "new_path": "src/gn/variables.cc"
    },
    {
      "type": "modify",
      "old_id": "b2be92c7eec8445130688163a31ffb8f54dc4ebe",
      "old_mode": 33188,
      "old_path": "src/gn/variables.h",
      "new_id": "a3a5a19ecbd7a7646a8144a6973e7dc1143acad7",
      "new_mode": 33188,
      "new_path": "src/gn/variables.h"
    }
  ]
}
