)]}'
{
  "commit": "d19c92d7aa682f09312cd7ce25faaff5e153bc93",
  "tree": "2e1fa2c827686f9d00fc53d7f11100c585383e18",
  "parents": [
    "bc823cc7c3744d454b30fdadb5e8b7000ea69171"
  ],
  "author": {
    "name": "Andrew Grieve",
    "email": "agrieve@google.com",
    "time": "Tue Nov 10 13:05:56 2026 -0500"
  },
  "committer": {
    "name": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Mon Nov 16 08:09:37 2026 -0800"
  },
  "message": "Add walk_deps to generated_file()\n\ngenerated_file() currently uses deps and data_deps for two things: as\nthe roots of the metadata walk, and as dependencies of its Ninja build\nstatement. This makes it impossible to collect metadata by walking a\nlarge graph without either:\n1) Making consumers wait for everything that was walked (e.g. waiting\n   for all C++ compiles in order to list the shared libraries of an\n   APK), or\n2) Creating a dependency cycle (e.g. when walking an APK target that\n   itself depends on the consumer of the generated file).\n\nThis adds a walk_deps variable to generated_file(): additional roots\nfor the metadata walk that are not dependencies, and which may form\ncycles with deps. They are tracked by the Builder like validations\n(resolve once defined, finalize once resolved), and targets that use\nthem are written after all targets are resolved, like those that set\ncollect_validations_metadata. The set of delayed targets is unchanged\nfor builds that do not use walk_deps.\n\nLike deps, walk_deps are subject to visibility and testonly checks.\n\nThe top-level generated_file() is now marked as walked before its walk\nstarts, so its own metadata is never collected, even when the walk leads\nback to it (through walk_deps, or through validations when\ncollect_validations_metadata is true).\n\n\"gn analyze\" treats a generated_file() as affected by the targets\nlisted in its walk_deps, without treating those targets as being built\nby it. \"gn refs\" lists generated_file() targets as references to their\nwalk_deps.\n\nA follow-up adds dep_keys, which allows depending on only the subset of\nwalked targets that produce the collected data.\n\nBug: 579603584\nChange-Id: Ib823a15c08ad8e2c98d0a350749f5ac035b6b7bd\nAgent-Generated: true\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/28240\nCommit-Queue: Andrew Grieve \u003cagrieve@google.com\u003e\nReviewed-by: David Turner \u003cdigit@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "d81b026d66974f520de982527bb6876ca438895e",
      "old_mode": 33188,
      "old_path": "docs/reference.md",
      "new_id": "f7e44155c61bf0b668412b07cf28fa3651c7adad",
      "new_mode": 33188,
      "new_path": "docs/reference.md"
    },
    {
      "type": "modify",
      "old_id": "5c1d5e0564a3c9de1929b31c6f593a0ff4682a50",
      "old_mode": 33188,
      "old_path": "src/gn/analyzer.cc",
      "new_id": "a724472e490e2ccb75d62092f5dcb4ccb6de6dfc",
      "new_mode": 33188,
      "new_path": "src/gn/analyzer.cc"
    },
    {
      "type": "modify",
      "old_id": "77aed2a39935fd8883d56e63a2031ba06ef3f0f9",
      "old_mode": 33188,
      "old_path": "src/gn/analyzer.h",
      "new_id": "492cea22575046956142ba31708f94779943b931",
      "new_mode": 33188,
      "new_path": "src/gn/analyzer.h"
    },
    {
      "type": "modify",
      "old_id": "c5aa8d4553bb2159cc8c354e9ff0c4dbaaf39003",
      "old_mode": 33188,
      "old_path": "src/gn/analyzer_unittest.cc",
      "new_id": "43b09b7a7f907f5cbf2bec5ba251ab2a761a681d",
      "new_mode": 33188,
      "new_path": "src/gn/analyzer_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "d2413f19d1ae731bd1ce8d99833f32f999ccfd13",
      "old_mode": 33188,
      "old_path": "src/gn/builder.cc",
      "new_id": "bf5ec83ddc7afc6955d5e857a78cc5e5f5cbfcbc",
      "new_mode": 33188,
      "new_path": "src/gn/builder.cc"
    },
    {
      "type": "modify",
      "old_id": "26bdd9c3de78ee7c5b720190a4ad7b46fa356556",
      "old_mode": 33188,
      "old_path": "src/gn/builder_record.h",
      "new_id": "2dc4c587c56b0b6fe4691763fae2887b8ab3ffc0",
      "new_mode": 33188,
      "new_path": "src/gn/builder_record.h"
    },
    {
      "type": "modify",
      "old_id": "d1e004a783fb364b007ab0d17b33090592d6a014",
      "old_mode": 33188,
      "old_path": "src/gn/command_desc.cc",
      "new_id": "af2a60b8e912c61e30420daa4baab5b1367fc8dc",
      "new_mode": 33188,
      "new_path": "src/gn/command_desc.cc"
    },
    {
      "type": "modify",
      "old_id": "33462ed6669ecf5c57afe82df3ce8c09cf4e5579",
      "old_mode": 33188,
      "old_path": "src/gn/command_gen.cc",
      "new_id": "0b95483ecfb1d9b263380f2ef340c4156fc3d905",
      "new_mode": 33188,
      "new_path": "src/gn/command_gen.cc"
    },
    {
      "type": "modify",
      "old_id": "0645b8262f3cbcf192e916f0be9733bd5549f79f",
      "old_mode": 33188,
      "old_path": "src/gn/command_refs.cc",
      "new_id": "fe70d725466a8f20a134e3e69867748dfb4d1950",
      "new_mode": 33188,
      "new_path": "src/gn/command_refs.cc"
    },
    {
      "type": "modify",
      "old_id": "1627ef63b7bbe31a55353d9d6f57ca64dcaf5067",
      "old_mode": 33188,
      "old_path": "src/gn/desc_builder.cc",
      "new_id": "3a3b8646cb0af4b5e1439cf2c6e5d753569b56c5",
      "new_mode": 33188,
      "new_path": "src/gn/desc_builder.cc"
    },
    {
      "type": "modify",
      "old_id": "9700c65cc4b55bbf1f440d147d010254f3ad816f",
      "old_mode": 33188,
      "old_path": "src/gn/functions_target.cc",
      "new_id": "e05a36f15fb28008362b7c5c8c1890488cfdb3cf",
      "new_mode": 33188,
      "new_path": "src/gn/functions_target.cc"
    },
    {
      "type": "modify",
      "old_id": "3d66b688fd60edeeee5f5dfb9f011a4f4614ce44",
      "old_mode": 33188,
      "old_path": "src/gn/functions_target_unittest.cc",
      "new_id": "760006eb121cb0ca1aadbd0bebb88ed7ee3e77da",
      "new_mode": 33188,
      "new_path": "src/gn/functions_target_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "16b705b57d9d57f4bb01d613b4ed058d31741291",
      "old_mode": 33188,
      "old_path": "src/gn/generated_file_target_generator.cc",
      "new_id": "dea6a1001aaf2eaf07320358961910cc9662f2ea",
      "new_mode": 33188,
      "new_path": "src/gn/generated_file_target_generator.cc"
    },
    {
      "type": "modify",
      "old_id": "59a7539ca77caf2b72a102a95640a2cfe3e7e919",
      "old_mode": 33188,
      "old_path": "src/gn/generated_file_target_generator.h",
      "new_id": "443de8e684325a63d643be29c37ccf3a715d0d68",
      "new_mode": 33188,
      "new_path": "src/gn/generated_file_target_generator.h"
    },
    {
      "type": "modify",
      "old_id": "8ffdbb163536db809d17928594c310dbaad4cb73",
      "old_mode": 33188,
      "old_path": "src/gn/metadata.cc",
      "new_id": "a981a610dbf5aa1258bcf4a870b5b7d9426c118d",
      "new_mode": 33188,
      "new_path": "src/gn/metadata.cc"
    },
    {
      "type": "modify",
      "old_id": "d3140bd986d9ef18589092d0069dacec45a950f2",
      "old_mode": 33188,
      "old_path": "src/gn/setup_unittest.cc",
      "new_id": "ac7db08ec195b6c71682bae582fb4afd564fc07c",
      "new_mode": 33188,
      "new_path": "src/gn/setup_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "39856c308a2e5e3e817dc40750b3bb1188a15110",
      "old_mode": 33188,
      "old_path": "src/gn/target.cc",
      "new_id": "2bf4f278148af1bc62afbef87f01aad102ae277b",
      "new_mode": 33188,
      "new_path": "src/gn/target.cc"
    },
    {
      "type": "modify",
      "old_id": "4403b76828a4ac292cbe36653bbbbb894f88926e",
      "old_mode": 33188,
      "old_path": "src/gn/target.h",
      "new_id": "3c5ae32bedb53d9f5fa7fc262c75b555a544977f",
      "new_mode": 33188,
      "new_path": "src/gn/target.h"
    },
    {
      "type": "modify",
      "old_id": "bef5ddf797b19a657da7746b9fc0fbd84ff92711",
      "old_mode": 33188,
      "old_path": "src/gn/target_generator.h",
      "new_id": "61a23b47ce816b778e86242598b974df5a349465",
      "new_mode": 33188,
      "new_path": "src/gn/target_generator.h"
    },
    {
      "type": "modify",
      "old_id": "e8b751f54373dddc89fb61a05d64eba59ed2cf6d",
      "old_mode": 33188,
      "old_path": "src/gn/target_unittest.cc",
      "new_id": "6521776a7659a5416dfc7e4f45dbe9382d3cc1a4",
      "new_mode": 33188,
      "new_path": "src/gn/target_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "adc7657e08005d31ca81b42af858d88a2ad8b6f9",
      "old_mode": 33188,
      "old_path": "src/gn/variables.cc",
      "new_id": "e4c9a5ed40894ce554ea7668b4785e8e895f37c4",
      "new_mode": 33188,
      "new_path": "src/gn/variables.cc"
    },
    {
      "type": "modify",
      "old_id": "97c21b3e9b6d3f8304206527e72f267f8e61c4aa",
      "old_mode": 33188,
      "old_path": "src/gn/variables.h",
      "new_id": "b2be92c7eec8445130688163a31ffb8f54dc4ebe",
      "new_mode": 33188,
      "new_path": "src/gn/variables.h"
    }
  ]
}
