|author||Scott Graham <email@example.com>||Wed Jan 09 11:24:34 2019 -0800|
|committer||Commit Bot <firstname.lastname@example.org>||Wed Jan 09 19:53:36 2019 +0000|
format: Ensure that formatting always reaches a fixedpoint in one run The .golden for this is ugly, but follows existing sources formatting e.g. in https://gn.googlesource.com/gn/+/master/tools/gn/format_test_data/062.golden#25 This at least causes formatting to reach a fixed point in one step, which is the more annoying bug. In practice, the user will probably fix the sorting to the actual desired formatting by manually sorting as was done in https://chromium-review.googlesource.com/c/chromium/src/+/1403177. Bug: gn:40 Test: CQ Change-Id: Id3fea2564ae34156ac77e7445acd3f18bb4d161f Reviewed-on: https://gn-review.googlesource.com/c/3720 Reviewed-by: Nico Weber <email@example.com> Reviewed-by: Scott Graham <firstname.lastname@example.org> Commit-Queue: Scott Graham <email@example.com>
Alternatively, you can build GN from source:
git clone https://gn.googlesource.com/gn cd gn python build/gen.py ninja -C out # To run tests: out/gn_unittests
On Windows, it is expected that
lib.exe can be found in
PATH, so you'll want to run from a Visual Studio command prompt, or similar.
On Linux and Mac, the default compiler is
clang++, a recent version is expected to be found in
PATH. This can be overridden by setting
If you find a bug, you can see if it is known or report it in the bug database.
GN uses Gerrit for code review. The short version of how to patch is:
Register at https://gn-review.googlesource.com. ... edit code ... ninja -C out && out/gn_unittests
Then, to upload a change for review:
git commit git cl upload --gerrit
When revising a change, use:
git commit --amend git cl upload --gerrit
which will add the new changes to the existing code review, rather than creating a new one.
We ask that all contributors sign Google's Contributor License Agreement (either individual or corporate as appropriate, select ‘any other Google project’).
You may ask questions and follow along w/ GN‘s development on Chromium’s gn-dev@ Google Group.