commit | bcfb647135e19cd806fd60e9638d7b8171d53c57 | [log] [tgz] |
---|---|---|
author | David 'Digit' Turner <digit@google.com> | Tue Jan 08 17:48:26 2019 +0100 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Jan 08 17:50:21 2019 +0000 |
tree | 6ae035738dbe322815116d8084cb1004e89c12dc | |
parent | 88bd8a8d899aa97ccb1baec428adfd47f1589c22 [diff] |
cleanup label_ptr.h Use C++11 default initializers, and remove un-needed template predicates. The only one which was used was LabelPtrLabelLess which is entirely redundant, since the default std::less<> implementation will pick the global operator<() definition. R=dpranke@chromium.org,brettw@chromium.org BUG=NONE Change-Id: Ie3383a60eb67aafdf25666470dab5368f29f8cec Reviewed-on: https://gn-review.googlesource.com/c/3661 Reviewed-by: Brett Wilson <brettw@chromium.org> Commit-Queue: Brett Wilson <brettw@chromium.org>
GN is a meta-build system that generates build files for Ninja. There is documentation in docs/ and a presentation on it.
You can download the latest version of GN binary for Linux, macOS and Windows.
Alternatively, you can build GN from source:
git clone https://gn.googlesource.com/gn cd gn python build/gen.py ninja -C out # To run tests: out/gn_unittests
On Windows, it is expected that cl.exe
, link.exe
, and lib.exe
can be found in PATH
, so you'll want to run from a Visual Studio command prompt, or similar.
On Linux and Mac, the default compiler is clang++
, a recent version is expected to be found in PATH
. This can be overridden by setting CC
, CXX
, and AR
.
If you find a bug, you can see if it is known or report it in the bug database.
GN uses Gerrit for code review. The short version of how to patch is:
Register at https://gn-review.googlesource.com. ... edit code ... ninja -C out && out/gn_unittests
Then, to upload a change for review:
git commit git cl upload --gerrit
When revising a change, use:
git commit --amend git cl upload --gerrit
which will add the new changes to the existing code review, rather than creating a new one.
We ask that all contributors sign Google's Contributor License Agreement (either individual or corporate as appropriate, select ‘any other Google project’).
You may ask questions and follow along w/ GN‘s development on Chromium’s gn-dev@ Google Group.