commit | d46f92f4465be387dcf96fd6be070e8791b59763 | [log] [tgz] |
---|---|---|
author | Sylvain Defresne <sdefresne@chromium.org> | Wed Apr 03 16:14:29 2019 +0200 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Apr 03 14:30:47 2019 +0000 |
tree | 6ccd39c536becf76c263cd618913603dc10f47e1 | |
parent | fb330c7867d626eab7f6bd369f41fb32418cc517 [diff] |
Make all bundle_foo_dir properties optional The bundle_foo_dir properties are only required if they are used by a bundle_data expansion ({{bundle_foo_dir}}). Do not report an error if they are not defined unless there is an expansion using them. Bug: https://bugs.chromium.org/p/gn/issues/detail?id=64 Change-Id: I277fdfc209fb110352f4614addba7f35f127db51 Reviewed-on: https://gn-review.googlesource.com/c/gn/+/4482 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org>
GN is a meta-build system that generates build files for Ninja. There is documentation in docs/ and a presentation on it.
You can download the latest version of GN binary for Linux, macOS and Windows.
Alternatively, you can build GN from source:
git clone https://gn.googlesource.com/gn cd gn python build/gen.py ninja -C out # To run tests: out/gn_unittests
On Windows, it is expected that cl.exe
, link.exe
, and lib.exe
can be found in PATH
, so you'll want to run from a Visual Studio command prompt, or similar.
On Linux and Mac, the default compiler is clang++
, a recent version is expected to be found in PATH
. This can be overridden by setting CC
, CXX
, and AR
.
If you find a bug, you can see if it is known or report it in the bug database.
GN uses Gerrit for code review. The short version of how to patch is:
Register at https://gn-review.googlesource.com. ... edit code ... ninja -C out && out/gn_unittests
Then, to upload a change for review:
git commit git cl upload --gerrit
When revising a change, use:
git commit --amend git cl upload --gerrit
which will add the new changes to the existing code review, rather than creating a new one.
We ask that all contributors sign Google's Contributor License Agreement (either individual or corporate as appropriate, select ‘any other Google project’).
You may ask questions and follow along w/ GN‘s development on Chromium’s gn-dev@ Google Group.