)]}'
{
  "commit": "ddc6c4ae595393d43b38e62f2e2baa7661af716f",
  "tree": "b27b25ca741d754e4759fa74be4ccd6ca275d641",
  "parents": [
    "f4c9d7267e593bd92a3f01a3c55fc260dac0552f"
  ],
  "author": {
    "name": "Roland McGrath",
    "email": "mcgrathr@google.com",
    "time": "Tue Nov 10 15:42:20 2026 -0800"
  },
  "committer": {
    "name": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Fri Nov 13 18:14:21 2026 -0800"
  },
  "message": "rust: Treat config inputs as implicit rebuild deps\n\nNinjaRustBinaryTargetWriter previously placed the result of\nWriteInputsStampOrPhonyAndGetDep() into order-only dependencies (\"||\")\nwhile only adding target_-\u003econfig_values().inputs() to implicit\ndependencies (\"|\") and to the `sources` Ninja variable (\"{{sources}}\").\nAs a result, `inputs` specified on `config()` definitions (via\n`configs`, `public_configs`, `all_dependent_configs`, or sub-configs)\nwere omitted from `sources` and treated only as order-only dependencies,\nso changes to config inputs such as custom `rustc --target` JSON specs\nfailed to trigger incremental rebuilds (see https://fxrev.dev/1967814).\n\nRefactor NinjaBinaryTargetWriter to share input and dependency\ncollection cleanly between NinjaCBinaryTargetWriter and\nNinjaRustBinaryTargetWriter:\n- Extract GetInputs() using UniqueVector\u003cSourceFile\u003e so duplicate\n  SourceFile entries across targets and configs are deduplicated by\n  value rather than element pointer address, and share it with\n  NinjaRustBinaryTargetWriter::WriteSourcesAndInputs().\n- Extract WriteCompilerInputDeps(num_output_uses) combining implicit\n  `inputs`, `public_inputs`, and toolchain `deps` with order-only\n  upstream hard dependencies.\n- Pass num_output_uses \u003d 1 in NinjaRustBinaryTargetWriter::Run() since\n  Rust compiles a crate in a single build statement, avoiding redundant\n  per-target `.inputs` / `.inputdeps` phony or stamp rules.\n- Deduplicate `order_only_deps` with UniqueVector\u003cOutputFile\u003e and drop\n  the duplicate tool_-\u003einputs_phony_or_file() addition already handled\n  by WriteCompilerBuildLine().\n\nChange-Id: I89c123308a0c7f8f2f6844cc50a2dce0a0214cba\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/28740\nCommit-Queue: Petr Hosek \u003cphosek@google.com\u003e\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\nReviewed-by: Aaron Wood \u003caaronwood@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "420ac0aec43df6dec1498574bae119e773c6dc15",
      "old_mode": 33188,
      "old_path": "src/gn/ninja_binary_target_writer.cc",
      "new_id": "e9e23cf2b565cd95bb6baf5f3e119e38dc1f81aa",
      "new_mode": 33188,
      "new_path": "src/gn/ninja_binary_target_writer.cc"
    },
    {
      "type": "modify",
      "old_id": "f942297779acb8d6ad72e96282dbd6ee07f03350",
      "old_mode": 33188,
      "old_path": "src/gn/ninja_binary_target_writer.h",
      "new_id": "71665891b4d32a12c3943f2b89d40bb1bbaf85eb",
      "new_mode": 33188,
      "new_path": "src/gn/ninja_binary_target_writer.h"
    },
    {
      "type": "modify",
      "old_id": "b750cda1665e11e39a94403462d68782e4037b35",
      "old_mode": 33188,
      "old_path": "src/gn/ninja_c_binary_target_writer.cc",
      "new_id": "027ba0688f662a0069b171fb16e0ee53898e7727",
      "new_mode": 33188,
      "new_path": "src/gn/ninja_c_binary_target_writer.cc"
    },
    {
      "type": "modify",
      "old_id": "edaf89fe37aac6da6e4b5427f7fa466dee4430ca",
      "old_mode": 33188,
      "old_path": "src/gn/ninja_c_binary_target_writer_unittest.cc",
      "new_id": "e446574ce0dab0027364d4d5f43221fbf33c0085",
      "new_mode": 33188,
      "new_path": "src/gn/ninja_c_binary_target_writer_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "7cf7256d36a0d843f7e544b72d6f28ff26081f8c",
      "old_mode": 33188,
      "old_path": "src/gn/ninja_rust_binary_target_writer.cc",
      "new_id": "c263c755019cede6315a6077482c4a5c99e32a45",
      "new_mode": 33188,
      "new_path": "src/gn/ninja_rust_binary_target_writer.cc"
    },
    {
      "type": "modify",
      "old_id": "99f95feaff1bc001d16ef77c9e8f2bdbd440fc6b",
      "old_mode": 33188,
      "old_path": "src/gn/ninja_rust_binary_target_writer.h",
      "new_id": "44e598a5ad4c49b5f5275280df6f40ed888bf33e",
      "new_mode": 33188,
      "new_path": "src/gn/ninja_rust_binary_target_writer.h"
    },
    {
      "type": "modify",
      "old_id": "3d0733a9267dfeb27bf7bea5e45aeff07c099605",
      "old_mode": 33188,
      "old_path": "src/gn/ninja_rust_binary_target_writer_unittest.cc",
      "new_id": "4f5282e9712a36b0a09341c6ee242356e18586e0",
      "new_mode": 33188,
      "new_path": "src/gn/ninja_rust_binary_target_writer_unittest.cc"
    }
  ]
}
