tree 77f2242ad8522720889e1160ece6b0afd71710c5
parent 60af296127272ea80c46d37fcbeb031e6dd7d563
author David 'Digit' Turner <digit@google.com> 1637456780 +0100
committer Commit Bot <commit-bot@chromium.org> 1637780404 +0000

Remove Location::byte_ member and byte() method.

Th Location class has a byte_ member representing a token's byte offset
in the input file. However, it is only used to perform less-than
comparisons, which is inconsistent with the Location::operator<()
method which uses (line, column) pairs instead. Also its value cannot
be properly determined when Location() instances are created outside of
the tokenizer (e.g. in the header checker).

This CL simplifies the class by removing the member entirely, and
adding a proper Location::operator<=() instead.

This is mostly cosmetic: measurements do not show any noticeable change
in performance or memory usage.

Change-Id: I220b34fd8bcaabc7750d3792c8dcea4284cd8a57
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/12540
Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: David Turner <digit@google.com>