)]}'
{
  "commit": "e11eb98e86c65f5755d2eedbbd3b4614c8a5a52a",
  "tree": "83581c0862d1e4fcb0ce468fad1c8c3ff8770e34",
  "parents": [
    "27bbb757ec575569ef235e3e0cac247d685070e9"
  ],
  "author": {
    "name": "thakis",
    "email": "thakis@chromium.org",
    "time": "Mon Jun 08 16:14:21 2015 -0700"
  },
  "committer": {
    "name": "Commit bot",
    "email": "commit-bot@chromium.org",
    "time": "Mon Jun 08 23:15:01 2015 +0000"
  },
  "message": "clang/win: Make everything work in a GN build.\n\nDo this by removing the default_warnings config, moving the flags in there to a\nvariable, and use it in both the chromium_code and no_chromium_code configs.\n\nIf a target does\n\n    configs -\u003d [ \"//build/config/compiler:chromium_code\" ]\n    configs +\u003d [ \"//build/config/compiler:no_chromium_code\" ]\n\nthis would add no_chromium_code to the end of configs previously, and the\n-Wno-foo flags in default_warnings would be passed before the /W3 flag in\nno_chromium_code (and /W3 would then override some of the -Wno-foo flags).\nBy moving the flags into no_chromium_code, they\u0027re guaranteed to appear\nafter /W3 (and after -Wall on POSIX).\n\nSee also thread \"configs and warning cflag ordering\" on gn-dev:\nhttps://groups.google.com/a/chromium.org/forum/#!topic/gn-dev/qkqdlwtcQW4\n\nIn a similar vein, move a -Wno-foo flag in skia/BUILD.gn into a config, to make sure\nit appears at the end of the compile command.\n\nWhile here, also remove /wd4267 from skia\u0027s BUILD.gn, it\u0027s already passed globally\n(this part doesn\u0027t change behavior).\n\n(clang-cl working with gn also needs an ffmpeg roll to pick up\nhttps://chromium.googlesource.com/chromium/third_party/ffmpeg/+/5eb7926d25142b65d77be3706ff8bd8116a9d150\nThis is blocked on http://crbug.com/496975)\n\nBUG\u003d491209\nCQ_EXTRA_TRYBOTS\u003dtryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg\n\nReview URL: https://codereview.chromium.org/1151303006\n\nCr-Original-Commit-Position: refs/heads/master@{#333380}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 0bfa8a8a759697b140ef2a18f058513ec8485a57\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "57df03c94b3c0bc5cb1521c7ff56bce144c3ed87",
      "old_mode": 33188,
      "old_path": "tools/gn/docs/cookbook.md",
      "new_id": "9e9d58b735a510cb9830dd7ec0043495ab6b2cf0",
      "new_mode": 33188,
      "new_path": "tools/gn/docs/cookbook.md"
    }
  ]
}