commit | e15f243a7af794b1bdc915885717749af853a3bb | [log] [tgz] |
---|---|---|
author | Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> | Mon Feb 25 15:09:52 2019 +0100 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Feb 25 14:23:48 2019 +0000 |
tree | 7afbc4995ade348155a09c61a0a586c58dd00df0 | |
parent | 013513c98096e254b94bbbe1d7e23a00064ef2de [diff] |
gen.py: Pass -pthread, not -lpthread, in ldflags. This was shamefully overlooked in 1152229e ("gen.py: Pass -pthread via ldflags, not libs"), where I was supposed to revert the entirety of commit 082fbe39 ("Pass -lpthread when linking instead of -pthread") but did not notice that 0ac93dd2 ("For proper order put -lpthreads as a 'library' not a 'linker flag'") continued passing -lpthread instead of -pthread. Bug: chromium:934793 Change-Id: I1fa6d2c8b32a86d621a74ae97f391fbe4ea5e989 Reviewed-on: https://gn-review.googlesource.com/c/4100 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org>
GN is a meta-build system that generates build files for Ninja. There is documentation in docs/ and a presentation on it.
You can download the latest version of GN binary for Linux, macOS and Windows.
Alternatively, you can build GN from source:
git clone https://gn.googlesource.com/gn cd gn python build/gen.py ninja -C out # To run tests: out/gn_unittests
On Windows, it is expected that cl.exe
, link.exe
, and lib.exe
can be found in PATH
, so you'll want to run from a Visual Studio command prompt, or similar.
On Linux and Mac, the default compiler is clang++
, a recent version is expected to be found in PATH
. This can be overridden by setting CC
, CXX
, and AR
.
If you find a bug, you can see if it is known or report it in the bug database.
GN uses Gerrit for code review. The short version of how to patch is:
Register at https://gn-review.googlesource.com. ... edit code ... ninja -C out && out/gn_unittests
Then, to upload a change for review:
git commit git cl upload --gerrit
When revising a change, use:
git commit --amend git cl upload --gerrit
which will add the new changes to the existing code review, rather than creating a new one.
We ask that all contributors sign Google's Contributor License Agreement (either individual or corporate as appropriate, select ‘any other Google project’).
You may ask questions and follow along w/ GN‘s development on Chromium’s gn-dev@ Google Group.