)]}' { "commit": "e70d8c3d5620bc0ddcbad23a36b1b26f815ca90a", "tree": "4373ac5ab34356777491f656743bcadae66fca63", "parents": [ "1da84bb3dac17cd6131fd5067399caa6e7e848c6" ], "author": { "name": "Joshua Seaton", "email": "joshuaseaton@google.com", "time": "Thu Sep 15 20:20:13 2022 +0000" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Sep 15 23:08:25 2022 +0000" }, "message": "Revert \"Record generated_file()s as outputs of `gn`\"\n\nThis reverts commit 23ede3b7b53f5bc56d3952c6d727f167cae34ab2.\n\nReason for revert: seeing errors in which `gn gen` dirties build.ninja, which results in an infinite loop.\n\nOriginal change\u0027s description:\n\u003e Record generated_file()s as outputs of `gn`\n\u003e\n\u003e This is an accurate relationship and allows for tooling to ensure a\n\u003e given generated_file() is up-to-date without an unconditional `gn gen`.\n\u003e\n\u003e build.ninja was manually verified in a particular GN-based build,\n\u003e wherein `ninja $SOME_GENERATED_FILE` now works.\n\u003e\n\u003e Fixed: 301\n\u003e Change-Id: I06c7ec142072d2e73860cdde4898af6f9e65065a\n\u003e Reviewed-on: https://gn-review.googlesource.com/c/gn/+/14580\n\u003e Commit-Queue: Joshua Seaton \u003cjoshuaseaton@google.com\u003e\n\u003e Reviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n\nTBR\u003dbrettw@chromium.org,brettw@google.com,joshuaseaton@google.com,gn-scoped@luci-project-accounts.iam.gserviceaccount.com\n\nChange-Id: Iae22482c42eafeff0cb0b54d204be4693f4f3208\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/14600\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Joshua Seaton \u003cjoshuaseaton@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "5e83bc847d553f682ceb97e7914d781468762bc5", "old_mode": 33188, "old_path": "src/gn/ninja_build_writer.cc", "new_id": "6a5b91db16daa14e2bf0fce94eb75352f6abe856", "new_mode": 33188, "new_path": "src/gn/ninja_build_writer.cc" }, { "type": "modify", "old_id": "dbfe89197e9c3ad457ce280ffa14235c9820d7cf", "old_mode": 33188, "old_path": "src/gn/ninja_build_writer.h", "new_id": "c21769a572ce833f7113096b1e003a2c1cc81376", "new_mode": 33188, "new_path": "src/gn/ninja_build_writer.h" }, { "type": "modify", "old_id": "8966f59c96a8521389218432b76599067ef77d46", "old_mode": 33188, "old_path": "src/gn/ninja_build_writer_unittest.cc", "new_id": "8ab5e5612f36e2bb0b59864e2d4effe00afe025c", "new_mode": 33188, "new_path": "src/gn/ninja_build_writer_unittest.cc" }, { "type": "modify", "old_id": "35ae09724409d307cb25fa8698245ae93c7eaea5", "old_mode": 33188, "old_path": "src/gn/scheduler.cc", "new_id": "6525f33ec3ae8601f978c9a96b8fef14aeb7c253", "new_mode": 33188, "new_path": "src/gn/scheduler.cc" }, { "type": "modify", "old_id": "52e0b47e2ceb0535a527a0c5d4fabffca4cb1761", "old_mode": 33188, "old_path": "src/gn/scheduler.h", "new_id": "cf29fe86ddc2c8900ea1a7b8888f178f3eb11f6e", "new_mode": 33188, "new_path": "src/gn/scheduler.h" }, { "type": "modify", "old_id": "ea6277a1e9dd61d5ef7711976b60ce540ca7969f", "old_mode": 33188, "old_path": "src/gn/target.cc", "new_id": "7b545b522fcd07ce571bd6a9bec7d482284ba2ba", "new_mode": 33188, "new_path": "src/gn/target.cc" } ] }