commit eade6029cb0108589db4faae4b6c1f71c0adf294
author Dirk Pranke <dpranke@chromium.org> Mon Jul 17 16:19:38 2017 +0000
committer Commit Bot <commit-bot@chromium.org> Mon Jul 17 16:19:38 2017 +0000
tree cfe4b31dc4a046ee471b18ac116b39cbc9e0bdbf
parent d91c7ad3c60a237fab039aecca255ea21e6789ce

fix gn roller

Bug: 
Change-Id: I5c9448c739e21c05177b12d9d86a6b84561968df
Reviewed-on: https://chromium-review.googlesource.com/572432
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#487103}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7f89382346fc6b03703c43574a5437c289f12348

tools/gn/bin/roll_gn.py

diff --git a/tools/gn/bin/roll_gn.py b/tools/gn/bin/roll_gn.py
index 7436f4e..3dd7831 100755
--- a/tools/gn/bin/roll_gn.py
+++ b/tools/gn/bin/roll_gn.py
@@ -155,7 +155,7 @@
 
     print('Uploading CL to build GN at {#%s} - %s' %
           (self.new_gn_version, self.new_gn_commitish))
-    ret, out, err = self.Call('git cl upload -f')
+    ret, out, err = self.Call('git cl upload --rietveld -f')
     if ret:
       print('git-cl upload failed: %s' % out + err)
       return 1
@@ -314,7 +314,8 @@
 
     results = self.CheckBuild()
     if (len(results) < 3 or
-        not all(r['state'] == 'success' for r in results.values())):
+        not all(r['state'] == 'success' for r in results.values()) or
+        not all(r['sha1'] != '-' for r in results.values())):
       print("Roll isn't done or didn't succeed, exiting:")
       return 1
 
@@ -335,7 +336,7 @@
       desc_file.close()
       self.Call('git commit -a -F %s' % desc_file.name,
                 cwd=self.buildtools_dir)
-      self.Call('git-cl upload -f --send-mail',
+      self.Call('git-cl upload --rietveld -f --send-mail',
                 cwd=self.buildtools_dir)
     finally:
       os.remove(desc_file.name)
@@ -400,7 +401,7 @@
       desc_file.write(desc)
       desc_file.close()
       self.Call('git commit -a -F %s' % desc_file.name)
-      self.Call('git-cl upload -f --send-mail --use-commit-queue')
+      self.Call('git-cl upload --rietveld -f --send-mail --use-commit-queue')
     finally:
       os.remove(desc_file.name)