)]}'
{
  "commit": "ec4638eb60f72777e9d93f933678f173ab6846c2",
  "tree": "aa060b9f203869f2e255b999b43764337c3a3ae1",
  "parents": [
    "5c7d2dc4372a1bade2b877b8b76af6ec86b6722f"
  ],
  "author": {
    "name": "tmoniuszko",
    "email": "tmoniuszko@opera.com",
    "time": "Fri Feb 19 03:16:42 2016 -0800"
  },
  "committer": {
    "name": "Commit bot",
    "email": "commit-bot@chromium.org",
    "time": "Fri Feb 19 11:17:53 2016 +0000"
  },
  "message": "[GN] Don\u0027t rewrite files with the same contents\n\nReland of https://codereview.chromium.org/1656253003 with fix.\n\nReason for revert:\nNeed to revert this patch according https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues. This patch added a flaky test FilesystemUtils.WriteFileIfChanged.\n\n-----\n\nIt\u0027s a test flake:\n1) Try to find the patch that caused the flake. It should be recent (e.g. last day or two) in all likelihood.\n2) If successful with finding that patch, revert the patch. This is especially true if the flake is from a new test introduced in that patch.\n3) Close the bug.\n\n-----\n\nThe test has failed in the following builds:\n\nhttp://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/176911\nhttp://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/176911\nhttp://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/176735\nhttp://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/176715\nhttp://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/176715\nhttp://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/176561\nhttp://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/176462\nhttp://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/176375\n\n-----\n\nExample failure:\n\n[ RUN      ] FilesystemUtils.WriteFileIfChanged\n../../tools/gn/filesystem_utils_unittest.cc:610: Failure\nExpected: (last_modified) !\u003d (file_info.last_modified), actual: 2016-02-04 18:06:36.920 UTC vs 2016-02-04 18:06:36.920 UTC\n[  FAILED  ] FilesystemUtils.WriteFileIfChanged (3 ms)\n[315/315] FilesystemUtils.WriteFileIfChanged (3 ms)\nRetrying 1 test (retry #2)\n[ RUN      ] FilesystemUtils.WriteFileIfChanged\n../../tools/gn/filesystem_utils_unittest.cc:610: Failure\nExpected: (last_modified) !\u003d (file_info.last_modified), actual: 2016-02-04 18:06:36.936 UTC vs 2016-02-04 18:06:36.936 UTC\n[  FAILED  ] FilesystemUtils.WriteFileIfChanged (2 ms)\n[316/316] FilesystemUtils.WriteFileIfChanged (2 ms)\nRetrying 1 test (retry #3)\n[ RUN      ] FilesystemUtils.WriteFileIfChanged\n../../tools/gn/filesystem_utils_unittest.cc:610: Failure\nExpected: (last_modified) !\u003d (file_info.last_modified), actual: 2016-02-04 18:06:36.952 UTC vs 2016-02-04 18:06:36.952 UTC\n[  FAILED  ] FilesystemUtils.WriteFileIfChanged (2 ms)\n[317/317] FilesystemUtils.WriteFileIfChanged (2 ms)\n1 test failed:\n    FilesystemUtils.WriteFileIfChanged (../../tools/gn/filesystem_utils_unittest.cc:579)\n\n-----\n\nMore details in http://crbug.com/584548.\n\nOriginal issue\u0027s description:\n\u003e [GN] Don\u0027t rewrite files with the same contents\n\u003e\n\u003e BUG\u003d\n\u003e\n\u003e Committed: https://crrev.com/f8ea5cceefcedd4a01935d5ac4d2ba71e23ac13e\n\u003e Cr-Commit-Position: refs/heads/master@{#373544}\n\nBUG\u003d584548\n\nReview URL: https://codereview.chromium.org/1704383002\n\nCr-Original-Commit-Position: refs/heads/master@{#376430}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 36deb395534c77295db41cc5f3e6b9627fbc5aa8\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "5905cdb9f1ec73749a03e15428d5109542712b22",
      "old_mode": 33188,
      "old_path": "tools/gn/filesystem_utils.cc",
      "new_id": "2ceca81677dbc68d0e041271ea9702ec1c3302c0",
      "new_mode": 33188,
      "new_path": "tools/gn/filesystem_utils.cc"
    },
    {
      "type": "modify",
      "old_id": "f64c00d751918238d685d49ef0701beab88bf62e",
      "old_mode": 33188,
      "old_path": "tools/gn/filesystem_utils.h",
      "new_id": "aaa08babde9e306ff82a0aca6b459ff30e170ee8",
      "new_mode": 33188,
      "new_path": "tools/gn/filesystem_utils.h"
    },
    {
      "type": "modify",
      "old_id": "27ccab2ea4d0db453c217d1921db71729de58aac",
      "old_mode": 33188,
      "old_path": "tools/gn/filesystem_utils_unittest.cc",
      "new_id": "d5638900e2e204802df6acb9cac974cc87194fb6",
      "new_mode": 33188,
      "new_path": "tools/gn/filesystem_utils_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "91599755a37e239ec3a4a155a8c46fb7459eda6b",
      "old_mode": 33188,
      "old_path": "tools/gn/function_write_file.cc",
      "new_id": "feb1004c3f22d2ef668294e1d1c8d0d6ebf3133d",
      "new_mode": 33188,
      "new_path": "tools/gn/function_write_file.cc"
    },
    {
      "type": "modify",
      "old_id": "7d9c08afd65bdcb7741b52f8633ada63bfd56b79",
      "old_mode": 33188,
      "old_path": "tools/gn/ninja_target_writer.cc",
      "new_id": "9f19b2b0065321d12f74279d97dfbe492cf5ecc1",
      "new_mode": 33188,
      "new_path": "tools/gn/ninja_target_writer.cc"
    },
    {
      "type": "modify",
      "old_id": "44a3f11449fd1efdd5be48a5e36d95bdf779f997",
      "old_mode": 33188,
      "old_path": "tools/gn/visual_studio_writer.cc",
      "new_id": "dec083753f79052cdc6a8a0ef80a75cfacf5d739",
      "new_mode": 33188,
      "new_path": "tools/gn/visual_studio_writer.cc"
    }
  ]
}
