)]}'
{
  "commit": "ed7eff3762def20b4f96ab5a06d2334d49616ffc",
  "tree": "ead269236405031aafc3a5f16c8eb9e85b72669d",
  "parents": [
    "ce8f166ca2f755ddecd9711f915774055f67e388"
  ],
  "author": {
    "name": "Bruce Dawson",
    "email": "brucedawson@chromium.org",
    "time": "Fri May 18 20:05:49 2018 +0000"
  },
  "committer": {
    "name": "Commit Bot",
    "email": "commit-bot@chromium.org",
    "time": "Fri May 18 20:05:49 2018 +0000"
  },
  "message": "Reland \"Switch to VS 2017 15.7.1 with 10.0.17134.0 SDK\"\n\nThis is a reland of 5a7f3c442684be5eeb244b904bbfc8e6edaf6fda\n\ngoma now supports this compiler and the new warnings were dealt with.\n\nOriginal change\u0027s description:\n\u003e Switch to VS 2017 15.7.1 with 10.0.17134.0 SDK\n\u003e\n\u003e This change switches the VS 2017 package to use VS 2017 Update 7.1 while\n\u003e using the 10.0.17134.12 SDK. The new SDK is needed to support new HDR\n\u003e features, and to stop forcing external developers to install an old\n\u003e ([Spring] Creators Update) SDK. This change will also bring in a new\n\u003e linker and other build tools, but the version of clang-cl will be\n\u003e unchanged.\n\u003e\n\u003e Packaging was done on a Windows Server 2016 VM, cleanly created for this\n\u003e purpose.\n\u003e\n\u003e Compiler was packaged up by downloading VS 2017 Update 7.1, from\n\u003e https://www.visualstudio.com/vs/, and then passing these parameters to\n\u003e the installer:\n\u003e\n\u003e     --add Microsoft.VisualStudio.Workload.NativeDesktop\n\u003e     --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended\n\u003e     --passive\n\u003e\n\u003e Then Add or Remove Programs was used to modify the 10.0.17134.0 SDK to add\n\u003e the Debuggers package.\n\u003e\n\u003e Then the packaging script was run like this:\n\u003e\n\u003e   python depot_tools\\win_toolchain\\package_from_installed.py 2017 -w 10.0.17134.0\n\u003e\n\u003e Bug: 773476\n\u003e Change-Id: Ic819f3ae79d7e869227bf33fbb8d202e2f57039b\n\u003e Reviewed-on: https://chromium-review.googlesource.com/1054027\n\u003e Reviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\n\u003e Reviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\n\u003e Commit-Queue: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\n\u003e Cr-Commit-Position: refs/heads/master@{#559033}\n\nBug: 773476,834213\nChange-Id: I903158f9dfa604f250010a7047496509f51782e7\nReviewed-on: https://chromium-review.googlesource.com/1066130\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@chromium.org\u003e\nCommit-Queue: Bruce Dawson \u003cbrucedawson@chromium.org\u003e\nCr-Original-Commit-Position: refs/heads/master@{#560002}\nCr-Mirrored-From: https://chromium.googlesource.com/chromium/src\nCr-Mirrored-Commit: 82a5f004e0e52897a6e8bac10490a14fc2845625",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "a8fe0416248b3d4f7d72cca76846c3c2ff5a46fd",
      "old_mode": 33188,
      "old_path": "tools/gn/visual_studio_writer.cc",
      "new_id": "856d54856b995ac203530ead9c931aaebe747758",
      "new_mode": 33188,
      "new_path": "tools/gn/visual_studio_writer.cc"
    },
    {
      "type": "modify",
      "old_id": "b924182b17b1db6ea23e505ff4663c602ba61ca3",
      "old_mode": 33188,
      "old_path": "tools/gn/visual_studio_writer_unittest.cc",
      "new_id": "bd9ab9616162d3870b4ee819b23cafde739ed57f",
      "new_mode": 33188,
      "new_path": "tools/gn/visual_studio_writer_unittest.cc"
    }
  ]
}