commit f79b47cf2846e3f3bef4c44a89ed771c41f2a44b
author tim <tim@rnc-ag.de> Tue Oct 11 21:40:40 2016 -0700
committer Commit bot <commit-bot@chromium.org> Wed Oct 12 04:42:21 2016 +0000
tree 18439be5649b3ff32c5436754d0ddc8f313b77ba
parent 1b775ab3a40426b96800cf02629dbb6f186221e6

GN: Fix flags writing for targets with unsupported PCHs

This fixes an issue that led to empty compiler flags being written
in the unusual case of a target with a PCH in conjunction with a toolchain
that doesn't support PCHs.

BUG=649899

Review-Url: https://codereview.chromium.org/2410253002
Cr-Original-Commit-Position: refs/heads/master@{#424669}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 52de7c17a1f9e4b3a2ed57d41afd131c0f4f8e69

tools/gn/ninja_binary_target_writer.cc

diff --git a/tools/gn/ninja_binary_target_writer.cc b/tools/gn/ninja_binary_target_writer.cc
index da46149..9772b85 100644
--- a/tools/gn/ninja_binary_target_writer.cc
+++ b/tools/gn/ninja_binary_target_writer.cc
@@ -480,6 +480,9 @@
         pch_file.erase(pch_file.length() - 4);
         out_ << " -include " << pch_file;
       }
+    } else {
+      RecursiveTargetConfigStringsToStream(target_, getter,
+                                           flag_escape_options, out_);
     }
   } else {
     RecursiveTargetConfigStringsToStream(target_, getter,