)]}' { "commit": "f898ccf7bb270a169d1de08e3e27cbc14b18814f", "tree": "8da060b1c8752198e676ac59fbee215e1219aaa0", "parents": [ "445ac323c164d6f0e72b36a94f600e2f50f577f3" ], "author": { "name": "Julie Hockett", "email": "juliehockett@google.com", "time": "Mon Jun 24 17:28:22 2019 -0700" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Jun 25 17:09:45 2019 +0000" }, "message": "Fix linking deps propagation\n\nRust libraries are not final from the perspective of anything depending\non them, but we do need to collect all the link lines of their\ntransitive dependencies in each, and so this removes RUST_LIBRARY from\nthe Target::IsFinal() function, but also adds in an if branch to collect\ndependent linking information in\nNinjaBinaryTargetWriter::ClassifyDependency().\n\nBug: crbug/gn/88\nChange-Id: I41dddb5fddbddb41a24b6bb3cd3a72fd0fb07159\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/5260\nReviewed-by: Brett Wilson \u003cbrettw@google.com\u003e\nCommit-Queue: Julie Hockett \u003cjuliehockett@google.com\u003e\n", "tree_diff": [ { "type": "modify", "old_id": "1c0cdd2a7bbd78b137d681dd0c39f3a1ac183ffd", "old_mode": 33188, "old_path": "tools/gn/ninja_binary_target_writer.cc", "new_id": "3cf7c48c6ccbbe952bf0fd883dad93ffd7c36956", "new_mode": 33188, "new_path": "tools/gn/ninja_binary_target_writer.cc" }, { "type": "modify", "old_id": "7c9cd6d23b4cff30ec35841099e343e5657b4f5d", "old_mode": 33188, "old_path": "tools/gn/target.cc", "new_id": "27dce258fec3e00edc05926b4aa51d9fba4d472c", "new_mode": 33188, "new_path": "tools/gn/target.cc" } ] }