tree 3620fbe607e1a3042937cf9281942752008def0c
parent 956d591f69eda7d5d422e1b9a04aef01641a8658
author Brett Wilson <brettw@chromium.org> 1521502569 +0000
committer Commit Bot <commit-bot@chromium.org> 1521502569 +0000

GN: Don't crash when mutating the list in a foreach.

Avoid a crash caused by mutation of the list being iterated over from inside
the foreach loop. This does a full copy of the the iterated list since the
code inside can't mutate the array via the loop variable anyway. Although
theoretically slower, this doesn't seem to have a measurable performance
regression in practice (we generally iterate over few large lists).

Adds documentation and tests for iteration while mutating the underlying list
variable.

Bug: 818525
Change-Id: I221fa230685b8998f5874154cad8d5c655b8006c
Reviewed-on: https://chromium-review.googlesource.com/959228
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: Roland McGrath <mcgrathr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#544209}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: dcba727e7e8b00cb26c4d797d956d48d2e98371f