)]}'
{
  "commit": "f9bd630375efb21f00e28f6671cc9ab257b0c85d",
  "tree": "63590ca3f1a1eeda26fc5d04d28dcf2550d33fc5",
  "parents": [
    "bdfd6086fe3ea30c6149c7097548a281969db0b9"
  ],
  "author": {
    "name": "David \u0027Digit\u0027 Turner",
    "email": "digit@google.com",
    "time": "Fri Nov 20 12:29:03 2020 +0100"
  },
  "committer": {
    "name": "Commit Bot",
    "email": "commit-bot@chromium.org",
    "time": "Fri Nov 20 18:18:53 2020 +0000"
  },
  "message": "Display toolchain name in dependency cycle error message.\n\nWhen a dependency cycle is detected, GN would print the cycle without\ntoolchain labels for each target, which can make the output confusing,\nmasking the real error. For example, consider something like:\n\n  //foo/bar --\u003e //foo/bar(//toolchain:zoo) --\u003e //foo/bar\n\nGN used to print:\n\n  ERROR: Dependency cycle:\n  //foo/bar -\u003e\n  //foo/bar -\u003e\n  //foo/bar\n\nWhich completely masked the issue. This patch forces the error message\nto include the label with the toolchain.\n\nChange-Id: If22fdfa6ecc0ac0a83115ad328fba61fa80e2abc\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/10720\nReviewed-by: David Turner \u003cdigit@google.com\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "9193eb6f9889a358cf908a2fced80d75fe24eb0d",
      "old_mode": 33188,
      "old_path": "src/gn/builder.cc",
      "new_id": "063493524a9beacafc6c9b65a887f6dd32ea6d1b",
      "new_mode": 33188,
      "new_path": "src/gn/builder.cc"
    }
  ]
}
