)]}'
{
  "commit": "fbe7aec770944d17c9f3006f6cbb5c19e8cd43ea",
  "tree": "7fc16806ac3728fe97e2c22a53c6d8527ac494fc",
  "parents": [
    "200492a501c6c78ebb9aef45e6f231ddfadfe231"
  ],
  "author": {
    "name": "Sylvain Defresne",
    "email": "sdefresne@chromium.org",
    "time": "Mon Jun 15 13:38:49 2020 +0000"
  },
  "committer": {
    "name": "Commit Bot",
    "email": "commit-bot@chromium.org",
    "time": "Mon Jun 15 13:47:12 2020 +0000"
  },
  "message": "Revert \"Divide sources between targets and add include paths to them\"\n\nThis reverts commit 382f5ef962f649b083344a31ecd6fe955fd1e146.\n\nReason for revert: causes some source files to be missing from the\ngenerated Xcode project. This makes developing on Chrome on iOS\ndifficult (as files are not found by indexing, nor search in files,\nit is not possible to put breakpoint in them, ...).\n\nOriginal change\u0027s description:\n\u003e Divide sources between targets and add include paths to them\n\u003e \n\u003e Autocomplete in Xcode not works if we have all sources in one target,\n\u003e at least in big projects.\n\u003e So we add a few types of targets: static and dynamic libraries, with\n\u003e  them, generated project better represent the internal structure of\n\u003e the project. Also, we do not add all sources to one target, we spread\n\u003e them between targets, where they should be.\n\u003e Also, we add include paths to targets.\n\u003e \n\u003e Change-Id: I3c81aaff5f62eff2d7a6ba1c1b14c62da6e26c27\n\u003e Reviewed-on: https://gn-review.googlesource.com/c/gn/+/8380\n\u003e Reviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n\u003e Commit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n\nBug: 173\nTBR\u003dscottmg@chromium.org,brettw@chromium.org,sdefresne@chromium.org,ihorkaravan96@gmail.com,boramaabak@gmail.com\n\n# Not skipping CQ checks because original CL landed \u003e 1 day ago.\n\nChange-Id: Ie76d211ac89eafae265a1cccb92378018cf84113\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/8980\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "d498271350183052a88d86e97174292557bbe099",
      "old_mode": 33188,
      "old_path": "src/gn/xcode_object.cc",
      "new_id": "471a201ac98f14bc79335aeba6b53020a831a5e5",
      "new_mode": 33188,
      "new_path": "src/gn/xcode_object.cc"
    },
    {
      "type": "modify",
      "old_id": "2b7f2d3bbbb91405be605e407eb8506384adee38",
      "old_mode": 33188,
      "old_path": "src/gn/xcode_object.h",
      "new_id": "78bdc92eaa54b5ab477c212b1943fa051ea6b0cf",
      "new_mode": 33188,
      "new_path": "src/gn/xcode_object.h"
    },
    {
      "type": "modify",
      "old_id": "1f77091a664ec00e2b89edfa92190ab8be469274",
      "old_mode": 33188,
      "old_path": "src/gn/xcode_object_unittest.cc",
      "new_id": "70a14dfe49cc3bab637c97e2e9f10baf838cb17f",
      "new_mode": 33188,
      "new_path": "src/gn/xcode_object_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "de8810d2fc29ff744f065d1a4bc735f07b496028",
      "old_mode": 33188,
      "old_path": "src/gn/xcode_writer.cc",
      "new_id": "206850f1ae29fd3a3ae521df33e38ab720a0b638",
      "new_mode": 33188,
      "new_path": "src/gn/xcode_writer.cc"
    }
  ]
}
