)]}'
{
  "commit": "fc8172f4a10793f234c1d2bd03ef608f6ff63d94",
  "tree": "eab319bfb33e8f5fbd5f94bfaefaa3122a4782b5",
  "parents": [
    "fdb90141934ab68962c9af785d5963ca378b3366"
  ],
  "author": {
    "name": "David \u0027Digit\u0027 Turner",
    "email": "digit@google.com",
    "time": "Mon Aug 12 16:23:02 2024 +0200"
  },
  "committer": {
    "name": "GN LUCI",
    "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Tue Aug 13 09:07:13 2024 +0000"
  },
  "message": "Properly verify runtime_outputs in rust tool definitions.\n\nEnsure that GN will complain when runtime_outputs is set\nin a Rust tool type that does not support it. Before this\nCL the value was read by the tool, and just ignored (without\nany warning about unused variables). This applied to rust_rlib\nand rust_staticlib which should not support this argument.\n\nThe CL at [1] was reverted, because it broke the Chromium build.\nThe root cause for this is that it removed runtime_outputs support\nfrom the rust_bin tool by mistake. Adding proper tests here\nshould prevent similar errors in the future.\n\n[1] https://gn-review.googlesource.com/c/gn/+/17401\n\n+ Improve the FunctionToolchain.RuntimeOutputs test case\n  to verify that all C++ and Rust link tools support\n  runtime_outputs properly, and that other tools will\n  error when it is specified.\n\nBug: 377\nChange-Id: If282807a325bf9ecaa57821a5563b8829687d6c0\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/17540\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "74cbef9f42ab0ba132514468d8b2982ad254785d",
      "old_mode": 33188,
      "old_path": "src/gn/function_toolchain_unittest.cc",
      "new_id": "bb9c3be3831dee2382c159fa8deb788a9094e225",
      "new_mode": 33188,
      "new_path": "src/gn/function_toolchain_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "f799d7363ff0c883818f8a6a10690855719f5bdf",
      "old_mode": 33188,
      "old_path": "src/gn/rust_tool.cc",
      "new_id": "7d357427dcc00141810c71aa140daba0f709169d",
      "new_mode": 33188,
      "new_path": "src/gn/rust_tool.cc"
    },
    {
      "type": "modify",
      "old_id": "857e205683f5c68f234a44f527aa5276d265f1bb",
      "old_mode": 33188,
      "old_path": "src/gn/rust_tool.h",
      "new_id": "4ceb2654fb95b0a29dc0eaa94fc1c3e993ee4e52",
      "new_mode": 33188,
      "new_path": "src/gn/rust_tool.h"
    }
  ]
}