)]}' { "log": [ { "commit": "93ee9b91423c1f1f53fb5f6cba7b8eef6247a564", "tree": "26f32b9a49b934c37f2bb6148068791d5dab1c30", "parents": [ "cfddfffb7913868936e76a269ae824aadd737b1b" ], "author": { "name": "Sylvain Defresne", "email": "sdefresne@chromium.org", "time": "Thu Mar 28 16:10:46 2024 +0000" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 28 18:00:18 2024 +0000" }, "message": "Revert \"[bundle] Use \"phony\" builtin tool for create_bundle targets\"\n\nThis reverts commit cfddfffb7913868936e76a269ae824aadd737b1b.\n\nReason for revert: this breaks the incremental build of certains\ntargets of Chromium (i.e. base_unittests for device when the gn\nvariable `enable_run_ios_unittests_with_xctest \u003d true`). This is\ndue to https://github.com/ninja-build/ninja/issues/2405 which is\nfixed in the development branch but not yet released.\n\nOriginal change\u0027s description:\n\u003e [bundle] Use \"phony\" builtin tool for create_bundle targets\n\u003e\n\u003e Instead of using the \"stamp\" tool which creates files (and potentially\n\u003e slow down the build since this requires access to the filesystem), use\n\u003e the builtin \"phony\" tool.\n\u003e\n\u003e Bug: 194\n\u003e Change-Id: Ie1af7020af4e7efc6c8848244c21dac549f179aa\n\u003e Reviewed-on: https://gn-review.googlesource.com/c/gn/+/16920\n\u003e Reviewed-by: David Turner \u003cdigit@google.com\u003e\n\u003e Commit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\n\n# Not skipping CQ checks because original CL landed \u003e 1 day ago.\n\nBug: 194\nChange-Id: Id14e5c08e2ca40f6b2fe40d3a526295786f83302\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16940\nReviewed-by: David Turner \u003cdigit@google.com\u003e\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\n" }, { "commit": "cfddfffb7913868936e76a269ae824aadd737b1b", "tree": "1ee44a7b74b3a78164b2e8ab26435df5725cb524", "parents": [ "06cdcc8e1fa8e56f70efb4357d473345b7d1c083" ], "author": { "name": "Sylvain Defresne", "email": "sdefresne@chromium.org", "time": "Thu Mar 21 16:36:36 2024 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Mar 25 14:05:56 2024 +0000" }, "message": "[bundle] Use \"phony\" builtin tool for create_bundle targets\n\nInstead of using the \"stamp\" tool which creates files (and potentially\nslow down the build since this requires access to the filesystem), use\nthe builtin \"phony\" tool.\n\nBug: 194\nChange-Id: Ie1af7020af4e7efc6c8848244c21dac549f179aa\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16920\nReviewed-by: David Turner \u003cdigit@google.com\u003e\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\n" }, { "commit": "06cdcc8e1fa8e56f70efb4357d473345b7d1c083", "tree": "26f32b9a49b934c37f2bb6148068791d5dab1c30", "parents": [ "22581fb46c0c0c9530caa67149ee4dd8811063cf" ], "author": { "name": "Sylvain Defresne", "email": "sdefresne@chromium.org", "time": "Thu Mar 21 13:48:59 2024 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 21 13:11:48 2024 +0000" }, "message": "[ios] Simplify handling of assets catalog\n\nIf the source files are listed as part of an assets catalog (i.e. one\nelement in the path ends with `.xcassets`), then consider the file as\npart of an assets catalog.\n\nWhen generating the Xcode project, if a file in part of an assets\ncatalog, only list the catalog, not the individual files (Xcode will\ndiscover the files).\n\nBug: none\nChange-Id: Ifaa940e51080ec05bda751a2028c6df2534866ec\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16900\nReviewed-by: David Turner \u003cdigit@google.com\u003e\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\n" }, { "commit": "22581fb46c0c0c9530caa67149ee4dd8811063cf", "tree": "28c42801b5b5f3eaaf76d7b50ca848c2ee1489e6", "parents": [ "59c4bb920542ee903ee1df39097ae024e2e8226f" ], "author": { "name": "Sylvain Defresne", "email": "sdefresne@chromium.org", "time": "Wed Mar 13 17:20:36 2024 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 14 10:51:16 2024 +0000" }, "message": "[swift] List all outputs as deps of \"source_set\" stamp file\n\nSince a swift target generates more than object files, and since\nsome of those outputs are input dependencies for other .swift\nfiles, explicitly list them as part of the \"source_set\" stamp\nfile dependencies.\n\nAlso change NinjaBinaryTargetWriter::AddSourceSetFiles() to use\nthe shared code from SwiftValues to compute the outputs instead\nof duplicating the effort (incorrectly).\n\nBug: none\nChange-Id: I6e6c9091aaa34369fda20ba3cbae37df88454374\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16880\nReviewed-by: David Turner \u003cdigit@google.com\u003e\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\n" }, { "commit": "59c4bb920542ee903ee1df39097ae024e2e8226f", "tree": "af17661637c17121dc47f85b6cc63c686dbec75b", "parents": [ "dd0927eb34bba823ec2bcea32079c091909881d2" ], "author": { "name": "Sylvain Defresne", "email": "sdefresne@chromium.org", "time": "Fri Mar 08 16:42:06 2024 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Mar 11 09:55:48 2024 +0000" }, "message": "[swift] Update `gn check ...` to consider the generated header\n\nThe compilation of a Swift module generates an Objective-C header\nto allow the interop between Swift and Objective-C. Update checker\nto consider this generated header as part of the source_set. This\nensure that missing deps on swift_source_set(...) targets will be\nreported by `gn check ...` in Chromium.\n\n This would prevent regressions caused by missing deps such\n as found and fixed by https://crrev.com/c/5348787.\n\nFixed: 361\nChange-Id: I5394097030e0b08d5ebda58066b16fe2a5bddebf\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16840\nReviewed-by: David Turner \u003cdigit@google.com\u003e\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "dd0927eb34bba823ec2bcea32079c091909881d2", "tree": "2363065b54464f7ee87b0bbb1f931aa9f1e5a8f7", "parents": [ "88e8054aff7bd0cb2295c7d9361d2be0b7355f27" ], "author": { "name": "Sylvain Defresne", "email": "sdefresne@chromium.org", "time": "Fri Mar 08 16:00:08 2024 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Mar 08 15:15:50 2024 +0000" }, "message": "[swift] Set `restat \u003d 1` to swift build rules\n\nThe swift compiler may leave output file untouched if they are\nidentical when performing an incremental build. This results\nin what should be \"no-op\" builds to be considered dirty.\n\nSet `restat \u003d 1` on the swift buidl rules to tell ninja that\nthe compiler perform this optimization and that it should stat\nthe outputs again and use the result to decide maybe prune the\nbuild graph.\n\nBug: 362\nChange-Id: I97d5096d1541d3f33c7378a7881214f11fece14d\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16860\nReviewed-by: David Turner \u003cdigit@google.com\u003e\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\n" }, { "commit": "88e8054aff7bd0cb2295c7d9361d2be0b7355f27", "tree": "95544090117ad1c4db71714a2a29e92d8f6dbd8b", "parents": [ "e05c0aa00938adc0797bda1e8f2c15675aa13c30" ], "author": { "name": "Milad Fa", "email": "mfarazma@redhat.com", "time": "Wed Feb 28 22:28:58 2024 -0500" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Feb 29 16:56:31 2024 +0000" }, "message": "Fix build with gcc12\n\nNeed to skip a bogus flag on gcc 12, reported here:\nhttps://gcc.gnu.org/bugzilla/show_bug.cgi?id\u003d104336\n\nChange-Id: I5b3fd530d20902247d4ea9b5285bf0a389e2fa45\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16820\nCommit-Queue: Brett Wilson \u003cbrettw@google.com\u003e\nReviewed-by: David Turner \u003cdigit@google.com\u003e\nReviewed-by: Brett Wilson \u003cbrettw@google.com\u003e\n" }, { "commit": "e05c0aa00938adc0797bda1e8f2c15675aa13c30", "tree": "3013634aab10c8cc58f033ca962f2457839919a3", "parents": [ "f19d5817e7ba85c2fda92e2697be11a4465d3267" ], "author": { "name": "Aaron Wood", "email": "aaronwood@google.com", "time": "Wed Feb 14 13:40:53 2024 -0800" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Feb 28 21:34:21 2024 +0000" }, "message": "[label_matches] Add new functions label_matches(), filter_labels_include() and filter_labels_exclude()\n\nAdd a new function \u0027label_matches(target_label, label_patterns)\u0027 that\ncan be used to test if a given GN label matches any of the given label\npatterns.\n\nAdd a new pair of functions:\n - \u0027filter_labels_include(labels, label_patterns)\u0027\n - \u0027filter_labels_exclude(labels, label_patterns)\u0027\n\nThese returns all labels in the first list that match (or don\u0027t match,\nrespectively) any of the patterns in the second list (much like the\n\u0027filter_include()\u0027 and \u0027filter_exclude()\u0027 functions do for files.\n\nChange-Id: I7670099dce41c3ff38219adf8fd740b6fb935e78\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16680\nReviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\nCommit-Queue: Aaron Wood \u003caaronwood@google.com\u003e\n" }, { "commit": "f19d5817e7ba85c2fda92e2697be11a4465d3267", "tree": "5359eb525ca09331806310f9cc5fb1052be64654", "parents": [ "6253a39dbc436d292e3567faa637c9d3302e1e5f" ], "author": { "name": "Sylvain Defresne", "email": "sdefresne@chromium.org", "time": "Tue Feb 27 16:52:14 2024 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Feb 27 16:09:28 2024 +0000" }, "message": "[swift] Remove problematic use of \"stamp\" tool\n\nRecent versions of ninja supports listing multiple outputs for the\nsame build command, so remove a problematic \"stamp\" tool (caused\nincremental build issues).\n\nPreviously, the ninja file for a swift source_set would look like:\n\n build output0: swift input0 input1 ...\n build output1 output2 ...: stamp output0\n\nWith this change, it becomes the following:\n\n build output0 output1 output2 ...: swift input0 input1 ...\n\nThis removes unnecessary target, and ensure that building any of\noutput$n will result in launching the swift command instead of\ncreating empty files if the output0 already exists.\n\nBug: none\nChange-Id: Ibbe2433a87de0ca86a628d6120c9e004780818c3\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16800\nReviewed-by: David Turner \u003cdigit@google.com\u003e\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\n" }, { "commit": "6253a39dbc436d292e3567faa637c9d3302e1e5f", "tree": "334c5a22c18321c5e4fb6e6cda31dae76d72d5ad", "parents": [ "5787e994aa4cb6cdb09c2c72ae6f1c6a7f1cf91a" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Tue Feb 20 19:55:35 2024 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Feb 27 12:52:26 2024 +0000" }, "message": "Implement new --ninja-outputs-file option.\n\nThe CL adds a new option to the `gen` command to\nwrite a file listing all Ninja output paths that\nappear in the generated build plan for any GN target\nin the graph.\n\nThis can be used by GN clients to quickly convert between\nGN labels and Ninja target paths. In particular, the Fuchsia\nteam will use this to improve developer workflows, by allowing\nthe `fx build` command to support GN labels directly.\n\nThe generated output includes all Ninja paths, including stamp\nfiles for completeness. It can be processed by an external\ntool, for example to convert it into a more efficient binary\nformat.\n\nOn a large Fuchsia build plan, this adds about 400ms\nof generation time, on top of a total of 13s. Which is\ndrastically faster than generating a project.json file\n(which is also significantly larger, and doesn\u0027t contain\nall Ninja outputs).\n\nChange-Id: I78318809f4000416689857ec4c676975ddb18061\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16000\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\n" }, { "commit": "5787e994aa4cb6cdb09c2c72ae6f1c6a7f1cf91a", "tree": "37dfcee1428f6da29d5b9e527e981a7fc9b2b2d3", "parents": [ "03d10f1657b4ddace618c34ab61b6357d1ae9c9a" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Tue Feb 20 19:53:46 2024 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Feb 26 11:53:17 2024 +0000" }, "message": "Add NinjaOutputsWriter class\n\nImplement a new class that can be used to generate a JSON\nfile containing an object mapping GN label strings to\nlist of corresponding Ninja output paths (including stamp\nfiles).\n\nThis will be used to implement a new `gn gen` option.\nThe output can be used by GN clients to quickly convert\nbetween GN labels and Ninja targets.\n\nThis is done through the following changes:\n\n- NinjaTargetWriter gets new methods to write output\n files to the build plan, and record the\n corresponding OutputFile values (without Ninja\n escaping) separately if needed.\n\n- All NinjaTargetWriter sub-classes are updated to\n call WriteOutput() or WriteOutputs() when adding\n Ninja output paths to the generated .ninja_files, instead\n of calling path_outputs_.WriteFile() directly.\n\nChange-Id: Id6b1cc667e7bec56d37ededb75475fbc480eccaf\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16761\nReviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\n" }, { "commit": "03d10f1657b4ddace618c34ab61b6357d1ae9c9a", "tree": "eed81122c7024349afc5d2f8c33ef570c2ff0d9e", "parents": [ "0cdb7dd27f5cbafb31704a5d849efe17ef2a0acc" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Tue Feb 20 19:51:35 2024 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Feb 21 09:33:01 2024 +0000" }, "message": "Move InvokePython() function to its own source file.\n\nThis makes the function usable from other source files,\nas used in a future CL that will add a new type of file\nwriter.\n\nThe new function is placed in the `internal` namespace\nto be consistent with `internal::ExecProcess()` which\nplays a similar role.\n\nChange-Id: I246122d43cb9bdb88ae3392679716430f8e62f3a\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16760\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "0cdb7dd27f5cbafb31704a5d849efe17ef2a0acc", "tree": "c654a9b681b5315a3e727ca36899c1b6b4357da7", "parents": [ "d4f94f9a6c25497b2ce0356bb99a8d202c8c1d32" ], "author": { "name": "Gaby Baghdadi", "email": "baghdadi@ca.ibm.com", "time": "Mon Nov 27 10:04:55 2023 -0500" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Feb 21 05:09:27 2024 +0000" }, "message": "zos: build with -DZOSLIB_OVERRIDE_CLIB to override creat\n\nThe overridden creat() in zoslib, enabled by the subject macro, creates\na file as ISO8859-1 and tags it as text, so user no longer has to chtag\nthe generated build files manually, as was previously instructed in the\ninitial z/OS port (commit 45aa842fb4). Note: the macro also overrides\nother C runtime library functions (e.g. open, fopen, pipe, etc.), but\nthese continue to function correctly.\n\nThe only file that will still be tagged as mixed binary and text (at\nleast in V8\u0027s gn-generated files) is toolchain.ninja (m ISO8859-1\ninstead of t ISO8859-1), because of the std::ios_base::binary in\nNinjaToolchainWriter::RunAndWriteFile\u0027s std::ofstream open(). However,\nzopen\u0027s vim, grep and ninja can still read it fine.\n\nzoslib: https://github.com/ibmruntimes/zoslib\nzopen: https://github.com/ZOSOpenTools/\n\nChange-Id: Iaf3d8e7f622bdf7d9de5db4b92380ddf93ae9155\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16280\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\nReviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "d4f94f9a6c25497b2ce0356bb99a8d202c8c1d32", "tree": "79ccb5a86ebcd76116240e3933b468771a9f5746", "parents": [ "0a2b8eac80f164f10b2cbc126890db0d295790cd" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Fri Feb 16 11:40:37 2024 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Feb 19 09:15:20 2024 +0000" }, "message": "Enable C++ runtime assertions in debug mode.\n\nEnabling these runtime assertions should prevent\nbugs like the one introduced in [1], which went\nunnoticed, and had to be fixed in [2].\n\nThis should work on non-Windows platforms when using\nlibstdc++ or libc++.\n\nThis is also disabled on MacOS due to linking errors\nwith the system-installed XCode on Catalina. E.g.:\n\n```\n/opt/s/w/ir/x/w/cipd/bin/clang++ --target\u003dx86_64-apple-darwin --sysroot\u003d/opt/s/w/ir/cache/macos_sdk/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk -mmacosx-version-min\u003d10.9 -pthread -o gn src/gn/gn_main.o base.a gn_lib.a\nld64.lld: error: undefined symbol: std::__1::__libcpp_debug_function\n```\n\n(where __libcpp_debug_function is supposed to be provided by libc++\nand is the function called in case of runtime assertion failure). Looking\nfor clues on your favorite search engine does not provide any answer\nto the issue :-(\n\n+ Fix compiler warnings with GCC 13 in json_project_writer.cc.\n In debug mode, the compiler complains that with a warning that\n doesn\u0027t really make sense, but which can be work-around by\n using assign() instead of clear() + insert() on a vector.\n\n The error looks like:\n\n ```\n /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/debug/functions.h:110:44: error: no matching function for call to \u0027__addressof\u0027\n return __foreign_iterator_aux4(__it, std::__addressof(*__other));\n ...\n ../src/gn/json_project_writer.cc:74:14: note: in instantiation of function template specialization \u0027std::vector\u003cconst Target *\u003e::insert\u003cPointerSet\u003cconst Target\u003e::const_iter\nator, void\u003e\u0027 requested here\n targets-\u003einsert(targets-\u003eend(), target_set.begin(), target_set.end());\n ^\n /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/move.h:51:5: note: candidate function [with _Tp \u003d const Target *] not viable: expects an lvalue for\n 1st argument\n __addressof(_Tp\u0026 __r) _GLIBCXX_NOEXCEPT\n ```\n\n[1] https://gn-review.googlesource.com/c/gn/+/16620\n[2] https://gn-review.googlesource.com/c/gn/+/16700\n\nChange-Id: I71cad8103b221145db75e639a6237f006c8fa37a\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16740\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "0a2b8eac80f164f10b2cbc126890db0d295790cd", "tree": "dde549a5d075648875a35577c8468de7db4b1086", "parents": [ "8b973aa51d02aa1ab327100007d4070c24b862b0" ], "author": { "name": "Reito", "email": "carolwolfking@gmail.com", "time": "Fri Feb 16 13:50:29 2024 +0800" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Feb 16 09:54:21 2024 +0000" }, "message": "Fix regression in MakeRelativePath()\n\nThe logic in the function only works correctly when the\n`input` and `dest` arguments are zero-terminated strings.\nChanging them to std::string_view in a previous CL broke\nthis assumption, resulting in buffer overflows, runtime\nerrors with stdlib++ assertions turned on.\n\nFixed: 358\nChange-Id: Idfb52ffcbc38943ca5c8d231fae2fd0c50f20fd3\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16700\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\nReviewed-by: David Turner \u003cdigit@google.com\u003e\n" }, { "commit": "8b973aa51d02aa1ab327100007d4070c24b862b0", "tree": "6716b00e81e5ce2f1acbacd960c9678b0a0d4be8", "parents": [ "a3dcd7a7ad861a9c1b9930a654f2feaeb03b4c0c" ], "author": { "name": "Reito", "email": "carolwolfking@gmail.com", "time": "Tue Feb 13 22:37:02 2024 +0800" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Feb 15 10:50:43 2024 +0000" }, "message": "fix: Fix Windows MakeRelativePath.\n\nOn Windows, it is invalid to make a relative path span across different drives. This fix:\n1. Instead of prepending slash, we remove slash for both paths if there\u0027s one.\n2. Return input\u0027s absolute path if the drive letter is different between input and dest.\n\nFixes: https://bugs.chromium.org/p/gn/issues/detail?id\u003d317\nChange-Id: I3ee2a46d412f663b0739f95fe3683d892b8fe6b5\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16620\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\nReviewed-by: David Turner \u003cdigit@google.com\u003e\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\n" }, { "commit": "a3dcd7a7ad861a9c1b9930a654f2feaeb03b4c0c", "tree": "899767a4246050c27784bab30931bc1ed3d65d3c", "parents": [ "a2e2717ea670249a34b0de4b3e54f268d320bdfa" ], "author": { "name": "Reito", "email": "carolwolfking@gmail.com", "time": "Wed Feb 14 16:47:31 2024 +0800" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Feb 14 09:27:02 2024 +0000" }, "message": "Add long path support for windows\n\nChange-Id: I84a25207a08e8590288855c757b0241c4a8a9fed\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16600\nReviewed-by: David Turner \u003cdigit@google.com\u003e\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "a2e2717ea670249a34b0de4b3e54f268d320bdfa", "tree": "c4186c67196c02f69351498662cedb2551ac5090", "parents": [ "fc722252439ea3576c241773f5ee14eb8470e2ef" ], "author": { "name": "Andrew Grieve", "email": "agrieve@google.com", "time": "Wed Jan 24 14:02:39 2024 -0500" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Jan 26 21:37:42 2024 +0000" }, "message": "Ensure read_file() files are considered by \"gn analyze\"\n\nJust like imports, these files need to be added as build file\ndependencies.\n\nFound this from a chromium CL where analyze missed that a .info file,\nread via read_file(), was changed.\n\nTested locally that this now results in a changed target:\n\n{\n \"files\": [ \"//third_party/android_deps/libs/android_arch_lifecycle_viewmodel/android_arch_lifecycle_viewmodel.info\" ],\n \"additional_compile_targets\": [],\n \"test_targets\": [ \"//chrome/android:chrome_public_test_apk\" ]\n}\n\nBug: None\nChange-Id: Ifaca46ff87d43f4d45123cbdb67162298d6919f8\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16580\nReviewed-by: Brett Wilson \u003cbrettw@google.com\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@google.com\u003e\n" }, { "commit": "fc722252439ea3576c241773f5ee14eb8470e2ef", "tree": "b682482209dc620afd63299f9d0d6f4d693e2b35", "parents": [ "5110a7f03e86c6077516f62bd5b77a9a672ebfa6" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@google.com", "time": "Wed Jan 24 14:49:20 2024 +0900" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jan 24 08:29:51 2024 +0000" }, "message": "apply 2to3 to for some Python scripts\n\nChange-Id: I8a8fc9814c3e714bd949480ce0f1d0902554d194\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16560\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "5110a7f03e86c6077516f62bd5b77a9a672ebfa6", "tree": "b324a5f7196f033f2be36657f9a8bc6c739fcf67", "parents": [ "f99e015ac35f689cfdbf46e4eb174e5d2da78d8e" ], "author": { "name": "Max Ihlenfeldt", "email": "max@igalia.com", "time": "Mon Jan 22 11:56:47 2024 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Jan 23 02:56:59 2024 +0000" }, "message": "Add rustflags to desc and help output\n\n`gn desc` doesn\u0027t list a target\u0027s / config\u0027s rustflags, even though\nTargetDescBuilder already has support for it.\n\nThis CL adds rustflags support to ConfigDescBuilder as well, and makes\nthe desc command print them. While we\u0027re already at it, it also adds it\nto the help command\u0027s output.\n\nBug: None\nChange-Id: Iba66a7011b885be914b959aeafbc4d34fba0b080\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16520\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@google.com\u003e\nReviewed-by: David Turner \u003cdigit@google.com\u003e\n" }, { "commit": "f99e015ac35f689cfdbf46e4eb174e5d2da78d8e", "tree": "466c0890376f1840ef0bf2149c94fa7cc3b02f23", "parents": [ "b5adfe5f574d7110b80feb9aae6fae97c366840b" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@google.com", "time": "Mon Jan 22 18:17:18 2024 +0900" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Jan 22 09:47:51 2024 +0000" }, "message": "strings: support case insensitive check only in StartsWith/EndsWith\n\nstd::string and std::string_view have starts_with and ends_with for\ncase senstive check.\n\nChange-Id: I53d84d27b18443b89a000bd9c4af5c4e605b8d80\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16540\nCommit-Queue: Takuto Ikuta \u003ctikuta@google.com\u003e\nReviewed-by: David Turner \u003cdigit@google.com\u003e\n" }, { "commit": "b5adfe5f574d7110b80feb9aae6fae97c366840b", "tree": "bf4024944a95a5b4a91ead6fefb6e72c8c57ce06", "parents": [ "d6085ac6a95b47b73b533047c739851ea0353789" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@google.com", "time": "Wed Jan 17 17:51:52 2024 +0900" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jan 17 09:07:24 2024 +0000" }, "message": "add .git-blame-ignore-revs\n\nThis is for https://gn-review.git.corp.google.com/c/gn/+/16440.\n\nChange-Id: I5fe731ce9c06cca6966ffdf77cc275826e292391\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16500\nCommit-Queue: Takuto Ikuta \u003ctikuta@google.com\u003e\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\n" }, { "commit": "d6085ac6a95b47b73b533047c739851ea0353789", "tree": "aa7e0e41c77d304a727ffcc729d80b871ecf69e8", "parents": [ "8bd36a27c0764c869d40ac4102a24720b781b389" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@google.com", "time": "Wed Jan 17 17:50:33 2024 +0900" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jan 17 09:04:36 2024 +0000" }, "message": "use std::{string,string_view}::{starts_with,ends_with}\n\nThis is generated by\n```\ncomby -i \u0027base::StartsWith(:[a], :[b], base::CompareCase::SENSITIVE)\u0027 \u0027:[a].starts_with(:[b])\u0027 $(rg -l \u0027::SENSITIVE\u0027)\ncomby -i \u0027base::EndsWith(:[a], :[b], base::CompareCase::SENSITIVE)\u0027 \u0027:[a].ends_with(:[b])\u0027 $(rg -l \u0027::SENSITIVE\u0027)\nCHROMIUM_BUILDTOOLS_PATH\u003d~/chromium/src/buildtools git cl format --full\n```\n\nChange-Id: I38d8266365538010790704e3f9ba9add98069565\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16480\nReviewed-by: David Turner \u003cdigit@google.com\u003e\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "8bd36a27c0764c869d40ac4102a24720b781b389", "tree": "b366f22b6d2926963b22562477b8512034320c1b", "parents": [ "5d76868385b81d6c4fb3256240a2ce449c37b5ee" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@google.com", "time": "Wed Jan 17 17:34:00 2024 +0900" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jan 17 08:48:53 2024 +0000" }, "message": "apply clang-format to all C++ sources\n\nThis is to prevent unrelated diff when applying clang-format in\nfollowing CLs.\n\nGenerated by\n$ tools/run_formatter.sh\n\nI\u0027ll add .git-blame-ignore-revs after submitting this.\n\nChange-Id: If8d82dd952d11c283752fc7afce634a04088f476\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16440\nReviewed-by: Brett Wilson \u003cbrettw@google.com\u003e\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@google.com\u003e\nReviewed-by: David Turner \u003cdigit@google.com\u003e\n" }, { "commit": "5d76868385b81d6c4fb3256240a2ce449c37b5ee", "tree": "726542adcf47e294fd7bffc8030f79f605b56a75", "parents": [ "b8562a4abd9528372f274b1155aec65c57ca84fa" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@google.com", "time": "Tue Jan 16 11:17:42 2024 +0900" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Jan 16 10:35:45 2024 +0000" }, "message": "add forward declaration in rust_values.h\n\nTarget class is referenced, but header is not included.\nThis is to fix\nhttp://ci.chromium.org/b/8758787771688889681\nfor\nhttps://gn-review.git.corp.google.com/c/gn/+/16440/2\n\nChange-Id: I0b516a4c8d8cb845951acc77b03664f11f91a8d1\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16460\nReviewed-by: David Turner \u003cdigit@google.com\u003e\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\n" }, { "commit": "b8562a4abd9528372f274b1155aec65c57ca84fa", "tree": "014b8a3914f8c587eb121ba9ac67bf9ac30c5c59", "parents": [ "5fd939de8a66c915778c14a2788a857be858ef6c" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Mon Oct 23 18:05:37 2023 +0200" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Jan 15 09:27:41 2024 +0000" }, "message": "Add `root_patterns` list to build configuration.\n\nThis CL adds a new optional `root_patterns` argument in\nthe top-level `.gn` file, as well as corresponding\n`--root-pattern\u003dPATTERN` command-line arguments.\n\nThis can be used to restrict the list of targets that\nare added to the build graph when BUILD.gn files are evaluated\nin the default toolchain.\n\nThe default behavior, is to add all targets defined in\nthe BUILD.gn files that are evaluated in the default toolchain,\nincluding all their transitive dependencies.\n\nWhen a non-empty list of patterns is used, these will be used\nto filter the targets by their label, in the default toolchain\n(it is thus an error to specify a toolchain suffix in these\npatterns).\n\nFor example, on a complex Fuchsia build plan, using\n`gn gen out/default --root-target\u003d//:*` changes `gn gen`\ntime from 18s to 6s, reducing the generated Ninja file\ncount from 21907 to 8376 files, which reduces the Ninja\nstartup time by ... seconds.\n\nChange-Id: Ic727b64e8d899d0dd88113576c1c8ae6e035d326\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16060\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "5fd939de8a66c915778c14a2788a857be858ef6c", "tree": "54f03a14d0116efb08eb76855cc425a88bbfd6fe", "parents": [ "d4be45bb28fbfc16a41a1e02c86137df6815f2dd" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@google.com", "time": "Fri Jan 12 16:13:04 2024 +0900" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Jan 12 11:30:31 2024 +0000" }, "message": "Use c++20 in GN build\n\nChange-Id: I45d6b140f68e7e0bdd885420952e46e2576e960d\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16200\nReviewed-by: David Turner \u003cdigit@google.com\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "d4be45bb28fbfc16a41a1e02c86137df6815f2dd", "tree": "0216a60e62a35c1bfc09d532c1af16fbcf869e01", "parents": [ "71305b07d708830ed7b96006dfa773a79ff313fe" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@google.com", "time": "Thu Jan 11 18:18:10 2024 +0900" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jan 11 20:24:46 2024 +0000" }, "message": "update windows sdk to 2024-01-11\n\nI uploaded the latest chromium toolchain to CIPD by following\nhttp://go/windows-sdk-cipd-update\n\nTested in\nhttps://ci.chromium.org/swarming/task/6710a273104d1e10?server\u003dchromium-swarm.appspot.com\n\nChange-Id: I44df60f27e4a1de134dc89041341171345f296a2\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16401\nReviewed-by: David Turner \u003cdigit@google.com\u003e\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\n" }, { "commit": "71305b07d708830ed7b96006dfa773a79ff313fe", "tree": "ef7b8c0227fabf0d5a6f5d316c71ce75bb1a1412", "parents": [ "85944ebc24a90ec1e489e85a46fdc68542c3146f" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@google.com", "time": "Thu Jan 11 16:39:21 2024 +0900" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jan 11 08:05:21 2024 +0000" }, "message": "update windows sdk\n\nTested in\nhttps://ci.chromium.org/swarming/task/671047ef2f491910?server\u003dchromium-swarm.appspot.com\n\nChange-Id: I85a6a9f307d62ebc5b84aabc7fb47d4b60f8fa04\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16400\nReviewed-by: David Turner \u003cdigit@google.com\u003e\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\n" }, { "commit": "85944ebc24a90ec1e489e85a46fdc68542c3146f", "tree": "f88d489e7231a2997d7451835e2f528381f4a601", "parents": [ "7367b0df0a0aa25440303998d54045bda73935a5" ], "author": { "name": "Ryan Macnak", "email": "rmacnak@google.com", "time": "Fri Dec 08 12:18:12 2023 -0800" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Dec 13 07:01:31 2023 +0000" }, "message": "Add linux-riscv64.\n\nBug: https://bugs.chromium.org/p/chromium/issues/detail?id\u003d1138584\nBug: https://github.com/dart-lang/sdk/issues/48545\nChange-Id: I8a5091e95a3c92e2ac0e136b4413b4f79656889b\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16300\nCommit-Queue: Petr Hosek \u003cphosek@google.com\u003e\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\n" }, { "commit": "7367b0df0a0aa25440303998d54045bda73935a5", "tree": "e68909a69bc13f09b854b1ab6e906a30ac6062f8", "parents": [ "92e63272dc04ee7cc1eaae2633c25da06e4f9c03" ], "author": { "name": "Dirk Pranke", "email": "dpranke@google.com", "time": "Fri Nov 17 14:44:47 2023 -0800" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Nov 28 00:17:26 2023 +0000" }, "message": "Update OWNERS list.\n\nAdd dpranke@ back into OWNERS list.\nAdd digit@.\nAdd brettw@google.com.\nRemove scottmg@.\n\nChange-Id: I4bfb4417a33597c52cd6e40bf038a8af7966fa86\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16220\nCommit-Queue: Dirk Pranke \u003cdpranke@google.com\u003e\nReviewed-by: David Turner \u003cdigit@google.com\u003e\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\n" }, { "commit": "92e63272dc04ee7cc1eaae2633c25da06e4f9c03", "tree": "093362a60e17bd3113ce9763fac9355262d6ab7c", "parents": [ "c7b223bfb225ce87a72a244d016ffdfcf227fa5e" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@google.com", "time": "Tue Nov 21 17:44:35 2023 +0900" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Nov 21 09:39:01 2023 +0000" }, "message": "remove unused function\n\nChange-Id: I33472f3318dc10292366bd2db9438f560eb8153b\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16260\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "c7b223bfb225ce87a72a244d016ffdfcf227fa5e", "tree": "9d6b4215af13e75ff8a987524571d85129d17960", "parents": [ "bc5744174d9ea1c292f3f08cfb95fa97ea5c595e" ], "author": { "name": "Ricardo Ribalda", "email": "ribalda@google.com", "time": "Mon Nov 13 10:54:45 2023 +0000" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Nov 20 03:51:22 2023 +0000" }, "message": "Ignore build warning -Werror\u003dredundant-move\n\ngcc-13 complains with:\nerror: redundant move in return statement [-Werror\u003dredundant-move]\n\nWe cannot fix the code, because both old versions of gcc and the windows\ntoolchain fails to build.\n\nChange-Id: Iab62336fa37db8fab0dc8acabad0fabfabada0f9\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16140\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@google.com\u003e\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\n" }, { "commit": "bc5744174d9ea1c292f3f08cfb95fa97ea5c595e", "tree": "789104e24ab02e35eeb08bb8b2d3122857612f24", "parents": [ "9a45b61238317b09b778c47555527c9926700e0c" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Thu Nov 09 11:45:39 2023 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Nov 15 08:02:30 2023 +0000" }, "message": "Fix --as\u003dbuildfile `gn desc deps` output.\n\nBefore this CL, `--as\u003dbuildfile` would report the location\nof the parse tree node used to instantiate a Target, in practice\nthis meant that:\n\n- For builtin target types like `action()` or `static_library()`,\n this would be the location of the BUILD.gn where these are called.\n\n- For targets defined through templates (e.g. `java_library()`\n in Chromium), this would be the location of the .gni file where\n the underlying action() was invoked.\n\nThis CL ensures that the location of the BUILD.gn where the target\nis defined is always returned. It does so by looking at the\nbuild_dependency_files() set for the target, and extracting\nthe single BUILD.gn file location from it, falling back to\nBUILDCONFIG.gn for targets that may be defined there instead.\n\nNOTE: There is no unit-test because PrintAndFilterTargets()\nrelies on too much global state, including the command-line.\nWriting a proper test would require a non-trivial refactor\nof that code.\n\nManual testing can be done by comparing the outputs of:\n\n```\ngn desc . //base:base_java deps --all --as\u003dbuildfile\n```\n\nBefore and after this CL.\n\nBug: chromium:1500273\nChange-Id: I4393e98d21c56c86282a886cb595034c389cc31c\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16100\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\n" }, { "commit": "9a45b61238317b09b778c47555527c9926700e0c", "tree": "612ab1c296e56d75d8228fe8ea8e1831f243de16", "parents": [ "85bd0a62938bc84e1b8db0ef92be0e2bb634378d" ], "author": { "name": "Dirk Pranke", "email": "dpranke@google.com", "time": "Tue Nov 14 15:15:39 2023 -0800" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Nov 14 23:53:56 2023 +0000" }, "message": "Update recipe engine to 9dea1246.\n\nThis picks up almost a year\u0027s worth of recipe changes and\nhopefully will address bot breakages like\nhttps://ci.chromium.org/ui/p/gn/builders/try/linux/b8764425375414840977/overview\n\nNo-Try: true\nNo-Presubmit: true\nChange-Id: Ia86999f6dc8910b5f97dfddcd8f84303b767cd73\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16160\nCommit-Queue: Dirk Pranke \u003cdpranke@google.com\u003e\nReviewed-by: David Turner \u003cdigit@google.com\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nReviewed-by: Brett Wilson \u003cbrettw@google.com\u003e\n" }, { "commit": "85bd0a62938bc84e1b8db0ef92be0e2bb634378d", "tree": "c81d9c951f39c2535f34204c46bf9dcf20e1aa28", "parents": [ "e4702d7409069c4f12d45ea7b7f0890717ca3f4b" ], "author": { "name": "Ricardo Ribalda", "email": "ribalda@google.com", "time": "Sat Nov 11 16:30:19 2023 +0000" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Nov 13 05:27:27 2023 +0000" }, "message": "treewide: Fix spelling mistakes\n\ns/critera/criteria/\ns/ommitted/omitted/\ns/succesful/successful/\n\nChange-Id: Iab62336fa37db8fab0dc84affa2cfabfabfabada\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16120\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "e4702d7409069c4f12d45ea7b7f0890717ca3f4b", "tree": "7b73df6bad215175ed7d29320d91578c48c376ad", "parents": [ "5d8727f3fbf420538ff753ebc3ce96da28e12c22" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Fri Oct 20 14:28:50 2023 +0200" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Oct 23 08:20:06 2023 +0000" }, "message": "Optimize base::EscapeJSONString for ASCII inputs.\n\nMost of the strings passed to this function are ASCII-only and\ndon\u0027t even need escaping. This CL provides fast-paths for these\ncases.\n\nThis speeds up the generation of many JSON files written by GN.\nFor example, on a large Fuchsia build plan, this saves about 4\nseconds while generating identical JSON outputs:\n\n```\n$ hyperfine --runs\u003d5 \u0027/tmp/gn1 gen --ide\u003djson out/default --export-rust-project --export-compile-commands\u0027 \u0027/tmp/gn3 gen --ide\u003djson out/default --export-rust-project --export-compile-commands\u0027\nBenchmark 1: /tmp/gn1 gen --ide\u003djson out/default --export-rust-project --export-compile-commands\n Time (mean ± σ): 28.883 s ± 0.836 s [User: 117.852 s, System: 42.476 s]\n Range (min … max): 27.694 s … 29.916 s 5 runs\n\nBenchmark 2: /tmp/gn2 gen --ide\u003djson out/default --export-rust-project --export-compile-commands\n Time (mean ± σ): 24.829 s ± 0.590 s [User: 112.068 s, System: 42.400 s]\n Range (min … max): 23.879 s … 25.296 s 5 runs\n\nSummary\n \u0027/tmp/gn3 gen --ide\u003djson out/default --export-rust-project --export-compile-commands\u0027 ran\n 1.16 ± 0.04 times faster than \u0027/tmp/gn1 gen --ide\u003djson out/default --export-rust-project --export-compile-commands\u0027\n```\n\nChange-Id: I7f678f898a9e7f1d271ef8cb47ea77bb6d22800c\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16040\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "5d8727f3fbf420538ff753ebc3ce96da28e12c22", "tree": "b1459748d37d933d74f4410bd8f6b8548f2faea5", "parents": [ "182a6eb05d15cc76d2302f7928fdb4f645d52c53" ], "author": { "name": "Aaron Massey", "email": "aaronmassey@google.com", "time": "Thu Oct 19 09:42:37 2023 -0600" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Oct 20 09:45:55 2023 +0000" }, "message": "[docs]: Mention implicit names in style guide\n\nThe gn reference explicitly states that part of the preferred style for\nadding deps is to omit the colon when possible. However, this is not\nmentioned in the style guide where one would usually go searching for\nthis information.\n\nMention a preference to omit colons from deps when possible in the deps\nportion of the gn style guide.\n\nBug: none\nChange-Id: Ia4fc02ea47ff9a9d21268dcc6a8e977b4cb500d3\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/16020\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\n" }, { "commit": "182a6eb05d15cc76d2302f7928fdb4f645d52c53", "tree": "fc22fafa30d8577fedec857cbdc9509b2ec2372d", "parents": [ "991530ce394efb58fcd848195469022fa17ae126" ], "author": { "name": "Andrew Savage", "email": "andrewsavage@google.com", "time": "Tue Oct 10 22:39:14 2023 +0000" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Oct 11 16:39:12 2023 +0000" }, "message": "Use magenta for warnings\n\nChange-Id: I6a7433d522eb9c165c868f943a3a75a437411634\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15960\nCommit-Queue: Brett Wilson \u003cbrettw@google.com\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nReviewed-by: Brett Wilson \u003cbrettw@google.com\u003e\n" }, { "commit": "991530ce394efb58fcd848195469022fa17ae126", "tree": "6dd0331ffdb6364111f9b350ce4afb08e99383f4", "parents": [ "c1fc04434c8ea7d27936cc1239e59dc0eb7a379f" ], "author": { "name": "Mark Seaborn", "email": "mseaborn@google.com", "time": "Mon Sep 11 15:38:54 2023 -0700" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Sep 12 19:01:41 2023 +0000" }, "message": "Avoid unnecessary \"Regenerating ninja files\" step after running \"gn gen\"\n\nBefore this change, if you touch args.gn, run \"gn gen\" and then run\nninja, ninja produces a \"Regenerating ninja files\" step which\nunnecessarily runs \"gn gen\" again, and this happens under conditions\nfor which this was previously fixed.\n\nThis can be reproduced in the Fuchsia build:\n\n # Precondition: \"Regenerating ninja files\" needs to have happened\n # once before. This will achieve that.\n fx set bringup.x64 --release\n touch out/default/args.gn\n fx build\n\n # Immediate reproducer: With the bug, \"fx build\" produces\n # \"Regenerating ninja files\".\n fx set bringup.x64 --release\n fx build\n\nThis problem arose before in issue 136 and was fixed by this change:\nhttps://gn-review.googlesource.com/c/gn/+/10400\n(\"Restat build.ninja after gen\", December 2020)\n\nHowever, that fix no longer has any effect following this change:\nhttps://gn-review.googlesource.com/c/gn/+/14200\n(\"[gn] Prevent build.ninja deletion when regeneration is interrupted\",\nAugust 2022)\n\nWe can fix this by telling Ninja to restat build.ninja.stamp instead\nof build.ninja.\n\nIdeally we would add a test case for this that tests the behaviour of\nGN and Ninja together. As well as preventing another regression, that\nwould help with explaining the problem, since the conditions for it\nare somewhat subtle. However, GN currently has no integration tests\nof that kind.\n\nSo ideally I would drop the restat of build.ninja, because it\u0027s not\ncurrently necessary. I\u0027m leaving it place as a defensive measure\nbecause there is no test coverage to ensure that the restats are kept\nin sync with the rest of the code, and also because the cost of\nkeeping it is small.\n\nBug: 344\nTest: manual, see above\nChange-Id: Ifb042070710754c486541dde427c3d8bba0fa6a0\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15940\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\nCommit-Queue: Petr Hosek \u003cphosek@google.com\u003e\n" }, { "commit": "c1fc04434c8ea7d27936cc1239e59dc0eb7a379f", "tree": "455588d6b387451d495f82f1a1b0e0eb45c86ccf", "parents": [ "cc56a0f98bb34accd5323316e0292575ff17a5d4" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Mon Sep 11 14:56:10 2023 +0200" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Sep 12 07:45:01 2023 +0000" }, "message": "Fix variable use tracking for scope subscript accesses.\n\nAccessing a scope field with a subscript expression as in:\n\n scope[\"foo\"]\n\nDid not mark the \u0027foo\u0027 field in the scope as used, unlike\nthe corresponding expression `scope.foo`.\n\nCL fixes that sharing the logic for scope member evaluation\nbetween AccessorNode::ExecuteScopeSubscriptAccess() and\nAccessorNode::ExecuteScopeAccess().\n\nChange-Id: I97b0efa5a2d24c6a99b1a70a33626d1860747909\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15920\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "cc56a0f98bb34accd5323316e0292575ff17a5d4", "tree": "845b1108d2c0172da6ca124795aa7186c920cd12", "parents": [ "811d332bd90551342c5cbd39e133aa276022d7f8" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Tue Jul 18 17:41:56 2023 +0200" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Aug 10 07:24:55 2023 +0000" }, "message": "[infra] Link to jemalloc instead of rpmalloc\n\nChange the recipe to link to the jemalloc allocator instead\nof rpmalloc, since the latter has a nasty race condition that\ntriggers segmentation faults at runtime when the machine is\nunder heavy load (see associated bug for details).\n\nProfiling shows no difference in `gn gen` time when compared\nto the rpmalloc-linked binary.\n\nBug\u003db:273830995\n\nChange-Id: I83e8987fee1dbffc1d2e5e23e61651fce342fdaa\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15700\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\n" }, { "commit": "811d332bd90551342c5cbd39e133aa276022d7f8", "tree": "10ee123ff98e46aad987b8197c551b971c516bf4", "parents": [ "3fccef9033b950e8935e8debeba9fbd71617bc74" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Mon Jul 31 11:32:22 2023 -0400" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Aug 01 15:02:23 2023 +0000" }, "message": "Move WriteSourceSetStamp to NinjaCBinaryTargetWriter\n\nAfter d2e84de8617407c it\u0027s only used there.\n\nWhile here, remove declaration of non-existent WriteStampAndGetDep().\n\nNo behavior change.\n\nChange-Id: I2f64c14a3546fca0c60dbf1d4cceae6cef4c26c5\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15820\nCommit-Queue: Nico Weber \u003cthakis@google.com\u003e\nReviewed-by: Nico Weber \u003cthakis@google.com\u003e\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "3fccef9033b950e8935e8debeba9fbd71617bc74", "tree": "f32408898a2e36476d06d0ab327e6087317740b2", "parents": [ "62ac86a938c365ccdbbbd9a9b49fb72fa3d6eb81" ], "author": { "name": "Aaron Wood", "email": "aaronwood@google.com", "time": "Fri Jul 21 17:47:56 2023 -0700" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jul 27 02:59:11 2023 +0000" }, "message": "[action][data deps] Make data-deps order-only deps of the action outputs\n\nThis change makes action() data_deps behave in the same manner as\nexecutable() data_deps: They are order-only deps of the outputs of the\naction() itself, and not order-only deps of the stampfile for the\naction.\n\nAfter this change, when build the output of an action:\n\n ninja path/to/action/output\n\nthe data_deps will also be verified as up-to-date, and built if\nnecessary.\n\nBefore this change, the data_deps for the action() would not have been\nverified as up-to-date.\n\nChange-Id: I30e9aff8af60df233294ed40f119889af5ee0ad5\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15720\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\nCommit-Queue: Aaron Wood \u003caaronwood@google.com\u003e\n" }, { "commit": "62ac86a938c365ccdbbbd9a9b49fb72fa3d6eb81", "tree": "cd540e741042db5746246f77c37d1d87647798ed", "parents": [ "1029a3b50873abafb5e2a42a60d93a14a6bacfb4" ], "author": { "name": "Aaron Wood", "email": "aaronwood@google.com", "time": "Mon Jul 24 13:27:59 2023 -0700" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jul 26 17:40:01 2023 +0000" }, "message": "[action] Add test for data_deps of an action target\n\nAdd a new test that shows how data_deps of an action are added as ninja\norder-only deps for the rules created for the action.\n\nThis illustrates the currently behavior, where the order-only deps are\nadded to the stamp file rule, not to the action\u0027s own rule.\n\nChange-Id: I0d9d7966621a5002e5f9df5b0718db7a8ea78e74\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15740\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\nCommit-Queue: Aaron Wood \u003caaronwood@google.com\u003e\n" }, { "commit": "1029a3b50873abafb5e2a42a60d93a14a6bacfb4", "tree": "79f5e90c78b4e737302e24baa260efa959bd5807", "parents": [ "fae280eabe5d31accc53100137459ece19a7a295" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Tue Jul 25 13:36:51 2023 +0200" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jul 26 12:27:53 2023 +0000" }, "message": "Ninja: Always pass linker flags to rlib-generating command.\n\nThis is a partial rollback of [1] to restore all linker args in\nthe Ninja command that builds Rust rlib artifacts.\n\nThe Fuchsia build system supports remote builders with a wrapper\nscript that looks at the command-line arguments of the rustc\ninvocation to determine which input files to send to remote\nbuilders. This is done with a custom toolchain tool() definition.\n\nFor example, the final command looks like:\n\n```\n\u003cwrapper_script\u003e \u003cwrapper_args\u003e -- \u003crustc_invocation\u003e\n```\n\nAnd it is crucial that `\u003crustc_invocation\u003e` lists all linker inputs\n(even with `-Lnative\u003d\u003cdir\u003e` and `-Clink-arg\u003dlibfoo.a`) to ensure\nthey can be detected properly.\n\nA recent GN change [1] removed such inputs, which broke the Fuchsia\nbuild (or more accurately, prevents rolling upstream GN into the\nFuchsia tree). For more information, see https://fxbug.dev/130206.\n\nNote that this does not revert the CL entirely, in particular to keep\nthe fix for `framework_dirs` as described in the original bug\ndescription.\n\n+ Update variables.cc to avoid losing a docs/reference.md change\n that was applied manually in [1].\n\n[1] https://gn-review.googlesource.com/c/gn/+/15580\n\nFixed: 340\nChange-Id: Ibd65494a9b180037f21a666da5e6d905751b9c61\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15760\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "fae280eabe5d31accc53100137459ece19a7a295", "tree": "879c971083381dda585af8a95db52265301ac680", "parents": [ "11e12b0ef870b42ecd3b489a194c0c434a054d25" ], "author": { "name": "Andrew Kaster", "email": "akaster@serenityos.org", "time": "Sun Jul 09 18:32:12 2023 -0600" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jul 12 00:36:01 2023 +0000" }, "message": "[serenity] Add SerenityOS port\n\nSerenityOS[0] is a moderately well-behaved hobbyist Unix-like operating\nsystem. This CL adds the required macros and gen.py changes to both\ncross-compile to Serenity and to build on-system.\n\nThe only non-OS macro change is ensuring that exec_process.cpp includes\nsys/select.h in order to make the definition of select() available.\n\nIn local testing, only one test from gn_unittests failed, related to\nfutimes.\n\n[0] https://github.com/SerenityOS/serenity\n\nChange-Id: Id9840d06e86b31ce6e6010405dbd6ec79826006f\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15660\nReviewed-by: Nico Weber \u003cthakis@google.com\u003e\nReviewed-by: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Brett Wilson \u003cbrettw@google.com\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@google.com\u003e\n" }, { "commit": "11e12b0ef870b42ecd3b489a194c0c434a054d25", "tree": "4b8b7df2c5e0b88f40177e397dd245b21a2909f7", "parents": [ "1de45d1a11cc9f8cb5c75a031386151e1c384847" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Mon Jul 10 07:55:39 2023 -0400" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Jul 11 00:24:52 2023 +0000" }, "message": "Remove obsolete comment\n\nThe reference to new_port_policy.md is a remnant from when gn was\npart of the Chromium repository. It doesn\u0027t apply to GN. (See e.g.\nthe zOS patch.)\n\nAlso, the doc no longer exists in the Chromium tree, its contents\ngot merged elsewhere in\nhttps://chromium-review.googlesource.com/c/chromium/src/+/3906683\n\nChange-Id: I1791cf81f05bf257ca031b5235e6492490ab6bd9\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15680\nCommit-Queue: Takuto Ikuta \u003ctikuta@google.com\u003e\nReviewed-by: Brett Wilson \u003cbrettw@google.com\u003e\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "1de45d1a11cc9f8cb5c75a031386151e1c384847", "tree": "82d2442c5711850fc3417e43607deb5d1da2505e", "parents": [ "2a92efd396d3e48e0b081435ab471f3cbfeefda5" ], "author": { "name": "danakj", "email": "danakj@chromium.org", "time": "Tue Jul 04 14:07:02 2023 -0400" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jul 06 18:50:02 2023 +0000" }, "message": "Generate a StaticLibrary for rlibs and DynamicLibrary for proc macros\n\nTeaches GN to be able to generate VS ide files when Rust-specific\ntarget types are present.\n\nBug: 339\nChange-Id: Ie07ac45e13686d5f7f49be33b817df68e787ceea\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15620\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: danakj \u003cdanakj@chromium.org\u003e\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\nReviewed-by: Dana Jansens \u003cdanakj@google.com\u003e\n" }, { "commit": "2a92efd396d3e48e0b081435ab471f3cbfeefda5", "tree": "e01b31d95a7541d1725fe02e09bf1292cede7d1f", "parents": [ "da5fe01bce4ae84b2619caca7a3aa7ec7d3eb8a7" ], "author": { "name": "danakj", "email": "danakj@chromium.org", "time": "Thu Jul 06 14:16:38 2023 -0400" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jul 06 18:49:48 2023 +0000" }, "message": "Include library search paths when compiling rlibs\n\nin the command line.\n\nBug: 340\nChange-Id: I5ae0ad38b5ac26ae8474ae2ba47334491a0d304a\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15640\nReviewed-by: David Turner \u003cdigit@google.com\u003e\nReviewed-by: Dana Jansens \u003cdanakj@google.com\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: danakj \u003cdanakj@chromium.org\u003e\n" }, { "commit": "da5fe01bce4ae84b2619caca7a3aa7ec7d3eb8a7", "tree": "e5ad1fd57bc7f5e8a7d115a1534ff797e147fa61", "parents": [ "4bd1a77e67958fb7f6739bd4542641646f264e5d" ], "author": { "name": "danakj", "email": "danakj@chromium.org", "time": "Fri Jun 30 18:23:26 2023 -0400" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jul 05 01:43:45 2023 +0000" }, "message": "Avoid unused and incorrect linker args in {{rustdeps}}\n\nFor non-final Rust targets, libraries and library search paths do not\nneed to appear in the {{rustdeps}} at all, since there is no linker\nstep that will take place to consume them.\n\nFor framework search paths, pass `-Lframework\u003d$dir` to `rustc` instead\nof just `$dir` which then is incorrectly seen as being an input source\nfile.\n\nThe -Lframework flag is listed here:\nhttps://doc.rust-lang.org/rustc/command-line-arguments.html#-l-add-a-directory-to-the-library-search-path\n\nBug: 340\nChange-Id: Idb1e4e7cc72f465084f3cf9464bdc605b1535c13\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15580\nReviewed-by: Tyler Mandry \u003ctmandry@google.com\u003e\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "4bd1a77e67958fb7f6739bd4542641646f264e5d", "tree": "892f41a44839029a1a27c02f5aabbf8e4dff69f9", "parents": [ "1cd35c1b722472e714c30d12031af81443bb20ae" ], "author": { "name": "Nico Weber", "email": "thakis@chromium.org", "time": "Fri Jun 09 10:04:49 2023 -0400" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Jun 09 15:06:51 2023 +0000" }, "message": "Escape `+` characters in rule names\n\nWhen adding an `action()` in buildtools/third_party/libc++/BUILD.gn,\nwe get\n\n ninja: error: toolchain.ninja:629: expected newline, got lexing error\n rule __buildtools_third_party_libc++_write_libcxx_modulemap___build_tool...\n ^ near here\n\nwithout this.\n\nBug: chromium:1430964\nChange-Id: I4fe30182565ac2114319c4fb79bb9b8442407f0d\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15500\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\n" }, { "commit": "1cd35c1b722472e714c30d12031af81443bb20ae", "tree": "d9e45dfe4db4ef2fb91f789b88e93bf98e7145fd", "parents": [ "e5aee7bbd8033e0365d5d631871e409934dc3283" ], "author": { "name": "Sylvain Defresne", "email": "sdefresne@chromium.org", "time": "Thu Jun 08 10:14:18 2023 -0400" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jun 08 15:07:00 2023 +0000" }, "message": "[ios] Update sample to build the app as a framework\n\nTo demonstrate fix for https://crbug.com/gn/337, update the sample\napplication to build the application as a framework with a shell\napp that `dlopen()` the framework and call the entry point.\n\nFixed: 337\nChange-Id: I939f0736856a45725549f62cca72e09a1f0e0f0e\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15461\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\n" }, { "commit": "e5aee7bbd8033e0365d5d631871e409934dc3283", "tree": "c10ff69d8be50bc440cfdd15cec15c843ecb18d1", "parents": [ "e3978de3e8dafb50a2b11efa784e08699a43faf8" ], "author": { "name": "Sylvain Defresne", "email": "sdefresne@chromium.org", "time": "Thu Jun 08 10:08:10 2023 -0400" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jun 08 14:17:01 2023 +0000" }, "message": "[apple] Implements support of transparent create_bundle\n\nA transparent create_bundle target is one that allows bundle_data\ndeps to propagate through the dependency chain. This can be used\nby create_bundle that generates a framework bundle that needs to\nhave the resources put in the main application bundle.\n\nThis will be used by Chrome on iOS to initialize PartitionAlloc\nbefore starting the executing any static initializer (by moving\nthe initialisation in a shell application then loading code as\na private framework).\n\nBug: 337\nChange-Id: I38a68c7ebcd715b06e79417b7a33e4a84f8fa655\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15460\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "e3978de3e8dafb50a2b11efa784e08699a43faf8", "tree": "8c472b5ccde8348d1d298b256addf77da292f70c", "parents": [ "e9e83d9095d3234adf68f3e2866f25daf766d5c7" ], "author": { "name": "Adrian Taylor", "email": "adetaylor@chromium.org", "time": "Fri May 26 12:07:53 2023 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri May 26 22:10:55 2023 +0000" }, "message": "Make dynamic link switch... dynamic.\n\nPreviously gn hard-coded the linker switch -Bdynamic\nwhich is incorrect on platforms where MSVC tools are used for linking.\nThis CL parameterizes that flag.\n\nBug: https://crbug.com/1271215\nChange-Id: I379c86b5eb166d973bc502cdae2552b9e1c6a6a7\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/12460\nCommit-Queue: Tyler Mandry \u003ctmandry@google.com\u003e\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\nReviewed-by: Tyler Mandry \u003ctmandry@google.com\u003e\n" }, { "commit": "e9e83d9095d3234adf68f3e2866f25daf766d5c7", "tree": "92de049217043705d10bde8d05c7ce88ca83cfcb", "parents": [ "6975103d9f59ed9f3cfbc6d2201298f2c2fde046" ], "author": { "name": "Roland McGrath", "email": "mcgrathr@google.com", "time": "Thu May 18 14:25:24 2023 -0700" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri May 19 17:48:19 2023 +0000" }, "message": "Add --use-asan and --use-ubsan options to build/gen.py\n\nChange-Id: I2d06e9f42219b140fe33b979b87df935762efeaf\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15400\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\nCommit-Queue: Roland McGrath \u003cmcgrathr@google.com\u003e\n" }, { "commit": "6975103d9f59ed9f3cfbc6d2201298f2c2fde046", "tree": "deb8f94601b66addab3ccddac009f9aa6f151667", "parents": [ "be16dea4dfdd72cd6a4e198f8f8319b1f060b26d" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Thu Dec 29 13:50:37 2022 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue May 16 14:01:27 2023 +0000" }, "message": "gn gen: Implement thread-local ResolvedTargetData cache.\n\nFinal benchmarks for \u0027gn gen\u0027 from the previous stack of CLs\nshows significant time reduction for moderate peak RAM increase:\n\n TIME_BEFORE TIME_AFTER RAM_BEFORE RAM_AFTER\n\n Chromium: 4.75s 3.30s 1.00GiB 1.31GiB\n Fuchsia: 20.99s 17.98s 3.84GiB 4.07GiB\n\nBenchmark Details ------------------------------------------\n\nChromium:\n\n $ hyperfine \u0027/tmp/gn-main gen out/Default\u0027 \u0027/tmp/gn-new gen out/Default\u0027\n Benchmark 1: /tmp/gn-main gen out/Default\n Time (mean ± σ): 4.753 s ± 0.044 s [User: 15.413 s, System: 8.977 s]\n Range (min … max): 4.672 s … 4.820 s 10 runs\n\n Benchmark 2: /tmp/gn-new gen out/Default\n Time (mean ± σ): 3.303 s ± 0.061 s [User: 18.202 s, System: 9.122 s]\n Range (min … max): 3.217 s … 3.413 s 10 runs\n\n Summary\n \u0027/tmp/gn-new gen out/Default\u0027 ran\n 1.44 ± 0.03 times faster than \u0027/tmp/gn-main gen out/Default\u0027\n\n $ /usr/bin/time -f%M /tmp/gn-main gen out/Default\n Done. Made 17871 targets from 3048 files in 4674ms\n 1049960\n\n $ /usr/bin/time -f%M /tmp/gn-new gen out/Default\n Done. Made 17871 targets from 3048 files in 3229ms\n 1374344\n\nFuchsia:\n\n $ hyperfine \u0027/tmp/gn-main gen out/default\u0027 \u0027/tmp/gn-new gen out/default\u0027\n Benchmark 1: /tmp/gn-main gen out/default\n Time (mean ± σ): 20.994 s ± 0.277 s [User: 97.113 s, System: 49.242 s]\n Range (min … max): 20.637 s … 21.602 s 10 runs\n\n Benchmark 2: /tmp/gn-new gen out/default\n Time (mean ± σ): 17.981 s ± 0.259 s [User: 95.037 s, System: 48.343 s]\n Range (min … max): 17.390 s … 18.324 s 10 runs\n\n Summary\n \u0027/tmp/gn-new gen out/default\u0027 ran\n 1.17 ± 0.02 times faster than \u0027/tmp/gn-main gen out/default\u0027\n\n $ /usr/bin/time -f%M /tmp/gn-main gen out/default\n Generating compile_commands took 727ms\n Done. Made 196612 targets from 6247 files in 20741ms\n 4026004\n\n $ /usr/bin/time -f%M /tmp/gn-new gen out/default\n Generating compile_commands took 659ms\n Done. Made 196612 targets from 6247 files in 17427ms\n 4272248\n\nBug: 331\nChange-Id: Ib2eca769a5a587a531f4fac2be263555e37b89ea\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15329\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "be16dea4dfdd72cd6a4e198f8f8319b1f060b26d", "tree": "164ac2ed357ac407f13af2b6d0475615ca1c3919", "parents": [ "caadd6c6d9f6df2a5f944aee5e47ceab461edf43" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Mon Jan 23 16:44:12 2023 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue May 16 13:26:57 2023 +0000" }, "message": "Add ResolvedTargetData:GetSwiftModuleDependencies()\n\nThis moves the SwiftValues::modules_ and SwiftValues::public_modules_\nvalues to the ResolvedTargetData class to compute them on demand,\ninstead of unconditionally.\n\nBug: 331\nChange-Id: Icc894415cb556c9b750227dd8cf7a493982d77b9\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15328\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "caadd6c6d9f6df2a5f944aee5e47ceab461edf43", "tree": "66aae2e27c7ff3a8529a0469456213d07180b9d8", "parents": [ "921a280a4912e395b15d76039934bd3a3ab146e4" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Wed Nov 16 16:12:05 2022 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue May 16 13:10:50 2023 +0000" }, "message": "Remove obsolete InheritedLibraries class.\n\nThis class is no longer used in the source tree, due\nto the use of TargetPublicPair and TargetPublicPairBuilder\nclasses in the ResolvedTargetData class.\n\nBug: 331\nChange-Id: Ibb269bf35a7d92421b2389caf4fd5659f817c329\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/14884\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\n" }, { "commit": "921a280a4912e395b15d76039934bd3a3ab146e4", "tree": "8f6c96b2fd293885abbe996bd73f146f036144dd", "parents": [ "0ed4d9b7cfd46b79ecbd774fa6b477250269598a" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Fri Jan 20 19:04:07 2023 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue May 16 12:58:50 2023 +0000" }, "message": "Add ResolvedTargetData::GetRustInheritedLibraries()\n\nThis CL removes Target::rust_transitive_inherited_libs()\nand moves the computation of the corresponding value to\nthe ResolvedTargetData class, where it will be created\non demand by the GetRustInheritedLibraries() method.\n\nBug: 331\nChange-Id: I7fcfaee61242aeddfb9284e2270f2882712cdb81\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15327\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\n" }, { "commit": "0ed4d9b7cfd46b79ecbd774fa6b477250269598a", "tree": "72a48508cceaf7021882f662a7bf4bd938a7cad3", "parents": [ "63c225c698d63b4b724361e0c8cdcf48e2cbd704" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Fri Jan 20 17:42:25 2023 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue May 16 12:47:29 2023 +0000" }, "message": "Add ResolvedTargetData::GetInheritedLibraries()\n\nThis CL removes Target::inherited_libraries() and moves\nthe computation of the corresponding value to the\nResolvedTargetData class instead, where it will be\ncreated on-demand by the GetInheritedLibraries() method.\n\nBug: 331\nChange-Id: I65f73d9d895f4db1318363b6c8a8775d7225252b\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15326\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\n" }, { "commit": "63c225c698d63b4b724361e0c8cdcf48e2cbd704", "tree": "3df7d709a3002a53bb07ea784748b27edaf2e0bc", "parents": [ "ed4e652769dee4ef7961a9a01019f489a3b7e733" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Fri Jan 20 17:27:02 2023 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue May 16 12:12:11 2023 +0000" }, "message": "Add ResolvedTargetData::GetHardDeps()\n\nThis CL removes Target::recursive_hard_deps() and moves the\ncomputation of the corresponding value to the\nResolvedTargetData class, which creates it on demand\nwith the GetHardDeps() method.\n\nBug: 331\nChange-Id: I8aec15ab047533b2fe80ff853850de3a57dc898d\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15325\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "ed4e652769dee4ef7961a9a01019f489a3b7e733", "tree": "a092dc26b75b68646386b3435736d7b54791716b", "parents": [ "d23cd22d6bfd9e4c0b926f77b86a6d7d1e753baa" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Fri Jan 20 17:07:24 2023 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue May 16 12:01:36 2023 +0000" }, "message": "Add ResolvedTargetData::GetLinkedFrameworks()\n\nThis CL removes Target::all_framework_dirs(), Target::all_frameworks()\nand Target::all_weak_frameworks(), moving their computation to the\nResolvedTargetData class, where they will be created on demand, and\nreturned by the GetLinkedFrameworkDirs(), GetLinkedFrameworks() and\nGetLinkedWeakFrameworks() methods respectively.\n\nBug: 331\nChange-Id: Iecefbcc4182265113d5939f8a854d12c2670b8f5\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15324\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\n" }, { "commit": "d23cd22d6bfd9e4c0b926f77b86a6d7d1e753baa", "tree": "2ba16e92e73238b1196cd766a0f6e0153b7922af", "parents": [ "64aca9d73c86a9bca827b61c5e694ab199a1fb16" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Fri Jan 20 16:28:31 2023 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue May 16 11:52:06 2023 +0000" }, "message": "Add ResolvedTargetData::GetLinkedLibraries()\n\nThis CL removes Target::all_libs() and Target::all_lib_dirs()\nand move their computation to the ResolvedTargetData class,\nwhere the values will be generated on demand and returned by\nthe GetLinkedLibraries() and GetLinkedLibraryDirs() methods\nrespectively.\n\nBug: 331\nChange-Id: I4ce91fca247ac4bbe8a51666f0f58fa55bfe925b\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15323\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "64aca9d73c86a9bca827b61c5e694ab199a1fb16", "tree": "eedb6b32bcf90b710bdf5ac69e354f5755cb0ff4", "parents": [ "8e00b697b76be352c62537ec8c14763019ca2f29" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Fri Jan 20 16:06:12 2023 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue May 16 11:00:36 2023 +0000" }, "message": "Use ResolvedTargetData::GetTargetDeps() in Ninja target writers.\n\nUse the new NinjaTargetWriter::resolved() method to parse\ntarget dependencies. This is the first CL in a series that\nwill move computations from Target to ResolvedTargetData and\nmodify the Ninja writers to use instances of the latter.\n\nBug: 331\nChange-Id: I053f7f62f3525f58d94ffbfd1c170d429327ccd7\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15322\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\n" }, { "commit": "8e00b697b76be352c62537ec8c14763019ca2f29", "tree": "0a9d64b6b3152a507cdddb58952493067c2a6750", "parents": [ "9103fc83ef0dad5309260114c790cc8d1a8cb041" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Fri Jan 20 15:52:09 2023 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue May 16 07:49:41 2023 +0000" }, "message": "Add NinjaTargetWriter::resolved()\n\nAllow NinjaTargetWriter instances to use a shared\nResolvedTargetData instance to compute values over\ntransitive dependency trees.\n\nThe instance can be set with SetResolvedTargetData(),\nor will otherwise be created on demand when the\nresolved() method is called.\n\nBug: 331\nChange-Id: Ie464bfe3ab5f645e70bc20e4c315797f17336ad9\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15321\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "9103fc83ef0dad5309260114c790cc8d1a8cb041", "tree": "f13290b0b772c90144716ae6aaa28024e7173348", "parents": [ "22cfb67672d275aca38ee35f81e046fa0d978704" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Fri Jan 20 15:32:41 2023 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue May 16 07:29:03 2023 +0000" }, "message": "Add ResolvedTargetData class.\n\nThis class will be used to compute and cache values over\nthe transitive dependency tree of resolved targets. This\nCL is minimal and only implements the conversion of dependencies\ninto a ResolvedTargetDeps instance.\n\nFuture CLs will use this in Ninja target writers calls, then\nwill gradually move computations performed in Target::OnResolved()\nto this class to speed up computations.\n\nBug: 331\nChange-Id: I3af49cce4252dc44733c0d47afb263023c7b50db\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15320\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "22cfb67672d275aca38ee35f81e046fa0d978704", "tree": "ad805791cb492a644daf75ba46a89f2550118234", "parents": [ "26aa46c283e40199b6f847ecca088dcea7099ded" ], "author": { "name": "Aaron Wood", "email": "aaronwood@google.com", "time": "Fri May 05 17:28:05 2023 -0700" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue May 16 01:49:36 2023 +0000" }, "message": "[tracing] Refine tracing of file writing and template execution\n\nThis disambiguates the writing of generated files and ninja files from\nother write_file() commands, adds tracing of template invocations while\nexec\u0027ing files, and adds tracing of metadata walks.\n\nA \"before\" trace can be found here, for a very large build that heavily\nuses templates:\nhttps://ui.perfetto.dev/#!/?s\u003dff7918ffc237b25bfafa04e0188cdd732be49d788aa65beb072fc16446e33468\n\nand the \"after\" trace is:\nhttps://ui.perfetto.dev/#!/?s\u003dadeb4aba68882f380e7f88b3a45f15528722343ee3932d8dfc82e4120856a8a9\n\n\nChange-Id: Ie7a445ff334e28dca97dfcd00c6398149c5b6b8a\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15280\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\nCommit-Queue: Aaron Wood \u003caaronwood@google.com\u003e\n" }, { "commit": "26aa46c283e40199b6f847ecca088dcea7099ded", "tree": "0ccd7ecf2d23035f4c860daf95ccf41baaf93627", "parents": [ "ad1e5ce10f06ef9a1a1d91b2e48231d6b3eecbe2" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@google.com", "time": "Tue May 09 16:28:45 2023 +0900" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue May 09 07:54:20 2023 +0000" }, "message": "replace \u0027Which\u0027 with \u0027which\u0027\n\nChange-Id: I8462f8762fed97c0acaea893bfb332c7eba6e6a5\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15300\nReviewed-by: David Turner \u003cdigit@google.com\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "ad1e5ce10f06ef9a1a1d91b2e48231d6b3eecbe2", "tree": "f858c2e1a9116c2b2da0781dd6435ffbd9a46cf2", "parents": [ "3dadaf0ee3ee07d7c29ad926e1a42d90068d7e6b" ], "author": { "name": "Joseph Ryan", "email": "josephry@google.com", "time": "Wed Apr 26 13:48:01 2023 -0700" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue May 09 06:56:40 2023 +0000" }, "message": "Add optional \u0027mnemonic\u0027 var to actions\n\nThis will replace the \"ACTION\" prefix for the ninja\ndescription of a given action.\n\nChange-Id: Ib394f193e0aaa9ff3453c7b8e10a07a2b84150ad\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15260\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "3dadaf0ee3ee07d7c29ad926e1a42d90068d7e6b", "tree": "4fe971fbed83e086046596e1f1ee4091306a01d7", "parents": [ "7657b1cbed28560735a8e5ced4fccc5585bb1237" ], "author": { "name": "Roland McGrath", "email": "mcgrathr@google.com", "time": "Fri May 05 17:41:03 2023 -0700" }, "committer": { "name": "Roland McGrath", "email": "mcgrathr@google.com", "time": "Fri May 05 17:41:03 2023 -0700" }, "message": "Revert \"[tracing] Refine tracing of file writing and template execution\"\n\nThis reverts commit 7657b1cbed28560735a8e5ced4fccc5585bb1237.\n\nIt was an accidental commit.\n" }, { "commit": "7657b1cbed28560735a8e5ced4fccc5585bb1237", "tree": "b732680bb029543b21dcaa9b7bccf99fc3f6532c", "parents": [ "5a004f9427a050c6c393c07ddb85cba8ff3849fa" ], "author": { "name": "Aaron Wood", "email": "aaronwood@google.com", "time": "Fri May 05 17:28:05 2023 -0700" }, "committer": { "name": "Aaron Wood", "email": "aaronwood@google.com", "time": "Fri May 05 17:28:05 2023 -0700" }, "message": "[tracing] Refine tracing of file writing and template execution\n\nThis disambiguates the writing of generated files and ninja files from\nother write_file() commands, adds tracing of template invocations while\nexec\u0027ing files, and adds tracing of metadata walks.\n" }, { "commit": "5a004f9427a050c6c393c07ddb85cba8ff3849fa", "tree": "4fe971fbed83e086046596e1f1ee4091306a01d7", "parents": [ "ffeea1b1fd070cb6a8d47154a03f8523486b50a7" ], "author": { "name": "Stephan Hartmann", "email": "stha09@googlemail.com", "time": "Wed Apr 19 11:16:16 2023 +0200" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Apr 19 10:22:19 2023 +0000" }, "message": "IWYU: add stdint.h for int types in base/containers\n\nBug: chromium:957519\nChange-Id: Iea60680ebf9b61a101567d096154e2d9263f1581\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15240\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "ffeea1b1fd070cb6a8d47154a03f8523486b50a7", "tree": "fef7a71965d1a44443188923900e19b873492fa3", "parents": [ "61da8bdce6229e2ef8c368ae89f6eef4c89aa770" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@google.com", "time": "Wed Apr 05 16:52:17 2023 +0900" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Apr 07 01:14:55 2023 +0000" }, "message": "replace phosek@chromium.org with phosek@google.com in OWNERS\n\nphosek@chromium.org doesn\u0027t exist in this host now and that is bit\nconfusing although phosek@google.com seems to have ownership\nimplicitly.\n\nChange-Id: I3b8c3ce78eab1f773ab156d9560a5d81a81184ff\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15221\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "61da8bdce6229e2ef8c368ae89f6eef4c89aa770", "tree": "fa42317186d3742456ec3b6a3a7da3a17611039f", "parents": [ "28b7b6c507eb808567e3aea446cd259f7691fddc" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@google.com", "time": "Wed Apr 05 16:49:24 2023 +0900" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Apr 06 01:16:55 2023 +0000" }, "message": "add tikuta to OWNERS\n\nChange-Id: I93db22ac0566f12cb1b28f9c88bc2783aef2e102\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15220\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "28b7b6c507eb808567e3aea446cd259f7691fddc", "tree": "8fadad30418dbd95ac7a716bd49f0f9ac582443b", "parents": [ "41fef642de70ecdcaaa26be96d56a0398f95abd4" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Tue Apr 04 00:09:45 2023 +0200" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Apr 05 13:11:50 2023 +0000" }, "message": "Support defined(foo[\"bar\"]) syntax.\n\nSince it is already possible to use a string subscript to\nget the value of a scope member (i.e. foo[\"bar\"] being the\nsame as foo.bar, but [] allowing expression evaluation),\nthis ensures that `defined(foo[\"bar\"])` works as `defined(foo.bar)`\nas well.\n\nBug: 328\nChange-Id: I41c069b3e782745765f85aa0c1a6f7ac75f43c82\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15200\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\nReviewed-by: Brett Wilson \u003cbrettw@google.com\u003e\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\n" }, { "commit": "41fef642de70ecdcaaa26be96d56a0398f95abd4", "tree": "699aff887b81917140ebfead9e35ea9c861a347e", "parents": [ "77014c1590164715fff8f3f3d3c77e9ff01b4d70" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Fri Mar 17 13:28:04 2023 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Sat Mar 18 18:20:13 2023 +0000" }, "message": "Make `gn args --list` deterministic\n\nThis fixes Args::GetAllArguments() to return deterministic results,\neven when declare_args() are used in args.gn or some of its\nimported files.\n\nWhile this is ugly, this is used by the Fuchsia build in order to\noverride variables in third-party .gni files. This also creates\ntwo Settings instance that return `is_default() \u003d\u003d true`:\n\n- The first is just the regular default toolchain.\n- The second one has an empty label, and is used by the scope\n created when parsing the args.gn file.\n\nThe std::sort() comparator assumed there was only one default\ntoolchain, this resulted in practice in non-deterministic\noutputs for the list of arguments.\n\nThis CL fixes the issue by ensuring the comparator places\nthe empty toolchain first, then the default one second,\nfollowed by all others sorted by their label.\n\nBug: 327\n\nChange-Id: I342d285a15339572adf72c2ddb29bbd81b814d10\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15160\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "77014c1590164715fff8f3f3d3c77e9ff01b4d70", "tree": "9025c2736a04c2d860b787918bfe1a7a76f74a04", "parents": [ "fe330c0ae1ec29db30b6f830e50771a335e071fb" ], "author": { "name": "Brett Wilson", "email": "brettw@chromium.org", "time": "Wed Mar 15 12:56:10 2023 -0700" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Mar 16 18:15:50 2023 +0000" }, "message": "Specify line endings in .gitattributes.\n\nGN expects Unix line endings. This is necessary at least for some types\nof tests and setting this helps keeps things consistent.\n\nChange-Id: Ic9a60baa30c6140448bb741ea5b57e129a7a35c8\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15140\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "fe330c0ae1ec29db30b6f830e50771a335e071fb", "tree": "ee94c63d86a2de2efb9671fb1afdd8549a67cf95", "parents": [ "b25a2f8c2d33f02082f0f258350f5e22c0973108" ], "author": { "name": "Thiago Perrotta", "email": "tperrotta@google.com", "time": "Wed Feb 22 19:35:24 2023 -0500" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Feb 24 04:28:58 2023 +0000" }, "message": "Update yapf style from \"chromium\" to \"yapf\"\n\nyapf v0.30.0 renamed \"chromium\" style to \"yapf\".\n\nBug: chromium:1306598\nChange-Id: I963a7aa5374f743fb10c6cbd398b558b89ae4e96\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15100\nReviewed-by: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nCommit-Queue: Takuto Ikuta \u003ctikuta@google.com\u003e\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "b25a2f8c2d33f02082f0f258350f5e22c0973108", "tree": "f4d54ef62595362667cede68b1b838b1bfcfc3f1", "parents": [ "edf6ef4b06b42c58292faea78498aff76bdf68ed" ], "author": { "name": "Michael Spang", "email": "spang@chromium.org", "time": "Fri Feb 17 17:59:52 2023 -0500" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Feb 17 23:29:16 2023 +0000" }, "message": "Fix escaping of interpreter, script, \u0026 source dir\n\nThe wrong escaping mode is used in a few contexts, which results in\nfailed builds. This is happening in particular to folks whose sources\nare inside a directory with a space in it, and whose builds are not\ncontained within that directory.\n\nSuch builds encode the surrounding filesystem structure into the ninja\nfiles, which is unfortunate but unavoidable in some environments. Fix\nthe escaping mode in this case.\n\nBug: 325\nChange-Id: Iab53514a3c5cbdb6e7a1d995469e2a75e44924dd\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15080\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "edf6ef4b06b42c58292faea78498aff76bdf68ed", "tree": "30075ee6aec9d0db3e522457a830004cf81da05f", "parents": [ "84c8431f3e03cc6226c59dd49637c15ea31169a1" ], "author": { "name": "Aaron Wood", "email": "aaronwood@google.com", "time": "Mon Feb 06 21:34:59 2023 -0800" }, "committer": { "name": "Aaron Wood", "email": "aaronwood@google.com", "time": "Tue Feb 07 14:35:32 2023 -0800" }, "message": "[unused vars] Improve error messages in templates\n\nThis adds the location of the invocation that encountered the\nunused var to the stack of \u0027whence it was called\u0027 lines.\n\nChange-Id: I3185372750d15171aa7650d1bf4618d3d6e076eb\n" }, { "commit": "84c8431f3e03cc6226c59dd49637c15ea31169a1", "tree": "5e9cd9d3ec22e02cd062e70512ac8dd928d7e1ae", "parents": [ "629f6be82956987c7ac10faf2acf0534b1667fa2" ], "author": { "name": "Hector Dearman", "email": "hjd@google.com", "time": "Sun Jan 29 11:50:02 2023 +0000" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Jan 30 23:18:02 2023 +0000" }, "message": "Remove reference to $relative_target_output_dir\n\n`$relative_target_output_dir` was a variable at one point but no longer.\nUpdate the `depfile` docs example to remove the last reference to\n`$relative_target_output_dir` and instead suggest what most Chrome\ngni files seem to do which is \"${target_gen_dir}/${target_name}.d\" +\nrebase_path.\n\nChange-Id: Ie6be45f9f5be704b4c8fe1cde4d3c2551461c4f8\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15020\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nReviewed-by: David Turner \u003cdigit@google.com\u003e\n" }, { "commit": "629f6be82956987c7ac10faf2acf0534b1667fa2", "tree": "dae47cc4ac67299725b728ee3abbb3412b169387", "parents": [ "5e19d2fb166fbd4f6f32147fbb2f497091a54ad8" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Mon Jan 30 22:46:31 2023 +0100" }, "committer": { "name": "Brett Wilson", "email": "brettw@chromium.org", "time": "Mon Jan 30 22:56:31 2023 +0000" }, "message": "[infra] Update rpmalloc revision\n\nThe recipe was broken when using rpmalloc (i.e. when\nbuilding for Linux only) because Clang was updated to\nversion 16, and that compiler now complains of unsafe\nbuffer usage when -Weverything is used.\n\nThe fix does:\n\n- Update the rpmalloc revision to a more recent revision,\n which includes fixes for a previous warning issue.\n See [1] in particular.\n\n- Add a -Wno-unsafe-buffer-usage compiler flag to ensure\n the library can be compiled.\n\n[1] https://github.com/mjansson/rpmalloc/commit/f4732ee2b8a5a838cf52cfcd6bc4a44bdc084ef2\n\nBug: None\n\nChange-Id: Ie6233d41d8657b073bcb9f79e9cbd0e4aa30b652\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/15021\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "5e19d2fb166fbd4f6f32147fbb2f497091a54ad8", "tree": "dfb1b332190cab68cd9ac157e730b73068719a43", "parents": [ "9703eb75389191c321d93bf7a6a6cf695584c91f" ], "author": { "name": "Sylvain Defresne", "email": "sdefresne@chromium.org", "time": "Mon Dec 12 18:20:36 2022 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Dec 12 18:15:19 2022 +0000" }, "message": "Consider application bundle as executable for phony targets\n\nWhen generating phony short names for target, consider that targets\ncreating bundle with type \"com.apple.product-type.application\" as\nexecutables.\n\nThis will help ensure that when targeting the iOS platform, it is\npossible to build the application bundle using their short name\neven if some third-party dependency use the same name.\n\nRecently building Chrome on iOS from the command-line using\n`ninja -C out/Debug chrome` was broken for the second time due\nto a change in perfetto adding a target named \"chrome\".\n\nNote that on iOS it is not possible to run an executable that is\nnot in an application bundle, so the rule that prefer executable\ntarget was not working there.\n\nBug: chromium:1383100\nChange-Id: Iab62336fa37db8fab0dc84affa2cfab65e0e60f9\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/14920\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "9703eb75389191c321d93bf7a6a6cf695584c91f", "tree": "1494ddd90d1f9c6f411b5f5fa02754a1da450d40", "parents": [ "9bffaa2162842f94d9444a9b3cea00dcf137cd04" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Wed Nov 16 15:53:24 2022 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Dec 12 12:31:25 2022 +0000" }, "message": "Add PointerSet::ToVector() method\n\nThis will be used in a future CL that moves and caches target resolution\ncomputations to a dedicated class.\n\nChange-Id: I768706b596c687d83ac33ade7878947b190fef96\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/14882\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\n" }, { "commit": "9bffaa2162842f94d9444a9b3cea00dcf137cd04", "tree": "55907a02a0fa7ff99e556f60506599567cc9a6eb", "parents": [ "89c2ab2df37e0e9ea9ac6f68d01ed97ec3abf157" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Wed Nov 16 15:28:34 2022 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Dec 12 11:45:39 2022 +0000" }, "message": "Add ResolvedTargetDeps class\n\nWhich provides simpler and faster ways to parse target dependencies.\n\nThis will be used in a future CL that moves and caches target resolution\ncomputations to a dedicated class.\n\nChange-Id: Ic411989d136346cee72ca877e3c96021113dc901\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/14881\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\n" }, { "commit": "89c2ab2df37e0e9ea9ac6f68d01ed97ec3abf157", "tree": "858c4fe3fb4b41887f50da3fa1fe27ba94676445", "parents": [ "70d6c60823c0233a0f35eccc25b2b640d2980bdc" ], "author": { "name": "David \u0027Digit\u0027 Turner", "email": "digit@google.com", "time": "Wed Nov 16 15:18:15 2022 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Dec 12 11:17:30 2022 +0000" }, "message": "Add TargetPublicPair class.\n\nThis is conceptually similar to InheritedLibraries, except that this\nseparates the temporary UniqueVector\u003c\u003e used during construction, from\nthe final result, which is a simple vector of (target, is_public) pairs\ninstead, which is smaller to store and faster to parse during target\nresolution.\n\nThis will be used in a future CL that moves and caches target resolution\ncomputations to a dedicated class.\n\nBug: None\n\nChange-Id: I0f7840d105e812a7d43c415ce5e71e43fec1268e\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/14880\nCommit-Queue: David Turner \u003cdigit@google.com\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "70d6c60823c0233a0f35eccc25b2b640d2980bdc", "tree": "9d10c25d5f5c089c1ebcb4dcd434e8aa88f67fcc", "parents": [ "1c4151ff5c1d6fbf7fa800b8d4bb34d3abc03a41" ], "author": { "name": "Takuto Ikuta", "email": "tikuta@google.com", "time": "Tue Nov 29 13:50:20 2022 +0900" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Nov 29 05:20:49 2022 +0000" }, "message": "recipe: use python3 only\n\nThis follows http://go/luci/migrations/recipe_py3\n\nBug: chromium:1393261\nChange-Id: Ia8dfe6931c7ac93deab4772462338b599d22c2d2\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/14900\nCommit-Queue: Takuto Ikuta \u003ctikuta@google.com\u003e\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\n" }, { "commit": "1c4151ff5c1d6fbf7fa800b8d4bb34d3abc03a41", "tree": "83bcf3565ba08c0fe465ee0975676c7383321ca0", "parents": [ "a4d67be044b42963de801001e7146f9657c7fad4" ], "author": { "name": "Sylvain Defresne", "email": "sdefresne@chromium.org", "time": "Thu Nov 10 13:58:32 2022 +0100" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Nov 10 16:29:39 2022 +0000" }, "message": "[xcode] Refer to target by their long name in generate Xcode project\n\nAccording to NinjaBuildWriter::WritePhonyAndAllRules() documentation,\ngn only generate a phony target with the short target name if it is\neither an executable or unambiguous.\n\nRecently a \"chrome\" target was added in a third-party repository\nwhich broke the compilation of Chrome on iOS from the genrated Xcode\nproject since the \"chrome\" name was no longer unambiguous. Since the\ntarget is a bundle and not an executable, the phony target with the\nshort name was not created.\n\nChange the Xcode generator to use the long name for the target for\nwhich the phony target is always generated. User don\u0027t need to care\nabout collision when using Xcode to build.\n\nBug: chromium/1383100\nChange-Id: I5e1b43f4e675cc1967744e80194eb7fe7f8ae310\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/14840\nReviewed-by: David Turner \u003cdigit@google.com\u003e\nReviewed-by: Justin Cohen \u003cjustincohen@google.com\u003e\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\n" }, { "commit": "a4d67be044b42963de801001e7146f9657c7fad4", "tree": "23b9085b16249cc19d7969e4b415e0627a03078c", "parents": [ "11dc0b1f438bd26380774e9d50fd4c63f346d41a" ], "author": { "name": "Aaron Wood", "email": "aaronwood@google.com", "time": "Thu Oct 27 19:35:21 2022 -0700" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Oct 28 19:21:13 2022 +0000" }, "message": "[rust-project] Remove the emitting of sysroot crates\n\nNow that rust-analyzer is able to automatically add the sysroot\ncrates, if a \u0027sysroot\u0027 value is specified in the file, remove\nthe addition of the sysroot crates, and let rust-analyzer find\nthe crates from within the sysroot path specified.\n\nThis is more maintainable over time (doesn\u0027t duplicate the logic\nof finding the sysroot crates), and removes the current double-\naddition of the sysroot crates which is breaking rust-analyzer\u0027s\nability to locate the implementations of items like Deref\u003c\u003e.\n\nChange-Id: I84db1591525e8b7a5c46952a9d076990eb9c3540\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/14800\nReviewed-by: Dan Johnson \u003ccomputerdruid@google.com\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Aaron Wood \u003caaronwood@google.com\u003e\n" }, { "commit": "11dc0b1f438bd26380774e9d50fd4c63f346d41a", "tree": "7e013f7449633406756e434697c644205b494920", "parents": [ "3e98c606ed0dff59fa461fbba4892c0b6de1966e" ], "author": { "name": "Aaron Wood", "email": "aaronwood@google.com", "time": "Thu Oct 20 15:30:44 2022 -0700" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Oct 26 18:40:38 2022 +0000" }, "message": "[errors] Print label toolchains more often\n\nAdds the toolchain to labels in error messages in many\nmore cases than in the past.\n\nChange-Id: Ib098bf1902f64fc8c27015dee1a3c3abc786ca5b\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/14720\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Aaron Wood \u003caaronwood@google.com\u003e\n" }, { "commit": "3e98c606ed0dff59fa461fbba4892c0b6de1966e", "tree": "591f6d75b8b7f235e143b2e94ac90e550766db4d", "parents": [ "7a6231e3e43845d9aa298bb040f11dd1953e966f" ], "author": { "name": "Aaron Wood", "email": "aaronwood@google.com", "time": "Thu Oct 20 14:04:22 2022 -0700" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Oct 26 18:07:32 2022 +0000" }, "message": "[error messages] Centralize decision logic for showing toolchains in errors\n\nCreate a central implementation for determining if a set\nof labels need to show their toolchain or not when\ncreating error messages.\n\nChange-Id: I9015340930e9e0a2e91f7aa9704a141464d60ce7\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/14700\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "7a6231e3e43845d9aa298bb040f11dd1953e966f", "tree": "0e8b9c59d3021b79312828b7436b01d01dd3fb50", "parents": [ "27b90626701a112217a9244022c729231ebcc3a0" ], "author": { "name": "Petr Hosek", "email": "phosek@google.com", "time": "Sat Oct 22 23:14:18 2022 +0000" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Oct 24 19:17:49 2022 +0000" }, "message": "Support pools on binary targets\n\nCurrently pools are only supported in tools and actions but not binary\ntargets which can be useful in some scenarios. This change introduces\nsupport for pools on binary targets.\n\nFixed: 308\nChange-Id: Ifdd0c1e533b6ead22cf16b1114d18d124e8413c9\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/14740\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Petr Hosek \u003cphosek@google.com\u003e\n" }, { "commit": "27b90626701a112217a9244022c729231ebcc3a0", "tree": "c5ec8beadc1d2c14975c65e7b289af2da8929364", "parents": [ "57c352b2b03461c24b19c678c61d7aeacc6981f4" ], "author": { "name": "Aaron Wood", "email": "aaronwood@google.com", "time": "Thu Sep 29 14:20:10 2022 -0700" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Oct 20 20:48:52 2022 +0000" }, "message": "[visibility] Add the toolchain to the labels in the visibility error message\n\nWhen printing the error message for visibility restrictions,\nprint the label with the toolchain to clarify how the\nvisiblity restriction is being encountered.\n\nChange-Id: I5c52054415541261c2abcb5c95596b1604d49327\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/14640\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Aaron Wood \u003caaronwood@google.com\u003e\n" }, { "commit": "57c352b2b03461c24b19c678c61d7aeacc6981f4", "tree": "eb6dd1ff0b5c41991954154568490d6c094ba62f", "parents": [ "b9c6c19be95a3863e02f00f1fe403b2502e345b6" ], "author": { "name": "Nathan Memmott", "email": "memmott@chromium.org", "time": "Mon Oct 17 10:08:24 2022 -0700" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Oct 18 02:44:48 2022 +0000" }, "message": "Fix the testonly flag for gn ls\n\nThis fixes a problem where running \u0027gn ls\u0027 with \u0027--testonly\u003dtrue\u0027 would\nnot filter out targets who did not have testonly set to true in their\nBUILD.gn file.\n\nBug: 288\nChange-Id: I65a5f72d459a0f90fdac58249b5a1661edb66525\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/14680\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "b9c6c19be95a3863e02f00f1fe403b2502e345b6", "tree": "dc83c794bf1e8d918bceb7c27d6f45e527872d21", "parents": [ "cc28efe62ef0c2fb32455f414a29c4a55bb7fbc4" ], "author": { "name": "Sylvain Defresne", "email": "sdefresne@chromium.org", "time": "Wed Oct 05 10:39:54 2022 +0200" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Oct 05 08:51:45 2022 +0000" }, "message": "[swift] Consider swift bridge_header as a source file\n\nThe target that builds .swift files may use an optional bridge header.\nThis header is used to import Objective-C types in Swift when modules\nare not used (which Chromium currently does not support).\n\nAs this header may include any file from the project, it needs to be\nconsidered as a source file (it cannot be listed in sources directly\nas mixed languages is not supported for .swift files).\n\nThis fixes `gn check` for the target that uses .swift with a bridge\nheader (which happens in Chromium).\n\nBug: 305\nChange-Id: Iac64c88258302b4f39d8feafc5eb020cfea8efa8\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/14660\nCommit-Queue: Sylvain Defresne \u003csdefresne@chromium.org\u003e\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "cc28efe62ef0c2fb32455f414a29c4a55bb7fbc4", "tree": "828803727582f8f4fcac51694e1be797ec51a763", "parents": [ "e70d8c3d5620bc0ddcbad23a36b1b26f815ca90a" ], "author": { "name": "Brett Wilson", "email": "brettw@chromium.org", "time": "Wed Sep 14 14:18:21 2022 -0700" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Sep 16 14:09:35 2022 +0000" }, "message": "Add glob FAQ entry\n\nChange-Id: I5463c8ea6578ff2af0d72a19df48bce44afb08de\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/14560\nReviewed-by: Petr Hosek \u003cphosek@google.com\u003e\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\n" }, { "commit": "e70d8c3d5620bc0ddcbad23a36b1b26f815ca90a", "tree": "4373ac5ab34356777491f656743bcadae66fca63", "parents": [ "1da84bb3dac17cd6131fd5067399caa6e7e848c6" ], "author": { "name": "Joshua Seaton", "email": "joshuaseaton@google.com", "time": "Thu Sep 15 20:20:13 2022 +0000" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Sep 15 23:08:25 2022 +0000" }, "message": "Revert \"Record generated_file()s as outputs of `gn`\"\n\nThis reverts commit 23ede3b7b53f5bc56d3952c6d727f167cae34ab2.\n\nReason for revert: seeing errors in which `gn gen` dirties build.ninja, which results in an infinite loop.\n\nOriginal change\u0027s description:\n\u003e Record generated_file()s as outputs of `gn`\n\u003e\n\u003e This is an accurate relationship and allows for tooling to ensure a\n\u003e given generated_file() is up-to-date without an unconditional `gn gen`.\n\u003e\n\u003e build.ninja was manually verified in a particular GN-based build,\n\u003e wherein `ninja $SOME_GENERATED_FILE` now works.\n\u003e\n\u003e Fixed: 301\n\u003e Change-Id: I06c7ec142072d2e73860cdde4898af6f9e65065a\n\u003e Reviewed-on: https://gn-review.googlesource.com/c/gn/+/14580\n\u003e Commit-Queue: Joshua Seaton \u003cjoshuaseaton@google.com\u003e\n\u003e Reviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n\nTBR\u003dbrettw@chromium.org,brettw@google.com,joshuaseaton@google.com,gn-scoped@luci-project-accounts.iam.gserviceaccount.com\n\nChange-Id: Iae22482c42eafeff0cb0b54d204be4693f4f3208\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/14600\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\nCommit-Queue: Nico Weber \u003cthakis@chromium.org\u003e\nReviewed-by: Joshua Seaton \u003cjoshuaseaton@google.com\u003e\n" }, { "commit": "1da84bb3dac17cd6131fd5067399caa6e7e848c6", "tree": "63609d9bbb3b941c426d56abe8120d6c2b7bb4af", "parents": [ "23ede3b7b53f5bc56d3952c6d727f167cae34ab2" ], "author": { "name": "Brett Wilson", "email": "brettw@chromium.org", "time": "Wed Sep 14 15:35:29 2022 -0700" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Sep 15 20:57:45 2022 +0000" }, "message": "Update reference, add script to do so.\n\nUpdates reference.md with the latest GN changes.\n\nAdds a simple script to generate this so you don\u0027t have to remember or\nlook up the correct switches.\n\nChange-Id: If641978f445014b93be3d9a10f59b5415de4faf4\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/14561\nCommit-Queue: Brett Wilson \u003cbrettw@chromium.org\u003e\nReviewed-by: Takuto Ikuta \u003ctikuta@google.com\u003e\n" }, { "commit": "23ede3b7b53f5bc56d3952c6d727f167cae34ab2", "tree": "19a510c7e6558c1b9c686297b5eb4def7f4959de", "parents": [ "fff29c1b3f9703ea449f720fe70fa73575ef24e5" ], "author": { "name": "Joshua Seaton", "email": "joshuaseaton@google.com", "time": "Wed Sep 14 17:14:09 2022 -0700" }, "committer": { "name": "GN LUCI", "email": "gn-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Sep 15 18:11:04 2022 +0000" }, "message": "Record generated_file()s as outputs of `gn`\n\nThis is an accurate relationship and allows for tooling to ensure a\ngiven generated_file() is up-to-date without an unconditional `gn gen`.\n\nbuild.ninja was manually verified in a particular GN-based build,\nwherein `ninja $SOME_GENERATED_FILE` now works.\n\nFixed: 301\nChange-Id: I06c7ec142072d2e73860cdde4898af6f9e65065a\nReviewed-on: https://gn-review.googlesource.com/c/gn/+/14580\nCommit-Queue: Joshua Seaton \u003cjoshuaseaton@google.com\u003e\nReviewed-by: Brett Wilson \u003cbrettw@chromium.org\u003e\n" } ], "next": "fff29c1b3f9703ea449f720fe70fa73575ef24e5" }