commit 0cbe341c1a28037ee32d21b589030a7df0b9fdab
author David 'Digit' Turner <digit@google.com> Tue Apr 12 12:20:10 2022 +0200
committer Commit Bot <commit-bot@chromium.org> Wed Apr 13 15:19:34 2022 +0000
tree 8d13e5710580015d368cadb6e601785dc7d17506
parent cdb4ad4f61a32139a02a63d0ba2044ac3cb8705f

Fix NinjaCBinaryTargetWriter unit-test

The NinjaCBinaryTargetWriter.RustDepsOverDynamicLinking
unit-test defined two Rust rlib targets with public
dependencies to themselves!

This does not make any sense, and is not allowed by the
GN parser itself, nor is it required by the test, so remove
these definitions from the code

For the record, the issue was done while working on some
refactor of target dependency computations, where this
would trigger a stack overflow / infinite recursion.

Bug: None

Change-Id: I9f1c2fe31bc3ec881446c6a16ce2508c65e2fc03
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/13601
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: David Turner <digit@google.com>

src/gn/ninja_c_binary_target_writer_unittest.cc

diff --git a/src/gn/ninja_c_binary_target_writer_unittest.cc b/src/gn/ninja_c_binary_target_writer_unittest.cc
index e4ec800..ff51121 100644
--- a/src/gn/ninja_c_binary_target_writer_unittest.cc
+++ b/src/gn/ninja_c_binary_target_writer_unittest.cc
@@ -1825,7 +1825,6 @@
   rlib3.source_types_used().Set(SourceFile::SOURCE_RS);
   rlib3.rust_values().set_crate_root(lib3);
   rlib3.rust_values().crate_name() = "baz";
-  rlib3.public_deps().push_back(LabelTargetPair(&rlib3));
   rlib3.SetToolchain(setup.toolchain());
   ASSERT_TRUE(rlib3.OnResolved(&err));
 
@@ -1837,7 +1836,6 @@
   rlib2.source_types_used().Set(SourceFile::SOURCE_RS);
   rlib2.rust_values().set_crate_root(lib2);
   rlib2.rust_values().crate_name() = "bar";
-  rlib2.public_deps().push_back(LabelTargetPair(&rlib2));
   rlib2.SetToolchain(setup.toolchain());
   ASSERT_TRUE(rlib2.OnResolved(&err));