commit 12ca980852f2dcba1e155ae215740d0d9a56cf7f
author Joey Scarr <jsca@google.com> Thu Jun 07 00:23:51 2018 +0000
committer Commit Bot <commit-bot@chromium.org> Thu Jun 07 00:23:51 2018 +0000
tree ccb7450c7c9045cb53b4d451a007f43a829de0c3
parent 4aa7dc7da99d12dc3207cff436c3acf968c24fd4

Fix quoting when writing defines on Windows.

For the following string-valued define:
 defines = [ "CR_CLANG_REVISION=\"$clang_revision\"" ]
this was outputting the following on Windows:
 -D"CR_CLANG_REVISION=\"332838-1\""
The Windows shell can't handle the extra quotes, and so the following
macro was being written:
 #define "CR_CLANG_REVISION "332838-1""
This change moves the first quote to before the -D, allowing Windows to
correctly handle the define parameter.

R=brettw@chromium.org

Bug: 396230
Change-Id: I4f6f70acf775577ff9b3077eba9ebf7f8d002da1
Reviewed-on: https://chromium-review.googlesource.com/1071274
Reviewed-by: Brett Wilson <brettw@chromium.org>
Commit-Queue: Joey Scarr <jsca@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#565117}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 44054a1e89063bf0063cfc4d72632c2f1589ee8b