|author||Julie Hockett <firstname.lastname@example.org>||Fri Nov 16 11:10:54 2018 -0800|
|committer||Commit Bot <email@example.com>||Mon Nov 19 15:35:06 2018 +0000|
Explicitly handle all ValueType enum values Since we ran into bugs with scope types not being handled when we added equality, it's cleaner and more expected to explicitly handle all possible values. Change-Id: Id05bb0a434b11de42dce550d9133036e821997e5 Reviewed-on: https://gn-review.googlesource.com/c/3302 Commit-Queue: Julie Hockett <firstname.lastname@example.org> Reviewed-by: Scott Graham <email@example.com>
Alternatively, you can build GN from source:
git clone https://gn.googlesource.com/gn cd gn python build/gen.py ninja -C out # To run tests: out/gn_unittests
On Windows, it is expected that
lib.exe can be found in
PATH, so you'll want to run from a Visual Studio command prompt, or similar.
On Linux and Mac, the default compiler is
clang++, a recent version is expected to be found in
PATH. This can be overridden by setting
If you find a bug, you can see if it is known or report it in the bug database.
GN uses Gerrit for code review. The short version of how to patch is:
Register at https://gn-review.googlesource.com. ... edit code ... ninja -C out && out/gn_unittests
Then, to upload a change for review:
git commit git cl upload --gerrit
When revising a change, use:
git commit --amend git cl upload --gerrit
which will add the new changes to the existing code review, rather than creating a new one.
We ask that all contributors sign Google's Contributor License Agreement (either individual or corporate as appropriate, select ‘any other Google project’).
You may ask questions and follow along w/ GN‘s development on Chromium’s gn-dev@ Google Group.