commit 384850bb74ccd6593ae7c959337646e5a4682fcd
author Julie Hockett <juliehockett@google.com> Fri Nov 16 11:10:54 2018 -0800
committer Commit Bot <commit-bot@chromium.org> Mon Nov 19 15:35:06 2018 +0000
tree 5eb8e5d23e6a85a1a4529cc1a3ef1838b426a798
parent 1426651d48d1630b607884f099e7925503ff5e14

Explicitly handle all ValueType enum values

Since we ran into bugs with scope types not being handled when we added
equality, it's cleaner and more expected to explicitly handle all
possible values.

Change-Id: Id05bb0a434b11de42dce550d9133036e821997e5
Reviewed-on: https://gn-review.googlesource.com/c/3302
Commit-Queue: Julie Hockett <juliehockett@google.com>
Reviewed-by: Scott Graham <scottmg@chromium.org>

tools/gn/operators.cc

diff --git a/tools/gn/operators.cc b/tools/gn/operators.cc
index 33fbcb2..ad25159 100644
--- a/tools/gn/operators.cc
+++ b/tools/gn/operators.cc
@@ -312,7 +312,7 @@
       }
       break;
 
-    default:
+    case Value::NONE:
       break;
   }
 }

tools/gn/value.cc

diff --git a/tools/gn/value.cc b/tools/gn/value.cc
index aff4ab1..dc81a37 100644
--- a/tools/gn/value.cc
+++ b/tools/gn/value.cc
@@ -197,7 +197,10 @@
       return true;
     case Value::SCOPE:
       return scope_value()->CheckCurrentScopeValuesEqual(other.scope_value());
+    case Value::NONE:
+      return false;
     default:
+      NOTREACHED();
       return false;
   }
 }