commit 3d165b905e7ca38cc8c69bcf292c689c6a06d889
author Gary Boone <gboone@google.com> Tue Oct 20 16:52:05 2020 -0700
committer Commit Bot <commit-bot@chromium.org> Wed Oct 21 00:40:30 2020 +0000
tree a20908c907e442a6146c2ca6ed40bd528c4e83ab
parent ad0a7ada45cd7a3781a00175286a05519b4bdefc

Correct the `gn format --dump-tree=json ...` command to write to stdout instead of stderr.

Change-Id: I97d13f364ff00e2e853a700df81056498e4f2248
Reviewed-on: https://gn-review.googlesource.com/c/gn/+/10440
Reviewed-by: Petr Hosek <phosek@google.com>
Commit-Queue: Petr Hosek <phosek@google.com>

src/gn/command_format.cc

diff --git a/src/gn/command_format.cc b/src/gn/command_format.cc
index 7219131..249c2ae 100644
--- a/src/gn/command_format.cc
+++ b/src/gn/command_format.cc
@@ -1209,19 +1209,19 @@
               TreeDumpMode dump_tree,
               std::string* output) {
 #if defined(OS_WIN)
-    // Set stderr to binary mode to prevent converting newlines to \r\n.
-    _setmode(_fileno(stderr), _O_BINARY);
+    // Set stdout to binary mode to prevent converting newlines to \r\n.
+    _setmode(_fileno(stdout), _O_BINARY);
 #endif
 
   if (dump_tree == TreeDumpMode::kPlainText) {
     std::ostringstream os;
     RenderToText(root->GetJSONNode(), 0, os);
-    fprintf(stderr, "%s", os.str().c_str());
+    fprintf(stdout, "%s", os.str().c_str());
   } else if (dump_tree == TreeDumpMode::kJSON) {
     std::string os;
     base::JSONWriter::WriteWithOptions(
         root->GetJSONNode(), base::JSONWriter::OPTIONS_PRETTY_PRINT, &os);
-    fprintf(stderr, "%s", os.c_str());
+    fprintf(stdout, "%s", os.c_str());
   }
 
   Printer pr;